News adding

[BryonS]

I am having troubles with this script.. its a script that uses a form to add news to the news page.. i also found someones code for dynamic includes (www.yourcom.com/index.php?page=pagex) and im using that and its including my pages into the body.. but i dont know if you needed to know that well heres my code then ill tell you what happens...

[code=php]
<? 
function OpenNews() {
echo "<table width=\"500\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\" height=\"18\">
<tr> 
            <td background=\"images/newsbg1.gif\" width=\"498\" height=\"30\"> <b>&nbsp;$time Posted By: <a href=\"mailto:$email\">$poster</a> <a href=\"?id=25\">Add New Post</a></b>            </td>
</tr>
  <tr>
  <td background=\"images/newsbg2.gif\" width=\"498\" height=\"14\">
<!----->
<center><span id=\"News\">";
}

function CloseNews() {
echo "</span></center>
<!----->
</td>
</tr>
  <tr>
  <td width=\"498\" valign=\"top\" background=\"images/newsbg3.gif\" height=\"1\">&nbsp;

 </td>  

 </tr>
</table>";
}
$time = date("F jS Y, h:iA");
$form = "
<form method=\"post\" action=\"AddNews.php\">
Your Name:  <input type=\"text\" name=\"poster\" size=20><br>
Your Email:  <input type=\"text\" name=\"email\" size=20><br>
Your News:<br><textarea name=\"message\" cols=30 rows=5 wrap=virtual></textarea><br>
<input type=\"hidden\" name=\"op\" value=\"ds\">
<input type=\"submit\" name=\"submit\" value=\"add news\">
</form>
";
if ($op != "ds") { 
echo "$form";
}
else if ($op == "ds") {
if ($poster == "") {
	$name_err = "<font color=red>Please enter your name...</font>";
	$add = "no";
}
if ($message == "") {
	$news_err = "<font color=red>Please enter your news...</font>";
	$add = "no";
}
if ($email == "") {
	$email_err = "<font color=red>Please enter your email...</font>";
	$add = "no";
}
if ($add != "no") {
$fp = fopen("Includes/news.php",  "w");  

fputs(OpenNews() . "$message" . CloseNews(), $fp);  

fclose($fp);
} else if ($add == "no") {
echo "$name_err";
echo "$email_err";
echo "$news_err";
echo "$form";
}
}
?>

[/CODE]

when i submit it whethere i filled it out or not it jus puts me back at index.php not changing anything... no error messages or anything... I am new to php so im not really sure whats wrong... and i know its pretty sloppy code this file is AddNews.php.... i dont know if it could be something with the ?page=page thing since it goes back to index.php on submit...

[dbchip2000]

One thing you will have to check is that register_globals is set to on. Otherwise, you should refer to fields and variables as $_POST["op"] (since the form is posting). That may be your problem.

[BryonS]

so you dont see any errors in my coding? Register_globals is on..

i think ill just take out the dynamic include stuff... even though it seems ot make it easier all the scripts i write now wont work =(

[BryonS]

in my code... i get an error on this line...

fputs(OpenNews() . "$message" . CloseNews(), $fp); 

Warning: fputs(): supplied argument is not a valid stream resource in c:\program files\apache group\apache\htdocs\addnews.php on line 78

Any ideas?

[dbchip2000]

Not very sure, but try a lower case "i" for fopen("includes...") if that is what it is on your filesystem. You also may have to do it starting at the root ex. C:\Inetpub\wwwroot\includes\news.php Someone else could be of more help though

[dbchip2000]

Instead of echoing in your functions OpenNews and CloseNews, use the function return, so it is

function OpenNews() {
return("<table width=\"500\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\" height=\"18\">
<tr> 
            <td background=\"images/newsbg1.gif\" width=\"498\" height=\"30\"> <b>&nbsp;$time Posted By: <a href=\"mailto:$email\">$poster</a> <a href=\"?id=25\">Add New Post</a></b>            </td>
</tr>
  <tr>
  <td background=\"images/newsbg2.gif\" width=\"498\" height=\"14\">
<!----->
<center><span id=\"News\">");
}

function CloseNews() {
return("</span></center>
<!----->
</td>
</tr>
  <tr>
  <td width=\"498\" valign=\"top\" background=\"images/newsbg3.gif\" height=\"1\">&nbsp;

 </td>  

 </tr>
</table>");
}