money problems!!!

[madhavr]

hi all

the following script seems to be experiencing problems where any figures in straight thousands are not being displayed properly. to give you an example if i pass 1000 all i get back is one thousand - i dont get pounds and no pence.

$num = 1000;
echo " num is: ".makewords($num)."<br>";
$theWord = makewords($num);
$y = 2500;
$x =200;
$words=explode(" ",$theWord);
$counter=0;
$second=false;
while ($words[$counter]) {
     if ($second || ($counter>5 && strlen($theWord)>=8 && $words[$counter]=="AND")) {
          $sentence2.=$words[$counter]." ";
          $second=true;
     } // end if
     else $sentence1.=$words[$counter]." ";
$counter++;
} // end while
      // printer_draw_text($handle, "sentence 1: ".$sentence1." ", $x, $y);
	echo "sentence 1 ".$sentence1."<br>";
if ($sentence2) {
     $y+=250;
// echo "<br>";
     $x=200;
   //  printer_draw_text($handle, "sentence 2: ".$sentence2." ", $x, $y);
	echo "sentence 2 ".$sentence2."<br>";
}

the above is the problem script. please ignore anything to do with printer draw text thats just for me to output to printer. for your reference i have added the makewords function below which works fine by the way.

any comments well appreciated

thank you

function makewords($numval)
{
$moneystr = "";
// handle the millions
$milval = (integer)($numval / 1000000);
if($milval > 0)
  {
  $moneystr = getwords($milval) . " Million";
  }

// handle the thousands
$workval = $numval - ($milval * 1000000); // get rid of millions
$thouval = (integer)($workval / 1000);
if($thouval > 0)
  {
  $workword = getwords($thouval);
  if ($moneystr == "")
    {
    $moneystr = $workword . " Thousand";
    }
  else
    {
    $moneystr .= " " . $workword . " Thousand";
    }
  }

// handle all the rest of the dollars
$workval = $workval - ($thouval * 1000); // get rid of thousands
$tensval = (integer)($workval);
if ($moneystr == "")
  {
  if ($tensval > 0)
    {
    $moneystr = getwords($tensval);
    }
  else
    {
    $moneystr = "Zero";
    }
  }
else // non zero values in hundreds and up
  {
  $workword = getwords($tensval);
  $moneystr .= " " . $workword;
  }

// plural or singular 'dollar'
$workval = (integer)($numval);
if ($workval == 1)
  {
  $moneystr .= " Pound And ";
  }
else
  {
  $moneystr .= " Pounds And ";
  }

// do the pennies - use printf so that we get the
// same rounding as printf
$workstr = sprintf("%3.2f",$numval); // convert to a string
$intstr = substr($workstr,strlen - 2, 2);
$workint = (integer)($intstr);
if ($workint == 0)
  {
  $moneystr .= "No";
  }
else
  {
  $moneystr .= getwords($workint);
  }
if ($workint == 1)
  {
  $moneystr .= " Pence";
  }
else
  {
  $moneystr .= " Pence";
  }

// done - let's get out of here!
return $moneystr;
}

//**********************************************
// this function creates word phrases in the range of 1 to 999.
// pass it an integer value
//**********************************************
function getwords($workval)
{
$numwords = array(
  1 => "One",
  2 => "Two",
  3 => "Three",
  4 => "Four",
  5 => "Five",
  6 => "Six",
  7 => "Seven",
  8 => "Eight",
  9 => "Nine",
  10 => "Ten",
  11 => "Eleven",
  12 => "Twelve",
  13 => "Thirteen",
  14 => "Fourteen",
  15 => "Fifteen",
  16 => "Sixteen",
  17 => "Seventeen",
  18 => "Eighteen",
  19 => "Nineteen",
  20 => "Twenty",
  30 => "Thirty",
  40 => "Forty",
  50 => "Fifty",
  60 => "Sixty",
  70 => "Seventy",
  80 => "Eighty",
  90 => "Ninety");

// handle the 100's
$retstr = "";
$hundval = (integer)($workval / 100);
if ($hundval > 0)
  {
  $retstr = $numwords[$hundval] . " Hundred";
  }

// handle units and teens
$workstr = "";
$tensval = $workval - ($hundval * 100); // dump the 100's
if (($tensval < 20) && ($tensval > 0))// do the teens
  {
  $workstr = $numwords[$tensval];
  }
else // got to break out the units and tens
  {
  $tempval = ((integer)($tensval / 10)) * 10; // dump the units
  $workstr = $numwords[$tempval]; // get the tens
  $unitval = $tensval - $tempval; // get the unit value
  if ($unitval > 0)
    {
    $workstr .= " " . $numwords[$unitval];
    }
  }

// join all the parts together and leave
if ($workstr != "")
  {
  if ($retstr != "")
    {
    $retstr .= " " . $workstr;
    }
  else
    {
    $retstr = $workstr;
    }
  }
return $retstr;
}

[pete_bisby]

You had:

// handle all the rest of the dollars 
$workval = $workval - ($thouval * 1000); // get rid of thousands

Should it be:

// handle all the rest of the dollars 
$workval = $numval - ($thouval * 1000); // get rid of thousands

[madhavr]

hi mate

thats not my problem since the makewords function works perfectly fine

my problem is with the script above

if you pass it makewords(1000)

it just returns one thousand

instead of one thousand pounds and no pence

whats with that?

[pete_bisby]

I've just copied and pasted your code and ran it on my server - it returned "num is: One Thousand Pounds And No Pence".

I promise I didn't change anything - what version of PHP are you using? I'm using 4.3.0

[madhavr]

my attention is on this line ...

 echo "sentence 1 ".$sentence1."<br>"; 

so it should say sentence 1 prior to one thousand pounds and no pence

i am using versionj 4.3.2

[pete_bisby]

An extra space is being inserted between "Thousands" and Pence - check the result in Notepad and you can see it.

When you put this string through the explode() function, it is putting a space within the array. And because it is encountering the space within your while loop, it is exiting out.

Either find the extra space in the code or try a different loop routine:

for ($i=0; $i < sizeof($words); $i++) {
  $sentence1 .= $words[$i] . " ";
}
echo $sentence1 . "<br>";