SQL update syntax error

fizzwizz

Could someone tell me what is wrong with this syntax? It doesn't update the field values for unique and hits.

$query = "UPDATE counter SET ('unique=$unique','hits=$hits')";
$result = mysql_query($query);
if ($result) {$check = "true";}

Thanx again

jernhenrik

try:
$query="UPDATE Counter SET unique='".$unique."', hits='".$hits."'";

hth

[edit]forgot to ask if you perhaps need a where clause? Like a reference to your primary key..but since i dont know your db setup this is just a shot in the dark

eg:

$query="UPDATE Counter SET unique='".$unique."', hits='".$hits."' WHERE id='1234'";

[/edit]

fizzwizz

Sorry, that's not doing it neither!

fizzwizz

I created a new field "id" made it primary, gave it a value, and used your syntax.
Yet it still does not update. I'll recheck my other code but its only a short script and I'm sure it's correct (exept the SQL part). Any more ideas?

jernhenrik

Could you try this and tell what error you got:
$result=mysql_query($query) or die ("Error: ".mysql_error()."\n");

superwormy

$query = "UPDATE counter SET (unique='$unique',hits='$hits')";

Your ' are in the wrong place, try the one above. You don't surroudn field names with ', only the values.

uniflare

In my SQL code i always surround my table names with ` , and surround field names with " and surround values with ' , so i would put:

$query = 'UPDATE counter SET "unique"=\''.$unique.'\', "hits"=\''.$hits.'\'';

trooper

Originally posted by uniflare
In my SQL code i always surround my table names with ` , and surround field names with " and surround values with ' , so i would put:

$query = 'UPDATE counter SET "unique"=\''.$unique.'\', "hits"=\''.$hits.'\'';

You are creating problems for yourself by doing that (hence this post 😃 ) as it makes it difficult to debug and read.

Take superworms' suggestion and only put the ' around the actual variables. And also use jernhenriks suggestion of putting mysql_error on the call to mysql_query

$query = "UPDATE counter SET unique='$unique',hits='$hits'";

$result = mysql_query($query)or die(mysql_error());

if ($result) {$check = "true";}

superwormy

And for this:

$check = "true";

If you want to use $check as a boolean variable, which it seems you do, don't put "true" in "quotes" because that forces it to be a string, it should be like this:

$check = true;

fizzwizz

Thanks for the help, it turns out the error was using the field name "unique" which is also a php command. I changed the field name and everything was ok.