Endless loop????

Dr_Freak2

Hello,everyone.🙂

I am compiling a code which is a poll class.And one of the method is getOption.The code is as follows:

function getOption($pollId){

$result=mysql_query("SELECT OptionName FROM poll_options WHERE PollID='".$pollId."'");
return mysql_fetch_assoc($result);

}

And when I tried to use this method with the code below:

while($row=$poll->getOption(18)){
echo $row["OptionName"];
}

To my surprise,the result is the same and have an endless loop!!But my table has just 4 records!!!And the results are the same.e.g.Excellent Excellent.......

Please help before I pulled out all my hairs out.🙁 I have to say I am not bald.

laserlight

Well, I think it doesnt work as the query is executed every time, so there's new resource on every iteration, so the loop never exits.

A possible solution would be for getOption() to return the resource, which is then handled by a loop, e.g.

function getOption($pollId){
	return mysql_query("SELECT OptionName FROM poll_options WHERE PollID='". $pollId. "'");
}

and then

while ($row = mysql_fetch_assoc($poll->getOption(18))) {
	echo $row["OptionName"];
}

Dr_Freak2

First of all,thanks for you reply laserlight.

Well,it doesn't work.The same problem still exists....🙁 What I don't know is that I have no problem if I put mysql_fetch_assoc($result)
in the class's method then it will be fine...

I've never have class problems like this one spends me more than 1 hour to figure out. :mad:

I will try to figure it out....

barand

a while loop will execute until it evaluates to false.

This one always gets poll id 18, evaluates to true, and displays the result for poll 18 and will do so until it gets a false result - and it never will.

Use getOption($id) to get a single option name - no "while".

If you want to get a list of the options, something like

function getOptions(&$pollId_array){ 

$result=mysql_query("SELECT PollId, OptionName FROM poll_options"); 
while (list($id,$name) =  mysql_fetch_row($result) ) {
    $pollid_array[$id] = $name;
} 

} 

// and call function with 

$pollid_array = array();
$poll->getOptions($pollid_array);
foreach ($pollid_array as $pid=>$pname) {
   echo "$pid   $pname<br>";
}

Dr_Freak2

barand,do you have another method to do it??Because I don't quite understand about your code.

Thanks.🙂

laserlight

I think I know why my example didnt work either: the loop called the member function on each iteration, hence a new resource was generated every time, so the loop never exits.

I would like to know: what is an option?

Try this:

$pollId = 18;
$query = mysql_query("SELECT OptionName FROM poll_options WHERE PollID='$pollId'");
while ($row = mysql_fetch_assoc($query)) {
	echo $row['OptionName'];
}

If it works, then try:

function getOption($pollId) {
	$query = mysql_query("SELECT OptionName FROM poll_options WHERE PollID='$pollId'");
	$result = array();
	while ($row = mysql_fetch_assoc($query)) {
		$result[] = $row['OptionName'];
	}
	return $result;
}

upon which you would use:

$result = $poll->getOption(18);
foreach ($result as $option) {
	echo $option;
}

barand's method might work, but the problem is that we dont know how your poll is organised, so we are second-guessing what you want.

barand

Originally posted by laserlight
so we are second-guessing what you want.

I'll second that

Dr_Freak2

Thanks for your reply again,laserlight.It works! 🙂 After I have a nap,20 minutes,I realized what your code means because I am drowsy and sluggish before.:p

Originally posted by laserlight
so we are second-guessing what you want.

Maybe I don't know what I want.😃 I'm kidding.Well,Option means the poll's question options.For example,when I ask a question about my website design,I would have to add option like "Excellent","Good","Bad".Do you know what I am saying?

Yup,thanks for your reply too,barand.