Whats wrong? UPLOAD SCRIPT RANDOM GENERATOR

[iBuddy]

I dont understand whats wrong with this its driving me nuts!

<? 
//Confirmation of images     

    function str_makerand ($minlength, $maxlength, $useupper, $usespecial, $usenumbers) 
    { 
    $randName = str_makerand(10,10,false,false,false); 
    function uploadProg($filename1,$randName,$filename2,$randName,$filename3,$randName,$filename4,$randName,$filename5,$randName){ 



$charset = "abcdefghijklmnopqrstuvwxyz"; 
if ($useupper)   $charset .= "ABCDEFGHIJKLMNOPQRSTUVWXYZ"; 
if ($usenumbers) $charset .= "0123456789"; 
if ($usespecial) $charset .= "~@#$%^*()_+-={}|][";   // Note: using all special characters this reads: "~!@#$%^&*()_+`-={}|\\]?[\":;'><,./"; 
if ($minlength > $maxlength) $length = mt_rand ($maxlength, $minlength); 
else                         $length = mt_rand ($minlength, $maxlength); 
for ($i=0; $i<$length; $i++) $key .= $charset[(mt_rand(0,(strlen($charset)-1)))]; 
return $key; 
} 
########Set the destination here############## 
    $destination="/home/cspot/public_html/member_rides/"; 
    copy($filename1,$destination."/".$filename1_name); 
    copy($filename2,$destination."/".$filename2_name); 
    copy($filename3,$destination."/".$filename3_name); 
    copy($filename4,$destination."/".$filename4_name); 
    copy($filename5,$destination."/".$filename5_name); 

//change this variable $dest2 to the path you are saving items to 
$dest2 = "http://www.civicspot.com/member_rides"; 
echo "<h1>File(s) Uploaded...</h1>"; 
if ($filename1_name == "") { 
echo "No file was uploaded for upload 1<br>"; 
} 
else 
{ 
echo "<br><b><a href='$dest2$filename1_name'>$filename1_name</a> was uploaded succesfully.</b><br>"; 
echo "Thise file was stored at: $dest2$filename1_name<br><br>"; 

} 

if ($filename2_name == "") { 
    echo "No file was uploaded for upload 2<br>"; 
    } 
    else 
    { 

echo "<br><b><a href='$dest2$filename2_name'>$filename2_name</a> was uploaded succesfully.</b><br>"; 
    echo "Thise file was stored at: $dest2$filename2_name<br><br>"; 
    } 
     if ($filename3_name == "") { 
    echo "No file was uploaded for upload 3<br>"; 
    } 
    else 
    { 
echo "<br><b><a href='$dest2$filename3_name'>$filename3_name</a> was uploaded succesfully.</b><br>"; 
    echo "Thise file was stored at: $dest2$filename3_name<br><br>"; 
    } 
     if ($filename4_name == "") { 
    echo "No file was uploaded for upload 4<br>"; 
    } 
    else 
    { 

echo "<br><b><a href='$dest2$filename4_name'>$filename4_name</a> was uploaded succesfully.</b><br>"; 
    echo "Thise file was stored at: $dest2$filename4_name<br><br>"; 
    } 
     if ($filename5_name == "") { 
    echo "No file was uploaded for upload 5<br>"; 
    } 
    else 
    { 
echo "<br><b><a href='$dest2$filename5_name'>$filename5_name</a> was uploaded succesfully.</b><br>"; 
    echo "Thise file was stored at: $dest2$filename5_name<br><br>"; 
    } 
    echo "<br><br><a href=\"upload.php\">Click here to go back.</a>"; 
    } 
    function main(){?> 
    <form method="post" action="<? echo $PHP_SELF; ?>" enctype="multipart/form-data"> 

  <p>Files to Upload:<br> 
    <input type="file" name="filename1" size="20" tabindex="1"> 
    <br> 
    <input type="file" name="filename2" size="20" tabindex="2"> 
    <br> 
    <input type="file" name="filename3" size="20" tabindex="3"> 
    <br> 
    <input type="file" name="filename4" size="20" tabindex="4"> 
    <br> 
    <input type="file" name="filename5" size="20" tabindex="5"> 
    <br> 
    <input type="hidden" name="action" value="uploadProg"> 
    <input type="submit" value="Upload Files" tabindex="6"> 
  </p> 
  <p><a href="<?echo $dest2; ?>">Click here to view the folder of current items</a></p> 
</form><?} 
    switch ($action){ 
    default: 
    main(); 
    break; 
    case "uploadProg": 
    if ($filename1=="none") {echo("<h1>No File Selected....</h1>"); break;} 
    uploadProg($filename1,$randName,$filename2,$randName,$filename3,$randName,$filename4,$randName,$filename5,$randName); 
    break; 
    } 

?> 

[Natty_Dreadlock]

maybe use move_uploaded_file instead of copy ... check docu at www.php.net/move_uploaded_file and also read the uploading files guide

[iBuddy]

okay I got the script to work just perfectly...however when the file uploads it adds generates a random filename and it includes the current filename with it...for example.....

if I uploaded the file "image.gif"
it would upload "sdfs9ifimage.gif"
what do I need to edit below to just have the entire image filename random and include the file extension here is my coding

<?
function str_makerand ($minlength, $maxlength, $useupper, $usespecial, $usenumbers)
  {
  $charset = "abcdefghijklmnopqrstuvwxyz";
  if ($useupper)   $charset .= "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
  if ($usenumbers) $charset .= "0123456789";
  if ($usespecial) $charset .= "~@#$%^*()_+-={}|][";   // Note: using all special characters this reads: "~!@#$%^&*()_+`-={}|\\]?[\":;'><,./";
  if ($minlength > $maxlength) $length = mt_rand ($maxlength, $minlength);
  else                         $length = mt_rand ($minlength, $maxlength);
  for ($i=0; $i<$length; $i++) $key .= $charset[(mt_rand(0,(strlen($charset)-1)))];
      return $key;
  }

//user defined variables
$abpath = "/home/cspot/public_html/member_rides"; //Absolute path to where images are uploaded. No trailing slash
$sizelim = "yes"; //Do you want size limit, yes or no
$size = "1500"; //What do you want size limited to be if there is one
$number_of_uploads = 5;  //Number of uploads to occur

if ($_REQUEST['submitted']){ // Begin processing portion of script

//all image types to upload
$cert1 = "image/pjpeg"; //Jpeg type 1
$cert2 = "image/jpeg"; //Jpeg type 2
$cert3 = "image/gif"; //Gif type
$cert4 = "image/ief"; //Ief type
$cert5 = "image/png"; //Png type
$cert6 = "image/tiff"; //Tiff type
$cert7 = "image/bmp"; //Bmp Type
$cert8 = "image/vnd.wap.wbmp"; //Wbmp type
$cert9 = "image/x-cmu-raster"; //Ras type
$cert10 = "image/x-x-portable-anymap"; //Pnm type
$cert11 = "image/x-portable-bitmap"; //Pbm type
$cert12 = "image/x-portable-graymap"; //Pgm type
$cert13 = "image/x-portable-pixmap"; //Ppm type
$cert14 = "image/x-rgb"; //Rgb type
$cert15 = "image/x-xbitmap"; //Xbm type
$cert16 = "image/x-xpixmap"; //Xpm type
$cert17 = "image/x-xwindowdump"; //Xwd type

$log = "";

for ($i=0; $i<$number_of_uploads; $i++)
  {
    //checks if file exists
    if ($img_name[$i] == "")
    {
        $log .= "No file selected for upload $i<br>";
    }

  if ($img_name[$i] != "")
    {
    // change the image name to itself with 2 to 8 random characters in front of it...
    $original_name = $img_name[$i];
    $random = str_makerand(4,6,0,0,0);
    $img_name[$i] = $random . $original_name;
    echo $img_name[$i] . '<br>';

    //checks if file exists
    if (file_exists("$abpath/$img_name[$i]"))
  {
        $log .= "File $i already existed<br>";
  }
  else
  {
        //checks if files to big
        if (($sizelim == "yes") && ($img_size[$i] > $size))
    {
            $log .= "File $i was too big<br>";
    }
    else
    {
            //Checks if file is an image
            if (($img_type[$i] == $cert1) or ($img_type[$i] == $cert2) or ($img_type[$i] == $cert3) or ($img_type[$i] == $cert4) or ($img_type[$i] == $cert5) or ($img_type[$i] == $cert6) or ($img_type[$i] == $cert7) or ($img_type[$i] == $cert8) or ($img_type[$i] == $cert9) or ($img_type[$i] == $cert10) or ($img_type[$i] == $cert11) or ($img_type[$i] == $cert12) or ($img_type[$i] == $cert13) or ($img_type[$i] == $cert14) or ($img_type[$i] == $cert15) or ($img_type[$i] == $cert16) or ($img_type[$i] == $cert17))
      {
                @copy($img[$i], "$abpath/$img_name[$i]") or $log .= "Couldn't copy image $i to server<br>";
                if (file_exists("$abpath/$img_name[$i]"))
        {
                    $log .= "File $i was uploaded<br>";
        }
        }
        else
        {
                    $log .= "File $i is not an image<br>";
                }
            }
        }
    }
}

?>

<html>
<head>
<title>Image Report</title>
</head>
<body>
<p>Log:<br>
<?

echo "$log";

?>
</p>
<body>
</html>
<? 
exit;
} // End processing portion of script
?>

<html>
<head>
<title>Upload Image</title>
</head>
<body>
<form method="POST" action="<? echo $PHP_SELF; ?>" enctype="multipart/form-data">
<p>Files to upload:<br>
<? 

for ($j=0; $j<$number_of_uploads; $j++) {
?>
<input type=file name=img[] size=30><br>
<?
}
?>
<input type="hidden" name="submitted" value="true">
<input type="submit" name="submit" value="Upload"> 
</form>
</body>
</html> 

[Natty_Dreadlock]

change

 $img_name[$i] = $random . $original_name; 

to

$original_parts = explode(".", $original_name);
$img_name[$i] = $random . $original_parts[sizeof($original_parts) - 1];

this is gonna give u a randomized name with the original extension
hth