"Find the parse errors - an Echo Lounge Party Game".... :D

dalecosp

So, after reading this thread... I figured ... let's play "find the error".... like I'm so corny....

So for starters, here's an easy one from a recent post ...

for ($i=0, $i<count($j); $i++) {
   // something here...
   }

Find it, point it out, and then post your own......

planetsim

Hmmm thats a toughy

for ($i=0, $i<count($j); $i++) { 
   // something here... 
   }

Let me see is it the , after the 0

I dont actually have one at the moment.. ill try and make a good one.

jstarkey

This is one of my all time favs. Not sure if I can pull it off here though.

 <?php

header( 'Location: http://phpbuilder.com' );

?>

Might work.

cgraz

headers already sent error. I've seen this one way to many times on this board. The space before you open with a php tag is a space outputted to the browser. Anything outputted to the browser before the call to header() creates an error.

CGraz

jstarkey

Smoooov mooov. 😉

Oh well, I thought it'd be a little harder to pick out using this medium.

laserlight

the problem is that the problem occurs too frequently, so we have been conditioned 🙂

stolzyboy

this is one that beat my buddy up for quite a while, he couldn't figure out what was wrong, he read this thread as i was reading it and told me to post it to see how dumb he was being

<?
if ($row['field_name'] = "1")
{
echo "Allowed";
}
else
{
echo "Not Allowed";
}
?>

The_Chancer

Hmm - and the answer was "Allowed" ??

= - To define something

== is equal to...

Too many bloody marks on the wall (and keyboard) after head hitting on that one...

stolzyboy

he said that one beat him up for 30 minutes, he emailed it to me and i sent it back within 30 seconds of receiving it

The_Chancer

All it takes is a new set of eyes.... and the most glaringly obvious mistake shall come to light.

(I got that one straight away too...)

piersk

Oh come on. We've all done that one...

or is it just me?

dalecosp

Originally posted by The Chancer
All it takes is a new set of eyes.... and the most glaringly obvious mistake shall come to light.

Right. Now, my wife could care less about PHP, or computers in general; so, what I really need is some smart guy (i.e., new set of eyes) who'll work for dinner.... 😃 😃

laserlight

Here's an easy one that puzzled me for a while when I was writing a class:
Say we have a class that handles FTP.
This is part of some member function to upload:

if ($this->getFtpMode($filename) == NULL) {
	//file is invalid
}
else {
	//upload file
}

getFtpMode() is a simplistic member function that returns FTP_ASCII, FTP_BINARY, or NULL depending on the file extension.
dalecosp tries to upload a textfile, piersk.txt
While is it always tagged as invalid?

dalecosp

Well, as I'm an old PH[p]art that's not into OOP, can't say I'm sure, but likely a matter of operator precedence that set the entire expression to NULL prior to evaluating it?

And, technically speaking, that's not a parse error, but a logic/programming one, otherwise known as PBKAC ... but I'm very guilty of those 😉

One of the smart guys will get it if I'm wrong...

Here's one that's all too common, I suppose; culled from some post on here that I thought about responding to, but didn't:

<?php
$auth = false;
if(isset($_POST["login"])) {
   $user = $_POST["username"];
   $password = $_POST["password"];
   $cookie = $_POST["cookie"];
   }
ob_start();
        include("./root.txt");
        $root = ob_get_contents();
ob_end_clean();

$file = file ("$root/data/members.txt");

foreach ($file as $line) {
        list($id, $userdata, $md5password)= explode ("|", $line);
        if($user == $userdata and md5($password) == $md5password) {
            $auth = true;
            } else {
        print("Incorrect username/password combination.");
        }

if ($auth = true)
    {
        header("Set-Cookie: userid=$user; path=/");
            if ($user == $userdata)
                {
                header("Set-Cookie: id=$id; path=/");
                        {
                        header("Set-Cookie: pass=$md5password; path=/");
 header("Location: <a href="http://" target="_blank">http://</a>".$HTTP_SERVER_VARS
['HTTP_HOST']."/forums/index.php");
         print("Thanks.  You are now logged in as: ");
        print("<b>{$user}</b> - <a href='../index.php'>Click ");
        print(" here</a> to return to the forum index.");
                        }
                }
    }
}
?>

which yields ...

Parse error: parse error in /www/phptests/thistest.html on line 31

Of course, there's a couple other things I wouldn't do, either, I suppose....

laserlight

hmm... yes, it is technically a logic error.

goldbug

laserlight: not sure if this impacts your little code snippet or not... kind of a limited scope, but does $filename need to be $this->filename? I've forgotten the 'this->' on occasion, and it takes me too long to spot usually.

goldbug

Originally posted by dalecosp
Well, as I'm an old PH[p]art that's not into OOP, can't say I'm sure, but likely a matter of operator precedence that set the entire expression to NULL prior to evaluating it?

And, technically speaking, that's not a parse error, but a logic/programming one, otherwise known as PBKAC ... but I'm very guilty of those 😉

One of the smart guys will get it if I'm wrong...

Here's one that's all too common, I suppose; culled from some post on here that I thought about responding to, but didn't:
<?php
$auth = false;
if(isset($_POST["login"])) {
   $user = $_POST["username"];
   $password = $_POST["password"];
   $cookie = $_POST["cookie"];
   }
ob_start();
        include("./root.txt");
        $root = ob_get_contents();
ob_end_clean();

$file = file ("$root/data/members.txt");

foreach ($file as $line) {
        list($id, $userdata, $md5password)= explode ("|", $line);
        if($user == $userdata and md5($password) == $md5password) {
            $auth = true;
            } else {
        print("Incorrect username/password combination.");
        }

if ($auth = true)
    {
        header("Set-Cookie: userid=$user; path=/");
            if ($user == $userdata)
                {
                header("Set-Cookie: id=$id; path=/");
                        {
                        header("Set-Cookie: pass=$md5password; path=/");
 header("Location: <a href="http://" target="_blank">[url]http://[/url]</a>".$HTTP_SERVER_VARS
['HTTP_HOST']."/forums/index.php");
         print("Thanks.  You are now logged in as: ");
        print("<b>{$user}</b> - <a href='../index.php'>Click ");
        print(" here</a> to return to the forum index.");
                        }
                }
    }
}
?>
which yields ...

Parse error: parse error in /www/phptests/thistest.html on line 31

Of course, there's a couple other things I wouldn't do, either, I suppose.... [/B]

Well, first thing I notice, is that in the target="" part of the link, the quotes are not escaped.

dalecosp

the quotes are not escaped...

Anything else? 😃

stolzyboy

if ($auth = true)

??if ($auth == true)??

Elizabeth

Originally posted by dalecosp
header("Location: <a href="http://" target="_blank">[url]http://[/url]</a>".$HTTP_SERVER_VARS
['HTTP_HOST']."/forums/index.php");
Parse error: parse error in /www/phptests/thistest.html on line 31

I don't think the use of all those double quotes would make it very happy.

-Elizabeth