identical values added to the database

loveitandhateit

When I test the following script by adding the details to the form and pressing join... the first entry adds to the database fine. BUT the second entry becomes duplicate, meaning the same information is added twice.

function join() {
	global $connect_to_db, $db;

$name = $_POST["name"];
$email = $_POST["email"];
$address = $_POST["address"];
$phone = $_POST["phone"];
$hnumber = $_POST["hnumber"];
$comments = $_POST["comments"];

mysql_db_query ($db, "INSERT into Downloads values ('$name', '$email', '$address', '$phone', '$hnumber', '$comments')", $connect_to_db);
print "<FONT CLASS=\"joined-success\">Thank you $name, your info... NEVER MIND THE REST ITS JUST ALL TEXT AND HAS NO CODE IN IT, THEREFORE CANNOT BE APART OF THE PROBLEM.</FONT>";
}

Any idea as to what am I doing wrong?

DeltaRho2K

What second entry are you referring to? Sorry, not trying to sound dumb here, but it looks like you are only doing one INSERT within your function.

Are you making multiple calls to this function from somewhere else like in a for loop or something? I think the problems lie somewhere else in your code. Post the code around the part(s) from where you are calling this function.

loveitandhateit

I simply use a form to execute this function and it is executed only ONCE. However, when I look at the database there are TWO row that contain identical values.

cgraz

well post the surrounding code to the call to that function. All you've provided is the actual function definition, and it's not inserting twice there. The only possible place I could imaging the problem to be is when you call the function, it is called twice. Possibly within a loop or something.

Cgraz

DeltaRho2K

Yeah, that's where I was going with my earlier post... I just don't see anything within the function itself that would do a double insert...

At any rate loveitandhateit, when I do inserts, I generally build up a function that will first do a SELECT to make sure the info I am inserting isn't already there, just as a way of protecting myself, and preventing double inserts, or multiple submission button clicking... (but that's just me.)

loveitandhateit

Here is the code:

function fillForm() {
print "<FORM ACTION=\"join.php&goto=result\" METHOD=POST>";
	    print "Name<BR>";
	    print "<INPUT TYPE=TEXT NAME=\"name\" SIZE=20><BR>";	   

	    .
	    .
	    .
	    .
	    .
	    print "<INPUT TYPE=SUBMIT NAME=\"SUBMIT\" VALUE=\"Join!\">";
	    print "</FORM>";
}

Between the name textbox and submit button is all <INPUT TYPE=TEXT NAME=\"THE APPROPRIATE FIELD\" SIZE=20><BR>"; NO CODE!!!!

I do not see anything wrong with this code.

BTW

I have PHPNuke installed on my server right now, and sometimes when the users sign up they get two emails, as well as when they submit news I get two copies! I just noticed it. PHPNuke is obviously well tested. Do you think that there is something wrong with the server/php/mysql configuration?

Also,

in something.php I have:
<?
include("header.php");

$variable;

include("footer.php");
?>

AND in header.php I have:
<?
print "$variable";
?>

When I modify $variable in something.php is there anyway I can modify it in header.php?

cgraz

the function join() is the one that inserts into the databse. All you did was post another function. Post the surrounding code when you CALL the function join().

Where in your code do you have just this:

join();

Post that and the surrounding code so we can help you out.

Cgraz

loveitandhateit

You mean this is not a proper way of doing?

I have a switch on the bottom of the page

switch ($goto) {
case "result":
result();
break;
default:
fillForm();
break;
}

loveitandhateit

You'll have to forgive me... I made so many mistakes.
First of all the table that the values go is Members and not Downloads (that's a different section of the website).
AND
join() should be result()!!!

cgraz

so did you get your problem solved?

Cgraz

loveitandhateit

Nope it continues to add the same data twice... could you answer this for me... while for my first problem I will try on another server, because as I said it also happens to PHPNuke (which was tested).

My other problem:

PHP:

in something.php I have:
<?
include("header.php");

$variable;

include("footer.php");
?>

AND in header.php I have:
<?
print "$variable";
?>

When I modify $variable in something.php is there anyway I can modify it in header.php?

cgraz

you're going ot have to be more specific. Look at the code you gave

in something.php I have:
<?
include("header.php");

$variable;

include("footer.php");
?>

AND in header.php I have:
<?
print "$variable";
?>

Just writing $variable in something.php does nothing. You're not defining it, and you're not echoing it or doing anything with it. In header.php, you print it, then you include header.php in something.php

So ultimately, you just want to print $variable in something.php? What is there to modify in header.php?

Cgraz

loveitandhateit

Let's say that $variable = $_POST["something"];

And then I modify it by $variable = $_POST["somethingelsenow"];

I hope this is adequate.

DeltaRho2K

More importantly cgraz, what does that code have to do with anything we are talking about with the problem of the double insertion?!?

loveit...

This should be fine:

<FORM ACTION="join.php&goto=result">

I have a switch on the bottom of the page

switch ($goto) {
case "result":
result();
break;
default:
fillForm();
break;
}

This is the kind of good stuff we need... Now, there may be something else missing somewhere like a close bracket ( } ) somewhere else before you call the switch.

Post the code prior to the switch, and let's see if we can dig a bit deeper here...

loveitandhateit

Currently my website is powered by phpnuke, but I just noticed that the same problem happens in it too, so I think the problem is not with the code (because that's pretty much all of it) but with server configuration (either php or mysql). Therefore nevermind it. Besides you said that the code looks alright. And as for this irrelevant thing, well I thought I might ask it too.

DeltaRho2K

Sorry, I didn't mean anything by that... I missed this in one of your earlier posts...

My other problem:

Anyhow, you can do what you are asking with the $variable part of your question... (If I understand what you are asking.) Did you want to change the $variable by modifying it with a different post? Sure, you can assign the $variable through a POST, GET, or even somewhere coded in the page itself (like in the header.php file)

loveitandhateit

When I modify the value in something.php it doesn't modify it header.php (it uses the old value).

DeltaRho2K

You have to make the change before (or withing the header.php file. If you change the value after the header.php file is parsed, then it won't get the new value, because the php is parsed on the server end before it is output to the browser...

loveitandhateit

That's what I suspected... but isn't there any way (complex, long, ugly, etc) that it can be done withing the something.php and not header.php and still work?

DeltaRho2K

The only way would be to pass the variable through thea GET or POST, and refresh or reload the page altogether. (so the server is forced to reparse the header file.