[Resolved] image rotation? (feel stupid)

taya

Hello, world 🙂

It's me again,

i have a file - images.txt:

and wanted to use it for a simple image rotation -
i got this script i tihink from hotscripts.

i think may be i'm wrong at the line
"<img src='$photo' width=100 height=50 border=0> "?

anyway, when i uploaded my file
travel.php and wanted to have a look at my rotating pics -
there's nothing!

do you thinki made again a stupid mistake somewhere?

thanks!

<?
require ("../page.inc");
require ("content_travel.inc");
require ("form.inc");



$file ="images.txt";
$x = file("$file");
$y = rand(0, sizeof($x)-1);
$photo=$x[$y];




$content = "<table width=100% border=0 cellspacing=0 cellpadding=20>
  <tr width=70%>
    <td>
	<p class=\"header\">Personal Tours
   </p>

  <span class=\"header\"> Personal tours are 
available in the following cities.<br><br>

  Our tours include:<br>
<span class=\"header\">Invitation Visa Support Letter</span><br>
	<br>


<td width=30% valign=\"top\">

<table width=\"100%\" border=0 cellspacing=0
 cellpadding=5 valign=\"top\">
  <tr>
    <td>
<img src='$photo' width=100 height=50 border=0>
</td>
  </tr>
</table>


  </td></tr>
</table>";

$services = new ServicesPage();
   $services ->SetContent($content);
   $services ->Display();
   ?>

Xo_

Well, are you sure the pictures are in the same folder as files.txt and the php script itself? Just a thought...

taya

everything seems corerct - my file.php with the script is in the same folder"services" as images.txt

anf folder with views(photos) is in the same folder "services"

just to make sure - the images.txt. has URL to this folder

<img src=views/city.jpg border=0>
<img src=views/nature.jpg border=0>
<img src=views/bur6.jpg border=0>
and etc.

i can't get it what's the problem..

when i put the variable $photo separately, like


echo($photo);

it' shows perfectly, just above everything including top menu :-)

anyone has more guesses?

dopp

okay I think here's the problem.

Your image.txt file contains the image filenames AND the img HTML tag. Now your content area has the image tag, and asks for the $photo variable.

so if:
$photo = <img src=sunset.jpg border=0>

then:

yields this:

<img src='<img src=sunset.jpg border=0>' width=100 height=50 border=0>

and that is ill-formed HTML. So try changing your images.txt to only hold the file names, like so:

sunset.jpg
sunset1.jpg
sunset8.jpg

hth

Dopp

taya

Thank you so much, smart guy! :-)))

i removed in .txt file all IMG src's
and all <>'s

and also - i had a little change the line

instead of <td><img src='$photo' 
width=280 height=160 border=0 alt=\"whatever\">

I put


<td><img src=".$photo." 
width=280 height=160 border=0 alt=\"whatever\">

so it worked perfectly,
have a great day!

dopp

Good to hear that worked, you have a good day too.