Help - Loop or Array incorrect?

[AngelBaby]

Hi All 🙂

I'm new to PHP - only 2 weeks experience. I've done a lot of research by reading tutorials, finding code snippets, asking friends who do code, etc.

I've been able to accomplish most of what I am trying to do. I've hit a snag with my code and can't seem to find anything that would point me in the right direction to solve it. I read through the sticky for newbies, and nothing there applied to what my code problem is.

I have a DB called search that consists of one table called search_data Inside the table called search_data there are the following fields:

1. search_title

2. search_description

3. search_url

4. search_date

5. search_size
   [/list=1]

   I am attempting to have the table display all row data for each field.

   Example: If there are 200 records in search_data I want to have 20 records per page displayed with pagination to go to the next page.

   Each instance of a row being displayed would have to also display all 5 fields of information as listed above.

   I've managed to hack together enough code to semi-accomplish this - however, the pagination works, but doesn't display X-amount of records on page 1 and then the remainder on page 2, instead it prints them all to page 1 and then when page 2 is clicked to go to, it's all the same set of records all over again.

   I think I've either coded a loop incorrectly or an array incorrectly. I don't know enough about either to know where I've gone wrong.

   This is the code in question:

   <? include 'db.php' ?>
   
   <?php 
   
   $PAGE = (isset($page)) ? $page : 1;  
   
   $dc = mysql_connect($dbhost,$dbuser,$dbpass);  
   
   mysql_select_db($dbname);   
   
   $QUERY = "SELECT * FROM search_data"; 
   $QRETURN= @mysql_query($QUERY);   
   
   $QNUM = @mysql_num_rows($QRETURN);   
   
   $DISPPAGE = 3;  
   
   #DISPPAGE is the number of items displayed per page. 
   $NUMPAGES = ceil($QNUM / $DISPPAGE);  
   
   #NUMPAGES to show how many pages you WILL get. 
   
   if($QRETURN):   
   
   if($QNUM > 0):  
   
        echo "<div align=\"right\">\n<font face=\"Tahoma, Geneva, sans-serif\" size=\"1\">\n";   
   
   for($i = 1; $i <= $NUMPAGES; $i++):  
   #loop to print << 1 2 3... $NUMPAGES >>
   
     if($i == 1 && $PAGE > 1)  
   #Prints the << first to goto the previous page (not on page 1) 
           echo "<a href=\"$PHP_SELF?page=".($PAGE - 1)."\" onMouseOver=\"status='Go to the Previous Page';return true;\" onMouseOut=\"status=' ';return true;\">&#0171;&nbsp;</a>";  
   
     if($i == $PAGE)  
   #Doesn't print a link itself, just prints page number 
           echo "<font color=\"#ff3333\">&nbsp;$i&nbsp;</font>";  
   
     if($i != $PAGE)  #Other links that aren't this page go here 
       echo "<a href=\"$PHP_SELF?page=$i\" onMouseOver=\"status='Go to Page $i';return true;\" onMouseOut=\"status=' ';return true;\">&nbsp;$i&nbsp;</a>";   
   
     if($i == $NUMPAGES && $PAGE != $NUMPAGES)  
   #  Link for next page >>  (not on last page) 
           echo "<a href=\"$PHP_SELF?page=".($PAGE + 1)."\" onMouseOver=\"status='Go to the Next Page';return true;\" onMouseOut=\"status=' ';return true;\">&nbsp;&#0187</a>";   
   
       endfor;   
   
   echo "</font>\n</div>\n";   
   echo "<font face=\"Verdana, Arial, Helvetica, sans-serif\" size=\"2\">\n";   
   $START = ($PAGE - 1) * $DISPPAGE;   
   mysql_data_seek($QRETURN,$START);  
   #Moves the pointer to right row 
   #This loop will go until you a) reach $DISPPAGE or b) there aren't anymore entries 
       for($i = 1; $i <= $DISPPAGE && $ARET = @mysql_fetch_array($QRETURN); $i++):   
   
         $VAR = $ARET["search_title"]; 
   
     echo "$VAR\n<br><br>\n\n"; 
   #echoes the field...        
   
   endfor;   
   
   echo "</font>\n";   
     endif;   
   
     if($QNUM == 0)  
   
   #if we get no rows 
       echo "<div align=\"center\">The database is empty</div>\n";   
   
   endif;   
   
   if(!$QRETURN):   
   # Bogus Query, or mysqld isn't running... 
     echo "<div align=\"center\">\n";   
   
     echo "<font face=\"Arial, Verdana, Helvetica, sans-serif\" color=\"#ff3333\" size=\"3\">\n";   
   
     echo "Either the database is down, or the query was invalid\n";   
   
     echo "</font>\n</div>\n";   
   
   endif;   
   
   ?>   
   
   </body> 
   </html> 
   

   If anyone could tell me where I messed up in this, I'd really appreciate it very much. 🙂

[HalfaBee]

You may need brackets in the for()

for($i = 1; ($i <= $DISPPAGE) && ($ARET = @mysql_fetch_array($QRETURN)); $i++):

I am not sure how PHP handles this, but in C you need the brackets.

or you could move the mysql_fetch_array() into the loop.
It would probably be more readable that way.

if( ($ARET = @mysql_fetch_array($QRETURN))===FALSE )
break;

HalfaBee

HalfaBee

[Muntjewerf]

I've managed to hack together enough code to semi-accomplish this - however, the pagination works, but doesn't display X-amount of records on page 1 and then the remainder on page 2, instead it prints them all to page 1 and then when page 2 is clicked to go to, it's all the same set of records all over again.

This is your query:

$QRETURN= @mysql_query($QUERY);    

Where do you define wich records should be returned? I mean, If you show the first page, the database would probably get record 0 - 20. The pagination probably works, but the query remains the same. Thats why it shows the same records every the time.

I think you should use LIMIT $start,$end in your query to resolve this problem.

greetz Joeri

[HalfaBee]

The script moves to the 'first' record using this line
mysql_data_seek($QRETURN,$START);

not quite the way I would do it, but it should work.

I have a feeling that && could be changed to 'and' and the precedence would change.

HalfaBee

[AngelBaby]

This part of the code here ...

$DISPPAGE = 3;   

#DISPPAGE is the number of items displayed per page. 
$NUMPAGES = ceil($QNUM / $DISPPAGE);   

#NUMPAGES to show how many pages you WILL get. 

... what determines how many records are shown.

$DISPPAGE = 3;
Means 3 records per page (because right now there's only 15 records in the D😎 - so theoretically if the pagination worked it would be 5 pages with three records each - however each of the 5 pages generated show the same 3 records as it doesn't show records 4-15

This code:
$NUMPAGES = ceil($QNUM / $DISPPAGE);
derives it's total from $QNUM (total number of records) divided by $DISPPAGE (how many records per page) to show $NUMPAGES (how many pages we will end up with for pagination)

I hope that makes better sense now?

I'm still not sure where at I messed up in the code because it works - but just not the way it's supposed to.

😕