cannot create database tables

[Dillenger]

Hi,

I'm trying to create database tables dynamically from a file, but nothing happens when I press submit. Could someone tell me how to insert the tables?

Here is my code:

if ($REQUEST_METHOD=="POST") {
	  	mkdir("admin", 0775);
		chmod ("admin", 0777);
  		mkdir("images", 0775);
		chmod ("images", 0777);


  	$configuration = "<?\n\n";
  	$configuration = $configuration . "\$host = \"$newhost\";\n";
  	$configuration = $configuration . "\$usr = \"$newuser\";\n";
  	$configuration = $configuration . "\$passwd = \"$newpassword\";\n";
  	$configuration = $configuration . "\$db = \"$newdatabase\";\n\n";
  	$configuration = $configuration . "?>";

	$file = @fopen("admin/config.inc","w");
	@fwrite($file, "$configuration");
	fclose($file);



///////////////////////////////////////////////////////////////////////////////////////////////////
//////////////////////////      CREATE DATABASE TABLES    /////////////////////////////////////////
///////////////////////////////////////////////////////////////////////////////////////////////////		

	require('admin/config.inc');
	$cid = mysql_connect($host,$usr,$passwd);
	$select_db = mysql_select_db($db);


	$sql = 'CREATE TABLE `x_gallery` ( `id` INT( 10 ) NOT NULL AUTO_INCREMENT ,';
	$sql .= ' `dir` VARCHAR( 100 ) NOT NULL ,';
	$sql .= ' `dir_url` VARCHAR( 100 ) NOT NULL ,';
	$sql .= ' `dir_img` VARCHAR( 100 ) NOT NULL ,';
	$sql .= ' PRIMARY KEY ( `id` ) );';
	$sql .= ''; 

[Damien_Buttler]

You haven't actually ran the query. Try the following line at the end of your code.

mysql_query($sql);

[tbach2]

hookay... timtowtdi

I've never tried to build a page this way; I think it's a lot easier to use ftp... A few questions for you:

1. assuming that the if($REQUEST_METHOD=="POST") has a closing bracket, do you know that this branch is actually taken?

2. this really bugs me... why are you creating admin and images and making them world-readable?

3. why are you creating a config file? if your script is asking for the connection variables then just use them! otherwise, just type it out, save it as config.inc (not a good idea, should end in .php unless you want everybody to be able to read it) and ftp it over.

4. is that a backtick in the $sql string? Not good...