sql insert.. Found the prob but how do i fix?

pinehead18

ok check this out..

 $sql = "INSERT INTO users (uname) VALUES (\"$uname\")";

$uname works.. however i am echoing the $sql statement when the script is executed.

When the script is executed it just adds another line to the db and doesn't insert anything.. Here is why..

this is the echo out put

INSERT INTO users (uname) VALUES (". . ")adf

notice how the adf is outside of the ("") well it needs to be on the inside, yet i can't figure out how to get it in there.

Any ideas?
Thanks
Anthony

TheIceman5

$sql = "INSERT INTO users (uname) VALUES ('".$uname."')";

depends where u get the $uname variable from??

Frederick

Originally posted by TheIceman5
$sql = "INSERT INTO users (uname) VALUES ('".$uname."')";

You can't use ".$uname." in your query. Can cause conflicts.

$sql = mysql_query("INSERT INTO users (uname) VALUES ('$uname')");

TheIceman5

why? how? ive never had any problems with it. i have done a website up over 18 months ago using that method and the database is over 30 meg now and not a single problem.
But i do now however use classes for DB stuff and queries, no more of this amateur query stuff.

superwormy

Post the rest of your code... you're doing something wrong if an echo statement is outputting periods that are used to concatanate two strings...

Ravenous

I'm with Frederick. 🙂

TheIceman5

well im against you all, use a database class instead.

superwormy

uname is not a reserved word in ANY database that I can find ( mysql, postgresql, mssql, sysbase, etc. ) OR in the SQL standards.

uname is NOT the issue here. You need to post your code so we can find an answer to this, using a database class is not the solution either, he's doing something else wrong.

pinehead18

  $db = mysql_select_db("pinehead", $con) or die(mysql_error());
        $sql = "INSERT INTO users (uname) VALUES ('$uname')";
        $sth = mysql_query($sql) or die(mysql_error());
        echo $sql;

if(!$sth) {
echo mysql_error();
}

This is all the code.

Thank you all for your help

superwormy

I'm going to assume therse more than that, since you havn't yet established a connection to the database...

What is $uname equal to? Where is it set?

pinehead18

yes i just didn't copy that connection.
$uname is set on the page before..
But when i echo $uname it gives me the var is et in the form so i know it is set.

I also echo the sql statement and it accuratly posts what $uname is set to.

pinehead18

Could it be the way my feilds are layed out? Does anybody have any working code with this we might be able to compare it too.

I have created several insert statements in the past and have not encounterd a problem like this. However, this is the first time I have done it in about a year.

THanks again for all of your help and ideas.

Anthony