connecting to mysql database

Pnop

This should connect I think but doesn't? Total newb so any help appreciated.

//ADMIN CHECK
function admincheck() {
include("conextion.php");

//connect to database server
$dataconx = @mysql_connect($dbHost, $dbUser, $dbPass);
if (!$dataconx) {
die( 'Unable to connect to the database server at this time.' );
}
//connect to the database
if (! @mysql_select_db("$dbDatabase",$dataconx) ) {
die( 'Unable to locate the database at this time.' );
}

$result = mysql("$dbDatabase","SELECT * FROM teams WHERE username = 'admin'");
    $i = 0;
$total_rows = mysql_numrows($result);
if($total_rows != 1) {
        echo "<p align=center class=\"header\">Welcome to League.<br>For security you need to create an
		Administrator for your league. <a href=\"index.php?opt=createadmin\">
                Do that now</a>.</p>";
	$check = "false";
                    $sql = "INSERT INTO leagueinfo VALUES ('NULL','','',";
                    $sql .= "'','','',";
                    $sql .= "'','0','10')";
                    $done = mysql_query($sql);
} else home();

}

Frederick

$DBserver = "localhost";
$DBuser = "username";
$DBpass = "password";
$DBname = "dbname";

$dblink = mysql_connect($DBserver,$DBuser,$DBpass)
or die(mysql_error());
mysql_select_db($dblink,$DBname)
or die(mysql_error());

Pnop

Originally posted by Frederick

$DBserver = "localhost";
$DBuser = "username";
$DBpass = "password";
$DBname = "dbname";

$dblink = mysql_connect($DBserver,$DBuser,$DBpass)
or die(mysql_error());
mysql_select_db($dblink,$DBname)
or die(mysql_error());

[/B]

yes can do like this, but I wanted to connect from a seperate connection information page! i.e. the database information is on a different page hence the include function?

Frederick

Make a page called
_database.php

$DBserver = "localhost"; 
$DBuser = "username"; 
$DBpass = "password"; 
$DBname = "dbname"; 

$dblink = mysql_connect($DBserver,$DBuser,$DBpass) 
or die(mysql_error()); 
mysql_select_db($dblink,$DBname) 
or die(mysql_error());

Call another page for an example:
users.php

include("_database.php");

$sql = mysql_query("SELECT * FROM users ORDER BY lastName,firstName",$dblink)
or die(mysql_error());
while ($u = mysql_fetch_array($sql)) {
    echo "".$u["lastName"].", ".$u["firstName"]."<br>";
}

Pnop

wow!

I think that's a bit further ahead than I need to be at the moment?

Just playing around with learning php and playing with various code.

The one I posted originally I can't get to work for some reason and would like to get that to work so I have a better understanding of how things work.

But thanks appreciate the help.

Frederick

OK, give me the names of your table and table fields.
Also, tell me what goal of the page is suppose to perform.

I can write a simple page that you can see. From the style of your code, it looks like you in the correct area of the coding, but a little confused on a few things.

Pnop

This is the whole page: The only problem is connecting to the actual database

<?php


//LOAD THE HEADER
$filename = "includes/header.inc";
$fd = fopen ($filename, "r");
$contents = fread ($fd, filesize ($filename));
fclose ($fd);


$menu = ("	
	<a href='index.php'>Home</a> |
	<a href='index.php?opt=schedule'>Scores and Schedules</a> |
	<a href='index.php?opt=login'>Login</a>\n\r
	");


$contents = ereg_replace("<!--%CC_MENU%-->",$menu,$contents);
echo $contents;

switch($opt) {

    //SQL ADMINISTRATOR FUNCTION
    case "ahomecomplete":

    include("announcement.php");
    echo ahomecomplete();

    break;


    //VIEW SCHEDULE AND SCORES
    case "schedule":

include("standings.php");
if(!$divname) $divname = "none";
listteams($divname);

break;

//LOGIN FORM
case "login":

include("login.php");
login();

break;


    //LOGIN CHECK
    case "admincheck":

    include("logincheck.php");
    logincheck($fusername,$fpassword);

    break;

    //CREATE AN ADMINISTRATOR
    case "createadmin":

    include("createadmin.php");
    createadmin();

    break;

    //SQL ADMINISTRATOR FUNCTION
    case "createadmin2":

    include("createadmin.php");
    createadmin2($adminpassword);

    break;

//HOME
default:
admincheck(); 

}

//ADMIN CHECK
function admincheck() {
	include("conextion.php"); 

//connect to database server 
$dataconx = @mysql_connect($dbHost, $dbUser, $dbPass, $dbDatabase);
if (!$dataconx) {
	die( '<P>Unable to connect to the database server at this time.</P>' );
	}
//connect to the database 
	if (! @mysql_select_db("$dbDatabase",$dataconx) ) {
	die( '<P>Unable to locate the database at this time.</P>' );
	}

$result = mysql("$dbDatabase","SELECT * FROM teams WHERE username = 'admin'");
    $i = 0;
$total_rows = mysql_numrows($result);
if($total_rows != 1) {
        echo "<p align=center class=\"header\">Welcome to League.<br>For security you need to create an
		Administrator for your league. <a href=\"index.php?opt=createadmin\">
                Do that now</a>.</p>";
	$check = "false";
                    $sql = "INSERT INTO leagueinfo VALUES ('NULL','','',";
                    $sql .= "'','','',";
                    $sql .= "'','0','10')";
                    $done = mysql_query($sql);
} else home();


}

//MANAGE LEAGUE
function home() {

    include 'conextion.php';

    //connect to database server 
$dataconx = @mysql_connect($dbHost, $dbUser, $dbPass, $dbDatabase);
if (!$dataconx) {
	die( '<P>Unable to connect to the database server at this time.</>' );
	}
//connect to the database 
	if (!@mysql_select_db('$dbDatabase') ) {
	die( '<P>Unable to locate the database at this time.</P>' );
	}
        $result = mysql("$dbDatabase","SELECT * FROM leagueinfo");
	$rcount = mysql_numrows($result);
	$i = 0;

    if($rcount != 0) {
            $league_name = mysql_result($result,$i,"name");
            $description = mysql_result($result,$i,"description");
            $contact_name = mysql_result($result,$i,"contact_name");
            $phone = mysql_result($result,$i,"contact_phone");
            $email = mysql_result($result,$i,"contact_email");
            $address = mysql_result($result,$i,"contact_address");
    } else {
	$league_name = "";
	$description = "";
	$contact_name = "";
	$phone = "";
	$email = "";
	$address = "";
}


    //LEAGUE ANNOUNCEMENTS
    $announcements = "
            <table border=0 cellpadding=0 cellspacing=0 width=\"100%\" align=left>
            <tr><td bgcolor=\"#dfdfdf\">
            <table border=0 cellpadding=5 cellspacing=1 width=\"100%\">
            <tr><td bgcolor=\"#ffffff\" class=body_text>
	<center><b>Announcements</b></center><br>";

include("announcement.php");
$announcements.= ahomelist();

    if($email == "") {
            $announcements.= "<br><center><b>Request a League User ID:</b></center><br>No contact email
            has been entered by this league's administrator.";
    } else {
            $announcements.=  "<br><center><b>Request a League User ID</b></center><br>
	To request a League user ID<br> Email <a href=\"mailto:$email\">$contact_name</a>";
    }

    $announcements.= "
            </td></tr></table>
            </td></tr></table>";



echo "<table border=0 width=750 align=center cellpadding=10><tr><td colspan=2><br>";

//LEAGUE TITLE
echo "<p class=\"header\" align=center>Welcome to ";
if($league_name == "") {
	echo "v.1.0</p>";
} else echo "$league_name</p>";


echo "</td></tr>";
echo "<td width=200 valign=top>$announcements</td><td width=550 valign=top>";


//LEAGUE DESCRIPTION
    echo "<p class=\"body_text\">";
    if($description == "") {
            echo "No description has been entered by this league's
	administrator.</p>";
    } else {
	$description = ereg_replace("\n","<br>",$description);
	echo $description."</p>";
}

//OTHER LEAGUE INFORMATION
    echo "<p class=\"body_text\">";
    if($contact_name == "") {
            echo "No contact information has been entered by this league's
            administrator.</p>";
    } else {
            echo "<span class=header>League Contact:</span> $contact_name</p>";
    }

    if($phone != "") {
            echo "<p class=\"body_text\"><span class=header>Phone:</span> $phone</p>";
}

    if($address != "") {
	$address = ereg_replace("\n","<br>",$address);
            echo "<p class=\"body_text\"><span class=header>Address:</span><br>$address</p>";
    }

echo "</td></tr></table>";


}

include("includes/footer.inc");
?>

The table is teams
id int(4) UNSIGNED ZEROFILL No auto_increment Change Drop Primary Index Unique Fulltext

name varchar(50) No Change Drop Primary Index Unique Fulltext

contact_name varchar(70) No Change Drop Primary Index Unique Fulltext

contact_email varchar(70) No Change Drop Primary Index Unique Fulltext

contact_phone varchar(15) No Change Drop Primary Index Unique Fulltext

division varchar(50) No Change Drop Primary Index Unique Fulltext

username varchar(50) No Change Drop Primary Index Unique Fulltext

password varchar(50) No Change Drop Primary Index Unique Fulltext

loggedin int(1) No 0 Change Drop Primary Index Unique Fulltext

logtime varchar(50)

Frederick

I can see a couple areas:

1. $result = mysql("$dbDatabase","SELECT * FROM teams WHERE username = 'admin'");

should be

$result = mysql_query("SELECT * FROM teams WHERE username = 'admin'")
or die(mysql_error());

2. place your include() for datebase connection page at the very top so it can be global. It does not need to be inside of your functions.
Remove the database connection code from this page so there are no duplicating the code.

//connect to database server
$dataconx = @mysql_connect($dbHost, $dbUser, $dbPass, $dbDatabase);
if (!$dataconx) {
die( 'Unable to connect to the database server at this time.' );
}
//connect to the database
if (! @mysql_select_db("$dbDatabase",$dataconx) ) {
die( 'Unable to locate the database at this time.' );
}

3. Instead of using:
$total_rows = mysql_numrows($result);
after your query, use:

$result = mysql_query("SELECT * FROM teams WHERE username = 'admin'")
or die(mysql_error());

if (mysql_numrows($result)) {
    echo "<p align=center class=\"header\">Welcome to League.<br>For security you need to create an 
            Administrator for your league. <a href=\"index.php?opt=createadmin\"> 
                    Do that now</a>.</p>"; 
    $check = "false"; 
    $sql = mysql_query("INSERT INTO leagueinfo VALUES ('NULL','','','','','','','','','0','10')",$dblink)
    or die(mysql_error()); 
} else {
    home();
}

Pnop

Thanks I'll try that and let you know how I get on!

Pnop

Just to let you know.

It threw a parse error on line 206 which had nothing in it actually?

Need to locate the problem with the database connection?

It should connect on the information there but won't. Begining to think it may be a server problem! Shared hosting aswell!😕

Frederick

you may get a parse error on Line 206, but the problem could be on Line 205 or before, you know what I mean. Most likely missing a ;