Help With Pages Script Please!!

jonno946

Hi there, i am hoping somebody can help me...

I am trying to expand the following pages script.

At the moment, it displays 10 results per page, and lists all of the page numbers at the bottom

However,i wish to expand it to make it so it only shows 10 pages at the bottom of the page, for the main reason that if i have (for example), 900 records, it would display 90 numbers at the base of the page (which i dont want!!).

This forum uses the same concept.

Instead, i want to list the 5 pages before, and 5 pages after the origional page. For example... if i am page 50, it would display page numbers:

45 46 47 49 49 (50) 51 52 53 54 55

Anyway here is my existing code:

===========

<?php

// Log into MySQL database
$db = mysql_connect("localhost", "xxxx", "xxxx") or die ("Could not connect");
mysql_select_db("xxxx") or die ("Could not select db");

if($page == "") {
$page = "1";
}

$limit = 10;

$sqlcount= "SELECT * FROM messages WHERE to = '$username' ORDER BY id";

$sql_countresult = mysql_query($sqlcount, $db) or die ("Couldn't execute query");
$totalrows = mysql_num_rows($sql_countresult);

if(empty($page)){
$page = 5;
}

$limitvalue1 = $page$limit-($limit);
$sql = "SELECT FROM messages WHERE to = '$username' ORDER BY id desc LIMIT $limitvalue1, $limit";
$sql_result = mysql_query($sql, $db) or die ("Couldn't execute query");

while ($row = mysql_fetch_array($sql_result)){
echo "From: $row[from] ";
echo "To: $row[to] ";
echo "Subject: $row[subject] ";
echo "Message: $row[message] ";
}
echo " ";
if($pageprev = $page - 1) {
echo " <A HREF=\"$PHP_SELF?username=$username&page=$pageprev\"><</A>"; // if page is not equal to one, prev goes to $page - 1
}

$numofpages = $totalrows/$limit;

for($i= 1; $i < $numofpages+1; $i++) {
echo " <A HREF=\"$PHP_SELF?username=$username&page=$i\">$i</A>"; //make number navigation
}

if(($totalrows-($limit$page)) > 0){
$pagenext = $page + 1;
echo " <A HREF=\"$PHP_SELF?username=$username&page=$pagenext\">></A>"; // if the totalrows - $limit $page is > 0 (meaning there is a remainder), leave the next button.
}

mysql_free_result($sql_result);
mysql_close($db);

================

I beleive its something to do with this line but im not sure:

$numofpages = $totalrows/$limit;

Any help would be great, as i have been trying for the past 2 days solid!!!

Thanks in advance....

Jonathan

g00bster

Originally posted by jonno946
...
if($page == "") {
$page = "1";
}
...
if(empty($page)){
$page = 5;
}

From just a quick look through your code I think your problem is with those 2 segments there. I believe the second value you are trying to set is the number of sets of results to have at the bottom? Try changing your variable name for that. And use consistency when programming. For instance, for both code segments use

if(empty($varName))
{ ... }

if(!$varName)
{ ... }

After looking at your code in more depth, the line

$numofpages = $totalrows/$limit

gives you how many pages you would need to encompass all data retrieved from the table. This is a useful variable, but it is not the one you want to use. Set a $maxNumPages variable to restrict how many page links to display at the bottom. If $numofpages exceeds this, do more work to determine how many back and how many forward to display (ie, if you were at page 3, you would display 1-2-3-4-5-6-7-8-9-10 and if you were at 5 you would display 1-2-3-4-5-6-7-8-9-10 also). If $numofpages is less than $maxNumPages, then you simply display the set of all pages.

Hope that wasn't too confusing. Post a reply if you need more help.

I hesitate posting a coded solution to your problem because the best way to learn PHP is to code it yourself, albeit sometimes with a little help. 😉

jonno946

ok i'll check it out🙂 i'll get back if i need more help lol

jonno946

hey, ive been playing around with this some more this morning, all i have is:

$MaxNumPages = 10;
$numofpages = $totalrows/$limit;

for($i= 1; $i < $MaxNumPages+1; $i++) {
if ($page == $i) {
echo " [$i]"; //make number navigation
} else {
echo " <A HREF=\"$PHP_SELF?&page=$i\">$i</A>"; //make number navigation
}
}

This displays the first 10 pages, but when i go to say page 15, the page cound just stays at 1 - 10 🙁

I know its something to do with the for loop, but i must say my knowlege of pho is so basic, i dont really understand the for loop!! I mean, what does the $i++ mean?

Any help with that for loop would be great,

Thanks

Jonathan

jonno946

a bit of an update, just kinda got this thing to work lol

for($i= $page-4; $i < $page+4; $i++) {

That seems to do exactly what i want it to do, except what im on page one, it displays -4 -3 -2 -1 [1] 2 3 4 5, and when all of the results arew finnished, it keeps diaplaying numbers!!

I'm going to work on it but any ideas would be helpful 🙂

jonno946

well, ive managed to do it, the codes a bit dirty, but it works and i suppose it can be accepted for a newbie😉

If anyone has any advise how to clean it up let me know :o)

Cheers,

Jonathan

$numofpages = $totalrows/$limit;

for($i= $page-4; $i < $page+5; $i++) {

if($i > $numofpages+1) {
break;
}

if($i < 1) {
print "";
} else {

if ($page == $i) {
echo " [$i]"; //make number navigation
} else {
echo " <A HREF=\"$PHP_SELF?page=$i\">$i</A>"; //make number navigation
}
}
}