Function help

Hexx

Ok,
So Im trying to create some error code stuff for a survey form. When checking to see if the fields are filled (drop down menus that is.) what would be the best way to check to see if something is selected?

Right now I have something like this:

if(!isset($field1)) {
//show error stating field 1 is not filled out 
}

if(!isset($field2)) {
//show error stating field 2 is not filled out
}

Is there a way to create a function for this? Or is there one are already avaliable in PHP?

Any easier way to do this (besides grabbing a pre-made form script)?

HalfaBee

You will have to go thru every $POST/$GET value and check each one.
There is nothing in PHP for this job yet.

HalfaBee

Hexx

ok....

is there anyway of creating a function in php code for this??? I have been thinking for the past 20ish minutes and unable to come up with anything.

HalfaBee

You could use a foreach() loop to go thru all the $_POST values.

HalfaBee

feldon23

Except that that would require ALL fields, even fields that you want optional.

Some untested code:

$required_fields = array('name', 'email', 'address1');

function isformfilled($formdata, $required_fields) {
  $result = TRUE;
  foreach ($formdata as $key => $value) {
    if (in_array($key, $required_fields) && ($value == '')) {
      echo "You did not enter a value for {$key}.<br>\n";
      $result = FALSE;
    }
  }
  if ($result == FALSE) {
    return FALSE;
  }
}

if (isformfilled($_POST, $required_fields) == FALSE) {
  // Do some action since the form was not filled.
}

HalfaBee

This could be the thread for the definitive answer to form field checking. 🙂

I just made a few mods so it returned the error fields.

HalfaBee

function isformfilled($formdata, $required_fields) {

$result = TRUE;
  foreach ($formdata as $key => $value) {
    if (in_array($key, $required_fields) && ($value == '')) {
      echo "You did not enter a value for {$key}.<br>\n";

  $result[] = $key;
}
  }

 return $result;
}

if( isformfilled !== TRUE )
{
    echo " Fill it out properly please.";
}

Hexx

wow.....

why didnt i think of this before...hehe....nice....thanx HalfaBee.

Hexx

argh....for some reason it does not return the part that says:

echo "You did not enter a value for {$key}.<br>\n";

And simply goes to:

echo " Fill it out properly please.";

I have been playing with it for a lil while now....hmmmm.

feldon23

To debug it, above the echo "You did not enter...", add

echo "|$value|";

HalfaBee

You might want to put the above debug line before the if().

HalfaBee

Hexx

I think i found the conflict....

where it says:

if( isformfilled !== TRUE )

doesnt it have to be something like

if( isformfilled($formdata, $required_fields !==TRUE )

but now how the heck do i call each value field into $formdata. I have tried $HTTP_POST_ whatever whatever...no go. I have tried debugging stuff but it doesnt echo the error messages. This is getting frustrating.

feldon23

No offense to Halfabee but what was posted is broken.

Use it the way I indicated.

$required_fields = array('name', 'email', 'address1'); 

function isformfilled($formdata, $required_fields) { 
  $result = TRUE; 
  foreach ($formdata as $key => $value) { 
    if (in_array($key, $required_fields) && ($value == '')) { 
      echo "You did not enter a value for {$key}.<br>\n"; 
      $result = FALSE; 
    } 
  } 
  if ($result == FALSE) { 
    return FALSE; 
  } 
} 

if (isformfilled($_POST, $required_fields) == FALSE) { 
  // Do some action since the form was not filled. 
}

You'll notice that I am passing $_POST which is the entire $HTTP_POST_VARS array, which contains all the values that came in from the form. The foreach() function walks through the $POST array.

Hexx

yea i noticed the code didnt work....and i kinda put both sets of code together for my script. I also found out that part of my original code (not in relation to this piece of code).

Hexx

BINGO! Got it to work, except for the fact that it gives me the following error when I try to do:

if (in_array($key, $required_fields) && ($value == '00')) {

and the error:

"Warning: Cannot use a scalar value as an array in <directory path> on line 16"

Now the reason why I put $value =='00' is because I dont want to compare all the fields that equal ''. so I am using 00. How can I get around this??