[Resolved] help with loop needed

helz

like in my other post:
http://www.phpbuilder.com/board/showthread.php?threadid=10248607

i was helped by cgraz with the error i got. now what i want to do is using a loop, create a link for each data entry into the sql made that links back to the same page but specifies an id to be edited.
as a result of this i need the function's to be dynamic being wrote as:
function $id() {

here is the error that i got:
Parse error: parse error, expecting `T_STRING' in /home/user3/public_html/dir2/dir11/edit2sql.php on line 38

and here is the code:

<?
require ("../../cgi-bin/connect2test.php");

# processed when form is submitted back onto itself
if ($REQUEST_METHOD=="POST") {

    # setup SQL statement
    $SQL = " UPDATE sqlxml SET";
    $SQL = $SQL . " name = '$name', ";
    $SQL = $SQL . " description = '$description' ";
    $SQL = $SQL . " WHERE id = '$id' ";

    # execute SQL statement
    $result = mysql_db_query($db,"$SQL",$cid);

    # check for errors
    if (!$result) { echo("ERROR: " . mysql_error() . "\n$SQL\n");    }

    echo ("<P><B>Data Entry Updated</B></P>\n");

} else { # display edit form (not post method)

    # setup SQL statement to retrieve link that we want to edit
    $SQL = " SELECT * FROM sqlxml ";
    $SQL = $SQL . " WHERE id = '$id' ";

    # execute SQL statement
    $ret = mysql_db_query($db,"$SQL",$cid) or die(mysql_error());
	$row = mysql_fetch_array($ret);
    $name = $row["name"];
	$id = $row["id"];
    $description = $row["description"];
echo    "Please chooae a data entry to edit:<br>";
# create url link for each data entry
while ($row = mysql_fetch_array($ret)) {
       echo "<a href='$PHP_SELF&id=$id'>Edit Data Entry id: $id. With the Name: $name</a>";

# LINE BELOW THIS = LINE 38	   
			function $id() {
			# form here
			print 	"<FORM NAME='edit2sql' ACTION='edit2sql.php' METHOD='POST'>
					<INPUT TYPE='hidden' NAME='id' VALUE='$id'><TABLE>
					<TR><TD><B>Name:</B> </TD><TD><INPUT TYPE='text' NAME='name' VALUE='$name' SIZE=40></TD></TR>
					<TR><TD VALIGN=TOP><B>Description: </B> </TD><TD> <TEXTAREA NAME='description' ROWS=5 COLS=40>$description</TEXTAREA></TD></TR>
					<TR><TH COLSPAN=2><P><INPUT TYPE='submit' VALUE='Update Data'></P></TH></TR>
					</TABLE></FORM>";

		}
  }

}

mysql_close($cid);
# loop multiple switches for functions
switch($_REQUEST['id']){ 
	while ($row = mysql_fetch_array($ret)) {

	case "$id": 
	$id(); 
	break;  
}
} 

?>

kevinsequeira

you dont need to define the function in a while loop, rather define it outside at the top of the page

            function id($id) {
            # form here
            print     "<FORM NAME='edit2sql' ACTION='edit2sql.php' METHOD='POST'>
                    <INPUT TYPE='hidden' NAME='id' VALUE='$id'><TABLE>
                    <TR><TD><B>Name:</B> </TD><TD><INPUT TYPE='text' NAME='name' VALUE='$name' SIZE=40></TD></TR>
                    <TR><TD VALIGN=TOP><B>Description: </B> </TD><TD> <TEXTAREA NAME='description' ROWS=5 COLS=40>$description</TEXTAREA></TD></TR>
                    <TR><TH COLSPAN=2><P><INPUT TYPE='submit' VALUE='Update Data'></P></TH></TR>
                    </TABLE></FORM>";

        }
.
.
.
while ($row = mysql_fetch_array($ret)) {
       echo "<a href='$PHP_SELF&id=$id'>Edit Data Entry id: $id. With the Name: $name</a>";
//calling the function
  id($id);
      } 
mysql_close($cid);
/*
# loop multiple switches for functions
switch($_REQUEST['id']){ 
    while ($row = mysql_fetch_array($ret)) {

    case "$id": 
    $id(); 
    break;  
}
}  */

helz

thank you greatly for getting rid of me that error but now. it displays the form within the function when it has not been called.
and the url's are not displayed.

[url here is the link to the site]http://www.hellrazer.net/sttg/1/edit2sql.php[/url[

and here is a refresh of the current code:

<?
require ("../../cgi-bin/connect2test.php");

function id($id) {
# form here
echo 	"<FORM NAME='edit2sql' ACTION='edit2sql.php' METHOD='POST'>
		<INPUT TYPE='hidden' NAME='id' VALUE='$id'><TABLE>
		<TR><TD><B>Name:</B> </TD><TD><INPUT TYPE='text' NAME='name' VALUE='$name' SIZE=40></TD></TR>
		<TR><TD VALIGN=TOP><B>Description: </B> </TD><TD> <TEXTAREA NAME='description' ROWS=5 COLS=40>$description</TEXTAREA></TD></TR>
		<TR><TH COLSPAN=2><P><INPUT TYPE='submit' VALUE='Update Data'></P></TH></TR>
		</TABLE></FORM>";
}


# processed when form is submitted back onto itself
if ($REQUEST_METHOD=="POST") {

    # setup SQL statement
    $SQL = " UPDATE sqlxml SET";
    $SQL = $SQL . " name = '$name', ";
    $SQL = $SQL . " description = '$description' ";
    $SQL = $SQL . " WHERE id = '$id' ";

    # execute SQL statement
    $result = mysql_db_query($db,"$SQL",$cid);

    # check for errors
    if (!$result) { echo("ERROR: " . mysql_error() . "\n$SQL\n");    }

    echo ("<P><B>Data Entry Updated</B></P>\n");

} else { # display edit form (not post method)

    # setup SQL statement to retrieve link
    # that we want to edit
    $SQL = " SELECT * FROM sqlxml ";
    $SQL = $SQL . " WHERE id = '$id' ";

    # execute SQL statement
    $ret = mysql_db_query($db,"$SQL",$cid) or die(mysql_error());
	$row = mysql_fetch_array($ret);
    $name = $row["name"];
	$id = $row["id"];
    $description = $row["description"];
echo    "Please choose a data entry to edit:<br>";
while ($row = mysql_fetch_array($ret)) {
       echo "<a href='$PHP_SELF&id=$id'>Edit Data Entry id: $id. With the Name: $name</a>";
	  }
}
//calling the function 
  id($id); 


mysql_close($cid);

?>

thanks again for any help offered

kevinsequeira

try this

while ($row = mysql_fetch_array($ret)) {
       echo "<a href='$PHP_SELF&id=$id'>Edit Data Entry id: $id. With the Name: $name</a>";

  }
}

//calling the function
if($id){
  id($id);  

}

reg
kevin

helz

well that got rid of the form. but still no url. im just wondering what the expression in the while statement could be changed to, to be more productive.

thanks again

kevinsequeira

.
.
.

     # execute SQL statement
    $ret = mysql_db_query($db,"$SQL",$cid) or die(mysql_error());
/*        $row = mysql_fetch_array($ret);
        $name = $row["name"];
        $id = $row["id"];
        $description = $row["description"];
*/
echo    "Please choose a data entry to edit:<br>";
while ($row = mysql_fetch_array($ret)) {
        $name = $row["name"];
        $id = $row["id"];
        $description = $row["description"];
       echo "<a href='$PHP_SELF&id=$id'>Edit Data Entry id: $id. With the Name: $name</a>";
      }
}

helz

becoming a pain in the you-[a]-know--what-

im sorry to be a nuisance but it still has not fixed the error. 🙂

http://www.hellrazer.net/sttg/1/edit2sql.php

sorry

kevinsequeira

well i was just trying to solve the syntax errors, without paying much attention to the logic !!
are you trying to display all the records in your table and then through a link , go to a particular record and then update it ??

reg
kevin

helz

yes. all the records need to displayed in a url that points back to the script to show the data in the text box/text area and then be edited back into the table.

kevinsequeira

<?
require ("../../cgi-bin/connect2test.php");
function id($id,$name,$description) {
# form here
?>
<FORM NAME="edit2sql" ACTION="<?php echo $PHP_SELF;?>" METHOD="POST">
<INPUT TYPE="hidden" NAME="id" VALUE="<?php echo $id; ?>">
<TABLE>
<TR>
	<TD><B>Name:</B></TD>
	<TD><INPUT TYPE="text" NAME="name" VALUE="<?php echo $name;?>" SIZE=40></TD>
</TR>
<TR>
	<TD VALIGN=TOP><B>Description: </B></TD>
	<TD><TEXTAREA NAME="description" ROWS=5 COLS=40><?php echo $description;?></TEXTAREA></TD>
</TR>
<TR>
	<TH COLSPAN=2><P><INPUT TYPE="submit" VALUE="Update Data"></P></TH>
</TR>
</TABLE>
</FORM>
<?php
}
# processed when form is submitted back onto itself
if ($REQUEST_METHOD=="POST") {
  # setup SQL statement
  $SQL = " UPDATE sqlxml SET";
  $SQL = $SQL . " name = '".$name."', ";
  $SQL = $SQL . " description = '".$description."' ";
  $SQL = $SQL . " WHERE id = '".$id."' ";

  # execute SQL statement
  $result = mysql_db_query($db,$SQL,$cid);

  # check for errors
  if (mysql_error()) {
   echo("ERROR: " . mysql_error() . "\n$SQL\n");
  }else{
  	echo ("<P><B>Data Entry Updated</B></P>\n");
  }
}elseif($REQUEST_METHOD=="GET"){
  # display edit form (not post method)
  # setup SQL statement to retrieve link that we want to edit
  $SQL = " SELECT * FROM sqlxml ";
  $SQL = $SQL . " WHERE id = '".$id."' ";
    $name = $row["name"];
    $id = $row["id"];
    $description = $row["description"];
		id($id,$name,$description);
}else{
  # display all records
  $SQL = " SELECT * FROM sqlxml ";
   # execute SQL statement
  $ret = mysql_db_query($db,$SQL,$cid) or die(mysql_error());
  echo    "Please choose a data entry to edit:<br>";
  # create url link for each data entry
  while ($row = mysql_fetch_array($ret)) {
    $name = $row["name"];
    $id = $row["id"];
    $description = $row["description"];
    echo "<a href=".$PHP_SELF."?id=".$id">Edit Data Entry id: ".$id." With the Name: ".$name"</a>";
  }
}

mysql_close($cid);
?>

any luck ? there may be syntax errors cause i havent tested it out
EDIT : i have made some changes to the code, the way the function id is defined and called, copy and paste the code again.
reg
kevin

helz

thanks. after a few missing " . " and a <br> tag the url's are shown correctly except now when you click on them the form does not show. is there anyway to make it so the form shows and not the links? once the person has gone to edit a specific link?

kevinsequeira

when i go to
http://www.hellrazer.net/sttg/1/edit2sql.php

i dont see any URL's ???

reg
kevin

helz

right apparantly there are errors or somthing with dns so you gotta access the page via ip to see the links heres the address:

http://207.44.240.97/~hell/sttg/1/edit2sql.php

kevinsequeira

can you post the latest code ? what version of php are you using ?

reg
kevin

helz

PHP version is: 4.3.2

latest code is:

<? 
require ("../../cgi-bin/connect2test.php"); 
function id($id,$name,$description) { 
# form here 
?> 
<FORM NAME="edit2sql" ACTION="<?php echo $PHP_SELF;?>" METHOD="POST"> 
<INPUT TYPE="hidden" NAME="id" VALUE="<?php echo $id; ?>"> 
<TABLE> 
<TR> 
    <TD><B>Name:</B></TD> 
    <TD><INPUT TYPE="text" NAME="name" VALUE="<?php echo $name;?>" SIZE=40></TD> 
</TR> 
<TR> 
    <TD VALIGN=TOP><B>Description: </B></TD> 
    <TD><TEXTAREA NAME="description" ROWS=5 COLS=40><?php echo $description;?></TEXTAREA></TD> 
</TR> 
<TR> 
    <TH COLSPAN=2><P><INPUT TYPE="submit" VALUE="Update Data"></P></TH> 
</TR> 
</TABLE> 
</FORM> 
<?php 
} 
# processed when form is submitted back onto itself 
if ($REQUEST_METHOD=="POST") { 
  # setup SQL statement 
  $SQL = " UPDATE sqlxml SET"; 
  $SQL = $SQL . " name = '".$name."', "; 
  $SQL = $SQL . " description = '".$description."' "; 
  $SQL = $SQL . " WHERE id = '".$id."' "; 

  # execute SQL statement 
  $result = mysql_db_query($db,$SQL,$cid); 

  # check for errors 
  if (mysql_error()) { 
   echo("ERROR: " . mysql_error() . "\n$SQL\n"); 
  }else{ 
      echo ("<P><B>Data Entry Updated</B></P>\n"); 
  } 
}elseif($REQUEST_METHOD=="GET"){ 
  # display edit form (not post method) 
  # setup SQL statement to retrieve link that we want to edit 
  $SQL = " SELECT * FROM sqlxml "; 
  $SQL = $SQL . " WHERE id = '".$id."' "; 
    $name = $row["name"]; 
    $id = $row["id"]; 
    $description = $row["description"]; 
        id($id,$name,$description); 
}else{ 
  # display all records 
  $SQL = " SELECT * FROM sqlxml "; 
   # execute SQL statement 
  $ret = mysql_db_query($db,$SQL,$cid) or die(mysql_error()); 
  echo    "Please choose a data entry to edit:<br>"; 
  # create url link for each data entry 
  while ($row = mysql_fetch_array($ret)) { 
    $name = $row["name"]; 
    $id = $row["id"]; 
    $description = $row["description"]; 
    echo "<a href=".$PHP_SELF."?id=".$id.">Edit Data Entry id: ".$id." With the Name: ".$name."</a><br>"; 
  } 
} 

mysql_close($cid); 
?>

kevinsequeira

<? 
require ("../../cgi-bin/connect2test.php"); 
function id($id,$name,$description) { 
# form here
?> 
<FORM NAME="edit2sql" ACTION="<?php echo $PHP_SELF;?>" METHOD="POST">
<INPUT TYPE="hidden" NAME="id" VALUE="<?php echo $id; ?>">
<TABLE>
<TR>
    <TD><B>Name:</B></TD>
    <TD><INPUT TYPE="text" NAME="name" VALUE="<?php echo $name;?>" SIZE=40></TD>
</TR>
<TR>
    <TD VALIGN=TOP><B>Description: </B></TD>
    <TD><TEXTAREA NAME="description" ROWS=5 COLS=40><?php echo $description;?></TEXTAREA></TD>
</TR>
<TR>
    <TH COLSPAN=2><P><INPUT TYPE="submit" VALUE="Update Data"></P></TH>
</TR>
</TABLE>
</FORM>
<?php 
} 
# processed when form is submitted back onto itself
if (isSet($_POST['id'])) { 
  # setup SQL statement
  $SQL = " UPDATE sqlxml SET"; 
  $SQL = $SQL . " name = '".$_POST['name']."', "; 
  $SQL = $SQL . " description = '".$_POST['description']."' "; 
  $SQL = $SQL . " WHERE id = '".$_POST['id']."' "; 

  # execute SQL statement
  $result = mysql_db_query($db,$SQL,$cid); 

  # check for errors
  if (mysql_error()) { 
   echo("ERROR: " . mysql_error() . "\n$SQL\n"); 
  }else{ 
      echo ("<P><B>Data Entry Updated</B></P>\n"); 
  } 
}elseif(isSet($_GET['id'])){ 
  # display edit form (not post method)
  # setup SQL statement to retrieve link that we want to edit
  $SQL = " SELECT * FROM sqlxml "; 
  $SQL = $SQL . " WHERE id = '".$_GET['id']."' "; 
# execute SQL statement
  $result = mysql_db_query($db,$SQL,$cid); 
$row = mysql_fetch_array($result);
  $name = $row["name"]; 
  $id = $row["id"]; 
  $description = $row["description"]; 
  id($id,$name,$description); 
}else{ 
  # display all records
  $SQL = " SELECT * FROM sqlxml "; 
   # execute SQL statement
  $ret = mysql_db_query($db,$SQL,$cid) or die(mysql_error()); 
  echo    "Please choose a data entry to edit:<br>"; 
  # create url link for each data entry
  while ($row = mysql_fetch_array($ret)) { 
    $name = $row["name"]; 
    $id = $row["id"]; 
    $description = $row["description"]; 
    echo "<a href=".$PHP_SELF."?id=".$id.">Edit Data Entry id: ".$id." With the Name: ".$name."</a><br>"; 
  } 
} 

mysql_close($cid); 
?>

reg
kevin

helz

Genius absolute genius.

thanks tramendously for that kev. unbelievable 😃 😃 😃 😃 😃

god-like, now onto a delete script