preg_replace problem URGENT!

Robbinz

Hey,

We at oure office have spotted a little problem.

we got an site management system for users that don't know any HTML or other languages

Now one of oure customers tried to link a website with a ? in the link and now oure replacer seems to make the link wrong..

the replacer is the following:

	$tekst 		= preg_replace("/\b((http(s?):\/\/)|(www\.))([\w\._-]+)([\/\w+\._-]+)\b/i","<a href=\"http$3://$4$5$6\" target=\"_blank\">$2$4$5$6</a>", $tekst);

The command the customer has to give is:
http(url,description) and the replacer will replace it with a <a href.. blabla>description</a>

THis works fine with links without a ? anyone who knows a way to fix this?

Kind Regards,

Robbin Diepeven

tbach2

I couldn't get this pattern to work-- is this exactly the way it is in the code?

Weedpacket

The forum software has a tendency to mangle regexps written in &#91php] tags (stripping out backslashes); &#91code] should be used instead.

Robbinz

Sorry didn't know the board did that.
here it's again in code tags 😉

$tekst 		= preg_replace("/\b((http(s?):\/\/)|(www\.))([\w\._-]+)([\/\w+\._-]+)\b/i","<a href=\"http$3://$4$5$6\" target=\"_blank\">$2$4$5$6</a>", $tekst);

tbach2

After looking at it, it dawned on me that they probably didn't want the ability to add variables into the url for security. That being said, all that had to be done was add a pattern to catch the ? and everything behind it.

$pattern = "/\b((http(s?):\/\/)|(www\.))([\w\._-]+)([\/\w+\._-]+\?.*)\b/i";

Use at your own risk...