Session functions not working::

[aa-true-vicious]

I'm using the following code::

<?
session_start();
if(!isset($VOID['id']))
{
if ($username && $password)
  {
  require("../dblogon.php");
  mysql_select_db("void", $connect);

  $passcode = md5($password);
  $query = mysql_query("SELECT * FROM users WHERE username='$username'");
  $r = mysql_fetch_array($query);
  $true = $r['password'];
  $id = $r['id'];
  if($true = $passcode)
    {
    $VOID['id'] = $id;
    session_register("VOID");
    echo 'Close this window to return to Void';
    }
  else
    {
    echo "Password/Username Combination Incorrect";
    }
  }
else
  {
  ?>

<b>Login</b><br>
<form action="login.php" method="post">
Username: <input name="username"><br>
Password: <input name="password" type="password"><br>
<input value="Submit" type="submit">
</form>

  <?
  }
}
else
{
echo "You are already logged in<br>Please log out";
}
?>

Can anyone see why the session cookies aren't made?

Sorry, I just changed the code to my current version

[Frederick]

place your

session_start();

before your

session_register("VOID");

session_start();
session_register("VOID");

[trooper]

Originally posted by Frederick
place your

session_start();

before your

session_register("VOID");


session_start();
session_register("VOID");

Frederick the session_start IS before the session_register

What version of php are you using ?

Do you get any error messages?

GM

[Frederick]

Oh wait, I just see 2 errors you have.

You are doing no checking here
if ($username && $password)

if you are checking to see if a person entered the information, is should be:
if (!empty($username) && !empty($password)) {

---

and when you do a comparison, you must have 2 ==

Currently:
if($true = $passcode)

Suppose to be:
if($true == $passcode)

---

Your session_start should always initiate when using a login system after verifiying that a person has entered the information and not at the very start of the page. You do not want a person to be retaining and information is they are not authorized.

Only time you want your session_start() to be in the very top is when you have HTML code mixed in your function.