What am I doing wrong in this query?

Roble

I'm trying to query the database, but it keeps 'dieing' on me. What am I doing wrong?

<?php include("cnct.php");

if(!$submit) {

?>

<html>
<font face="verdana" size="2">
<center>Welcome to your control panel, <b></html><?php echo $username ?><html></b>!</center>
<br>
Here is where you can edit your Final Fantasy XI stats for </html><?php echo $handle ?><html>. Remember, you <i>must</i> fill in all fields.
<br>
<br>
<form name="update_stats" method="post" action="configure_stats.php">
<table border="1" cellpadding="2" cellspacing="0" align="center" valign="top" width="500">
<tr>
<td colspan="3"><font face="verdana" size="2"><b><center>Final Fantasy XI clan stats</center></b></font></td>
</tr>
<tr>
<td colspan="2"><font face="verdana" size="2"><b>Information</b></font></td>
<td><font face="verdana" size="2"><b>Change to -></b></font></td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Handle:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $handle ?><html></font></td>
<td><input type="text" name="handle_update" length="30"></td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Main Job:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $main_job ?><html></font></td>
<td>
<SELECT NAME="main_job_update">
<OPTION VALUE="Warrior">Warrior</OPTION>
<OPTION VALUE="Black Mage">Black Mage</OPTION>
<OPTION VALUE="White Mage">White Mage</OPTION>
<OPTION VALUE="Red Mage">Red Mage</OPTION>
<OPTION VALUE="Monk">Monk</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Support Job:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $support_job ?><html></font></td>
<td>
<SELECT NAME="support_job_update">
<OPTION VALUE="Warrior">Warrior</OPTION>
<OPTION VALUE="Black Mage">Black Mage</OPTION>
<OPTION VALUE="White Mage">White Mage</OPTION>
<OPTION VALUE="Red Mage">Red Mage</OPTION>
<OPTION VALUE="Monk">Monk</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Advanced Job:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $advanced_job ?><html></font></td>
<td>
<SELECT NAME="advanced_job_update">
<OPTION VALUE="Dark Knight">Dark Knight</OPTION>
<OPTION VALUE="Paladin">Paladin</OPTION>
<OPTION VALUE="Beastmaster">Beastmaster</OPTION>
<OPTION VALUE="Ranger">Ranger</OPTION>
<OPTION VALUE="Ninja">Ninja</OPTION>
<OPTION VALUE="Samurai">Samurai</OPTION>
<OPTION VALUE="Summoner">Summoner</OPTION>
<OPTION VALUE="Dragoon">Dragoon</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Race:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $race ?><html></font></td>
<td>
<SELECT NAME="race_update">
<OPTION VALUE="Hume">Hume</OPTION>
<OPTION VALUE="Elvaan">Elvaan</OPTION>
<OPTION VALUE="Taru Taru">Taru Taru</OPTION>
<OPTION VALUE="Galka">Galka</OPTION>
<OPTION VALUE="Mithra">Mithra</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Kingdom:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $kingdom ?><html></font></td>
<td>
<SELECT NAME="kingdom_update">
<OPTION VALUE="Bastok">Bastok</OPTION>
<OPTION VALUE="Windust">Windurst</OPTION>
<OPTION VALUE="San DOria">San D'Oria</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Rank:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $rank ?><html></font></td>
<td><font face="verdana" size="2"><b>---</b></font></td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Level:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $level ?><html></font></td>
<td><input type="text" name="level_update" length="3"></td>
</tr>

<tr>
<td><font face="verdana" size="2"><b>E-mail:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $email ?><html></font></td>
<td><input type="text" name="email_update" length="30"></td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>AIM:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $AIM ?><html></font></td>
<td><input type="text" name="AIM_update" length="30"></td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Comments:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $comments ?><html></font></td>
<td><input type="text" name="comments_update" length="30"></td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Beta Tester:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $beta_tester ?><html></font></td>
<td>
<SELECT NAME="beta_tester_update">
<OPTION VALUE="Yes PC">Yes, PC version</OPTION>
<OPTION VALUE="Yes PS2">Yes, PS2 version</OPTION>
<OPTION VALUE="No">No</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td><font face="verdana" size="2"><b>Importer:</b></font></td>
<td><font face="verdana" size="2"></html><?php echo $importer ?><html></font></td>
<td>
<SELECT NAME="importer_update">
<OPTION VALUE="Yes">Yes</OPTION>
<OPTION VALUE="No">No</OPTION>
</SELECT>
</td>
</tr>
<tr>
<td colspan="3"><center><input type="submit" value="Submit" name="submit"></center></td>
</table>
</form>
</font>
</html>

<?php

$handle_update = $POST['handle_update'];
$support_job_update_update = $POST['main_job_update'];
$advanced_job_update = $POST['advanced_job_update'];
$race_update = $POST['race_update'];
$kingdom_update = $POST['kingdom_update'];
$email_update = $POST['email_update'];
$AIM_update = $POST['AIM_update'];
$comments_update = $POST['comments_update'];
$beta_tester_update = $POST['beta_tester_update'];
$importer_update = $POST['importer_update'];
$submit = $_POST['submit'];

}

else if($submit && !empty($handle_update) && !empty($level_update) && !empty($email_update) && !empty($AIM_update) && !empty($comments_update)) {

$insert = "UPDATE users SET handle='$handle_update', level='$level_update', main_job='$main_job_update', support_job='$support_job_update', advanced_job='$advanced_update', race='$race_update', kingdom='$kingdom_update', email='$email_update', AIM='$AIM_update', comments='$comments_update', beta_tester='$beta_tester_update', importer='$importer_update', WHERE id=$id";
$insert_res = @($insert) or die("No.");

}
else {

?><html>
<font face="verdana"><b>You didn't fill in all of the required information. Please <a href="configure_stats.php">go back</a> and do so.</b></font>
</html><?php
}

?>

bad76

Hi,

look this

http://www.phpbuilder.com/board/showthread.php?s=&threadid=10249515

and this

http://www.phpbuilder.com/board/showthread.php?s=&postid=10390788

Roble

Hmmm.... Those didnt really help me, but thanks anyways. I'm pretty sure the coding is wrong somewhere in here:

else if($submit && !empty($handle_update) && !empty($level_update) && !empty($email_update) && !empty(

$AIM_update) && !empty($comments_update)) {

$update=mysql_query("UPDATE users SET handle='$handle_update', level='$level_update', main_job='$main_job_update', support_job='$support_job_update', advanced_job='$advanced_update', race='$race_update', kingdom='$kingdom_update', email='$email_update', AIM='$AIM_update', comments='$comments_update', beta_tester='$beta_tester_update', importer='$importer_update' WHERE username = '$username'");

if (!$update)
{

echo("Information could not be updated for some odd reason!");

}

else

{

echo '<font face="verdana" size=2"></b>Update successful!</b> <a href="cp.php"><b>Click here</b></a> to go back to your control panel, and <a href="configure_stats.php"><b>Click here</b> to go back to the Stats Configuration page.</font>';
}

And I have already connected to the database in the include('cnct.php') at the top of my source code. Any tips?

bad76

🙁 you can know the "odd reason"
adding mysql_error() echo...

stolzyboy

change this line

$insert_res = @($insert) or die("No.");

to this

$insert_res = mysql_query($insert) or die(mysql_error());

Roble

Cool, thanks. Now I just get a "Query was empty" error. Does that have something to do with the drop-down menus? I'm stumped. Can someone help me please? Thanks for all the help so far.

Roble

I really need help with this please. Thanks.

Roble

Actually, I think this is a problem with the drop down menu's. It think's that they are empty or something? Get back to me plz.

stolzyboy

well, its just as it says, your query isn't returning anything

Roble

I understand that quite clearly. But why?

bad76

Originally posted by Roble
Cool, thanks. Now I just get a "Query was empty" error. Does that have something to do with the drop-down menus? I'm stumped. Can someone help me please? Thanks for all the help so far.

Sorry, but i haven't never see this mysql error, because is not error if any update return no result.

First, i think you can try this:

$insert_res = mysql_query($insert) or die(mysql_error().": ".$insert);

This will show after error the query you make. Look if all value are ok.

Second, may be there is no field to update => your db is empty or not exist any where id=$id. In this case put some dat in db or test with right id.

I hope this make a sense.

see you

stolzyboy

that is a fairly common error, it means that the query was fine, but it returned an empty record set, so therefore, you didn't have anything to run the query on

ahundiak

'$importer_update', WHERE id=$id";

The comma

Consider reviewing the manul on mysql_query(). This function will always return TRUE or a result set if the query can be executed. It only only returns false on errors. The number of rows affected does not change the value returned.

Roble

Still says query was empty.

stolzyboy

echo out your query and make sure all you var's are coming thru, so if i had this

$query = "select * from table where id = '$id';"; //echo this out like
echo $query;

that will then output something like

select * from table where id = 5;

so it ensures that your var's are getting into the update

Roble

Well, here is the updated version. It still doesn't work sadly.

<?php 
include("include.php"); 

if(!$submit) {

?>

<html>
<font face="verdana" size="2">
<center>Welcome to your control panel, <b></html><?php echo $username ?><html></b>!
<br>
Here is where you can edit your Final Fantasy XI stats for </html><?php echo $handle ?><html>. Remember, you <i>must</i> fill in all fields.</center>
<br>
<br>
<form name="update_stats" method="post" action="configure_stats.php">
<table border="1" cellpadding="2" cellspacing="0" align="center" valign="top" width="500">
<tr>
  <td colspan="3"><font face="verdana" size="2"><b><center>Final Fantasy XI clan stats</center></b></font></td>
  </tr>
<tr>
  <td colspan="2"><font face="verdana" size="2"><b>Information</b></font></td>
  <td><font face="verdana" size="2"><b>Change to -></b></font></td>
</tr>
  <tr>
    <td><font face="verdana" size="2"><b>Handle:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $handle ?><html></font></td>
    <td><input type="text" name="handle_update" mxlength="30"></td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Main Job:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $main_job ?><html></font></td>
    <td>
      <SELECT NAME="main_job_update">
        <OPTION VALUE="Warrior">Warrior
        <OPTION VALUE="Black Mage">Black Mage
        <OPTION VALUE="White Mage">White Mage
        <OPTION VALUE="Red Mage">Red Mage
        <OPTION VALUE="Monk">Monk
      </SELECT>
    </td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Support Job:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $support_job ?><html></font></td>
    <td>
      <SELECT NAME="support_job_update">
        <OPTION VALUE="Warrior">Warrior
        <OPTION VALUE="Black Mage">Black Mage
        <OPTION VALUE="White Mage">White Mage
        <OPTION VALUE="Red Mage">Red Mage
        <OPTION VALUE="Monk">Monk
      </SELECT>
    </td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Advanced Job:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $advanced_job ?><html></font></td>
    <td>
      <SELECT NAME="advanced_job_update">
        <OPTION VALUE="Dark Knight">Dark Knight
        <OPTION VALUE="Paladin">Paladin
        <OPTION VALUE="Beastmaster">Beastmaster
        <OPTION VALUE="Ranger">Ranger
        <OPTION VALUE="Ninja">Ninja
        <OPTION VALUE="Samurai">Samurai
        <OPTION VALUE="Summoner">Summoner
        <OPTION VALUE="Dragoon">Dragoon
      </SELECT>
    </td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Race:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $race ?><html></font></td>
    <td>
      <SELECT NAME="race_update">
        <OPTION VALUE="Hume">Hume
        <OPTION VALUE="Elvaan">Elvaan
        <OPTION VALUE="Taru Taru">Taru Taru
        <OPTION VALUE="Galka">Galka
        <OPTION VALUE="Mithra">Mithra
      </SELECT>
    </td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Kingdom:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $kingdom ?><html></font></td>
    <td>
      <SELECT NAME="kingdom_update">
        <OPTION VALUE="Bastok">Bastok
        <OPTION VALUE="Windust">Windurst
        <OPTION VALUE="San DOria">San D'Oria
      </SELECT>
    </td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Rank:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $rank ?><html></font></td>
    <td><font face="verdana" size="2"><b>---</b></font></td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Level:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $level ?><html></font></td>
    <td><input type="text" name="level_update" maxlength="2"></td>
  </tr>  

  <tr>
    <td><font face="verdana" size="2"><b>E-mail:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $email ?><html></font></td>
    <td><input type="text" name="email_update" maxlength="30"></td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>AIM:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $AIM ?><html></font></td>
    <td><input type="text" name="AIM_update" maxlength="30"></td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Comments:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $comments ?><html></font></td>
    <td><input type="text" name="comments_update" maxlength="30"></td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Beta Tester:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $beta_tester ?><html></font></td>
    <td>
      <SELECT NAME="beta_tester_update">
        <OPTION VALUE="Yes PC">Yes, PC version
        <OPTION VALUE="Yes PS2">Yes, PS2 version
        <OPTION VALUE="No">No
      </SELECT>
    </td>
  </tr>
  <tr>
    <td><font face="verdana" size="2"><b>Importer:</b></font></td>
    <td><font face="verdana" size="2"></html><?php echo $importer ?><html></font></td>
    <td>
      <SELECT NAME="importer_update">
        <OPTION VALUE="Yes">Yes
        <OPTION VALUE="No">No
      </SELECT>
    </td>
  </tr>
  <tr>
    <td colspan="3"><center><input type="submit" value="Submit" name="submit"></center></td>
</table>
</form>
</font>
</html>

<?php

$handle_update = $HTTP_POST_VARS ['handle_update'];
$support_job_update = $HTTP_POST_VARS ['main_job_update'];
$advanced_job_update = $HTTP_POST_VARS ['advanced_job_update'];
$race_update = $HTTP_POST_VARS ['race_update'];
$kingdom_update = $HTTP_POST_VARS ['kingdom_update'];
$email_update = $HTTP_POST_VARS ['email_update'];
$AIM_update = $HTTP_POST_VARS ['AIM_update'];
$comments_update = $HTTP_POST_VARS ['comments_update'];
$beta_tester_update = $HTTP_POST_VARS ['beta_tester_update'];
$importer_update = $HTTP_POST_VARS ['importer_update'];
$submit = $HTTP_POST_VARS ['submit'];
$level_update = $HTTP_POST_VARS ['level'];

}

else if(!empty($submit) && !empty($handle_update) && !empty($level_update) && !empty($email_update) && !empty($AIM_update) && !empty($comments_update)) {

$update=mysql_query("UPDATE users SET handle='$handle_update', level='$level_update', main_job='$main_job_update', support_job='$support_job_update', advanced_job='$advanced_job_update', race='$race_update', kingdom='$kingdom_update', email='$email_update', AIM='$AIM_update', comments='$comments_update', beta_tester='$beta_tester_update', importer='$importer_update', WHERE id = '$id';");
$update_res = mysql_query($update) or die(mysql_error().": ".$update); 

if (!$update_res) 
 {  

echo "<br>Information could not be updated for some odd reason!";  

}  

else  

{  

echo '<font face="verdana" size=2"></b>Update successful!</b> <a href="cp.php"><b>Click here</b></a> to go back to your control panel, and <a href="configure_stats.php"><b>Click here</b> to go back to the Stats Configuration page.</font>';
}  

}
else {

?><html>
<font face="verdana"><b>You didn't fill in all of the required information. Please <a href="configure_stats.php">go back</a> and do so.</b></font>
</html><?php
}

?>

ahundiak

importer='$importer_update', WHERE id = '$id'
Very sad.

Roble

Ummm.... I have tried it without a semi-colon already... That's why I'm here for help, buddy :rolleyes:

Roble

Nevermind I fixed it by myself. Thanks to all the people who offered help to me!