ob_start problem

pinehead18

I am very proud of myself today for figuring out a problem. However i just created another one that kinda stumped me.
I was have a headers already sent problem so i started using ob_start and ob_end_clean. Let me show you the code then i'll tell you the problem

login.php
   UW PICO(tm) 4.2                                          File: login.php                                              Modified   

<?PHP



    include('functions.inc');
    include('header.php');

?>

<?php
        ob_start();         

    userlogin($uname,$pass);

    ob_end_clean();
?>

function.inc function
function userlogin() {


    echo $pass;
    echo "</p>";
    echo $uname;
    echo "</p>";


    $uname = $_POST['uname'];
    $pass = $_POST['pass'];

    $con = mysql_connect("localhost", "", "") or die(mysql_error());
    $db = mysql_select_db("pinehead", $con) or die(mysql_error());
    $sql = "SELECT * FROM users where uname='$uname' and pass='$pass'";
    $result =  mysql_query($sql);
    $row =  mysql_fetch_array($result);

    if ($row["uname"] == $uname && $row["pass"] ==
$pass) {
        setcookie ("user", $uname, time()+604800);
        echo "you are now logged in";
        } else {
        echo "Incorrect login";
}        

}

It is loggin me in and setting the cookie, however it is not displaying "You are now logged in" or echoing the username and pass like it is suppose to. I know it is becuase of the ob functions becuase it echoed everything correctly before when i got the header functions error.

Thank you for your help
Anthony

Weedpacket

You seem to be only a few characters away from having it work: use ob_end_flush() instead of ob_end_clean(), because the latter deletes the contents of the buffer and the former outputs it.

pinehead18

the ob_end_flush does not work either.. Any other suggestions?

See.. I i am pulling the function script from functions.inc.. I can't seem to get it all in the right spot.

pinehead18

  

  $uname = $_POST['uname'];
    $pass = $_POST['pass'];  

ob_start();

    userlogin($pass,$uname);


ob_end_flush();

With this code i am still getting the
Warning: Cannot modify header information - headers already sent by (output started at /home/pinehead/www/header.php:20) in /home/pinehead/www/functions.inc on line 75
you are now logged in error..

Thank you.
Anthony

Weedpacket

Originally posted by pinehead18
With this code i am still getting the
Warning: Cannot modify header information - headers already sent by (output started at /home/pinehead/www/header.php:20) in /home/pinehead/www/functions.inc on line 75
you are now logged in error..

You didn't mention that; is that why you're using output buffering? It's generally better to arrange your code so that you don't attempt to send any output before trying to send headers - output buffering consumes additional system resources (such as memory and time). Figure out what headers you want to send, send them, and then start on outputting content.

Anyway, something on line 20 of header.php is producing output. Since header.php is being run before ob_start() is called, you've already sent that output out before you began buffering. So by the time the setcookie function is called (I'm guessing that's line 75 of functions.php), it's too late to send headers.

pinehead18

What if i put the ob_start at the beginning of header.php and then the ob_end_flesh or whatever at the end of footer.php?

Do you think that woudl work?

Thank you again

yelvington

To the Web server, white space is significant. Any output, including white space, will trigger the server to generate headers. Sending a header after that happens is an error.

pinehead18

 
<?php 

ob_start(); 

function userlogin() { 

   echo $pass; 
       echo "</p>"; 
       echo $uname; 
       echo "</p>"; 



   $con = mysql_connect("localhost", "", "") or die(mysql_error()); 
   $db = mysql_select_db("pinehead", $con) or die(mysql_error()); 
   $sql = "SELECT * FROM users where uname='$uname' and pass='$pass'"; 
   $result =  mysql_query($sql); 
   $row =  mysql_fetch_array($result); 

   if ($row["uname"] == $uname && $row["pass"] == 
$pass) { 
       setcookie ("user", $uname, time()+604800); 
       echo "you are now logged in"; 
       } else { 
       echo "Incorrect login"; 
} 
} 

   $uname = $_POST['uname']; 
   $pass = $_POST['pass']; 


   userlogin($pass,$uname); 



ob_end_flush();

Thank you
- Anthony