help with code!

TweetyPie

I have a problem with the following code, Can someone please explain if there is anything wrong with this code?

when this file is uploaded the line that i have highlighted in red below, does not work! its a button that should 'Add' the list once it has been filled out (its actually a form). But i dont know why it dosent? i have the same problem with another file too.

PLZ HELP!!

include 'db_param.php';
include 'common.php';
include 'header.inc.php';
?>
<html>
<head>
<basefont face="Verdana" size="1">
</head>

if (!isset($submit))
{
$link = mysql_connect($db_h, $db_u, $db_p) or exit ("Could not connect !");
mysql_select_db($db) or exit ("Could not connect to database") or exit ("Could not connect to database") ;

<table border="0" cellspacing="5" cellpadding="2">
<form action="<? echo $PHP_SELF; ?>" method="POST">

<tr>
<td>Job Number<font color="red">*</font></td>
</tr>

<tr>
<td>Title<font color="red"></font></td>
<td width=30> </td>
<td>Department<font color="red"></font></td>
</tr>

<tr>
<td><input type="text" name="jtitle" size="25"></td>
<td width=30> </td>
<td><select name="depart">
<?

// get department list

$sql = "SELECT d_id, dep from depart";
$query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());
while (list($id, $department) = mysql_fetch_row($query))
{
echo "<option value=$id>$department</option>";
}
mysql_free_result($query);
?>
</select></td>
</tr>

<tr>
<td>Location<font color="red"></font></td>
<td width=30> </td>
<td>Salary<font color="red"></font></td>
</tr>

<tr>
<td><select name="location">
<?

$sql = "SELECT l_id, location from location";
$query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());
while (list($id, $location) = mysql_fetch_row($query))
{
echo "<option value=$id>$location</option>";
}
mysql_free_result($query);
?>
</select></td>
<td width=30> </td>
<td><select name="salary">
<?

$sql = "SELECT s_id, salary from salary";
$query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());
while (list($id, $salary) = mysql_fetch_row($query))
{
echo "<option value=$id>$salary</option>";
}
mysql_free_result($query);

mysql_close($link);
?>
</select></td>
</tr>

<tr>
<td>Responsibilities<font color="red"></font></td>
<td width=30> </td>
<td>Qualifications<font color="red"></font></td>
</tr>

<tr>
<td>Contact person<font color="red"></font></td>
<td width=30> </td>
<td>Email address<font color="red"></font></td>
</tr>

</table>
</form>
<?
}
else
{

$errorList = array();
$list = 0;

if (empty($jnum))
{ $errorList[$list] = "Invalid entry: Job code"; $list++; }

if (empty($jtitle))
{ $errorList[$list] = "Invalid entry: Job Title"; $list++; }

if (empty($jresp))
{ $errorList[$list] = "Invalid entry: Responsibilities"; $list++; }

if (empty($jreq))
{ $errorList[$list] = "Invalid entry: Qualifications"; $list++; }

if (empty($jcont))
{ $errorList[$list] = "Invalid entry: Contact"; $list++; }

if (empty($contmail) || mail_check($contmail))
{ $errorList[$list] = "Invalid entry: Contact Email "; $list++; }

    if (sizeof($errorList) == 0)
    {

    $link = mysql_connect($db_h, $db_u, $db_p) or exit ("Could not connect !");
    mysql_select_db($db) or exit ("Could not connect to database") ;


    $sql = "INSERT INTO job (j_num, j_title, j_resp, j_req, j_cont, cont_mail, posted, depart, location, salary) VALUES ('$jnum', '$jtitle', '$jresp', '$jreq', '$jcont', '$contmail', NOW(), '$depart', '$location', '$salary')";
    $query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());

    mysql_close($link);
    echo "Added Successfully.<p><a href=$PHP_SELF>Add another</a>, or return to <a href=jobs.php>jobs</a>";
    }
    else
    {
    err();
    }

}
?>
<?
include 'footer.inc.php';
?>

</body>
</html>

paulnaj

It's a bit much posting your whole page and asking 'what's wrong!'. It doesn't do what you expect, but let us know what does happen?

Here's some tips:

1) View the html source of your page in a browser. Are all the form attributes well-formed?

2) Strip the code out piece by piece until it works, then re-build it piece by piece, checking each time.

3) Your version of PHP might require referring to PHP vars like $PHP_SELF as $_SERVER["PHP_SELF"].

Good luck!

TweetyPie

im sorry i didnt know what to do
il have a go and try and find whats wrong

paulnaj

Didn't mean to sound harsh ... what I really meant to say was that if you do try to pinpoint exactly where the problem actually is, often the solution justs pops out anyway.

Have a look at the $PHP_SELF issue ... I've just upgraded PHP on my local computer and had to make this change myself.