What is wrong with this?

[jamesm87]

select * from phpbb_categories where cat_id = (1,2)

Thanks in advance!

James

[laserlight]

I think that you cant specify ranges that way.

Probably should use:

SELECT * FROM phpbb_categories WHERE cat_id>=0 AND cat_id<=2

[jamesm87]

Well unfortunatly is it in a phpbb script.

What is the best way to fix this?

Here is the block affected

function get_sub_cat($cat_main, $catrow )
{
	global $db;

if ($cat_main > 0)
{
	// lire les rubriques dépendantes
	$sql= "SELECT * FROM ".CATEGORIES_TABLE." WHERE cat_id <> $cat_main AND cat_main=$cat_main";
	if( !($result = $db->sql_query($sql)) ) message_die(GENERAL_ERROR, 'Could not query categorie sons '.$sql, '', __LINE__, __FILE__, $sql);
	while ( $catw = $db->sql_fetchrow($result) )
	{
		// ajouter la catégorie
		$i = count($catrow);
		$catrow[$i] = $catw;
		// aller chercher les sous-catégories
		if ($catw['cat_id'] > 0) $catrow = get_sub_cat($catw['cat_id'],$catrow);
	}
}
return $catrow;
}

// build sorted cats array
function get_cat($cat_id)
{
	global $db;

// vérifier la catégorie
if ($cat_id <= 0) $cat_id = -1;
if ($cat_id > 0)
{
	$sql = "SELECT * FROM " . CATEGORIES_TABLE . " WHERE cat_id=$cat_id";
	if ( !($result = $db->sql_query($sql)) ) message_die(GENERAL_ERROR, 'Could not query this categories', '', __LINE__, __FILE__, $sql);
	if ( !($row = $db->sql_fetchrow($result)) ) $cat_id = -1;
}

thankyou! 😃

[superwormy]

Um... the originally posted query isn't in that block of code at all...

What are you trying to do with your query? Specify a range or values that you want to select, or specify two individual values to select or...?

[jamesm87]

  $sql = "SELECT * FROM " . CATEGORIES_TABLE . " WHERE cat_id=$cat_id"; 

There it is... It wants to select information which has cat_id = 1 , 2

It can be more ie

cat_id = 1 , 2 , 3, 4

any idea's?

[jamesm87]

Ok I will make is simpler

select * from phpbb_categories where cat_id =(1,2)

How is another way of doing that? Keeping in mind that cat_id can be cat_id=(1,2,3,5,7,8)

thanks in advance

[laserlight]

you could use a loop to build the query, appending OR cat_id=$x for each iteration.

[superwormy]

You can't just list off values like that in SQL... you need to do something like:

SEELCT * FROM category WHERE cat_id = 1 OR cat_id = 2 OR cat_id = 3

You might also be able to use the IN () statement depending on which db you're using... ( MySQL and PostgreSQL at the very least both support this )

SELECT * FROM category WHERE cat_id IN ( 1, 2, 3 );

But you can't just list off values...