php class

dreams4000

Hi all, can someone take a look at this file and tell me if they can see what im missing. I am very new to working with classes so im sure something is messed up. The problem is this, this code works just fine with the file executed directly (/blahblah.php) if it is not within a class. When I place this file in a class and execute it via a function (/blahblah.somefunction) it will only work (mostly) if I take out $sql .= "order by id DESC LIMIT ".$DPN_row_num.",10"; . I need those in there, the file works just fine outside of the class but not in, so I have a feeling its just something messed up in the code that needs to be changed for a class.. any help is appreciated.

<?php
class oxynews_N_edit
{

function EditNews()
{

commonHeader();

if (!$GLOBALS['g_oSec']->HasSecLvl($GLOBALS['dcl_info']['DCL_DEL_WO']))
return PrintPermissionDenied();

include("oxynews_config.php");

echo"<font face='Verdana, Arial, Helvetica, sans-serif' size='2'>
<center>\n";

if ($id) {

$sql = "SELECT * FROM $oxynews_mysql_table_name WHERE id=$id";
if ($oxynews_usermade) {
$sql .= " and author='".$phpUserLogin_userinfo["short"]."'";
}

$result = mysql_query($sql);

if (@mysql_num_rows($result) > 0) { // If there is news in the table.

$myrow = mysql_fetch_assoc($result);

<a href='class.oxynews_N_edit.inc.php'>Back</a><p>
Edit the fields, and press Update!<br>
Note: Titles can only be 40 characters long.</p>

<table>
<tr>
<td colspan="2" align="center"><font face="Verdana, Arial, Helvetica, sans-serif" size="1">Title:</font><br><input type ="text" name = "title" MaxLength=50 value="<?php echo $myrow["title"] ?>"></td>
</tr>
<tr>
<td align="center"><font face="Verdana, Arial, Helvetica, sans-serif" size="1">News:<br><textarea name ="desc" rows = "10" cols = "50" wrap="VIRTUAL"><?php echo $myrow["description"] ?></textarea><br></font>
</td>
</tr>
</table>
<p>

</form>

<?php

} else {
echo "Something went wrong. Press back and try again.\n";
}

} else {
DPN(10,"class.oxynews_N_edit.inc.php",$oxynews_mysql_table_name,$oxynews_usermade);

$sql = "SELECT * FROM $oxynews_mysql_table_name";
if ($oxynews_usermade) {
$sql .= "WHERE author='".$phpUserLogin_userinfo["short"]."' ";
}
$sql .= "order by id DESC LIMIT ".$DPN_row_num.",10";

$result = mysql_query($sql);

$oxynews_num_rows = @mysql_num_rows($result);
$oxynews_i = 0;

if ($oxynews_num_rows > 0) { // If there is news in the table.

echo"Select the title of the news item you wish to edit:<p>";

echo $DPN_Button."<p>";

echo"<table border = '0' width = '65%' align='center'>\n";

while ($rows = mysql_fetch_assoc($result)) {

if (empty($rows[title])) {

$rows[title] = "ERROR - TITLE IS EMPTY";

}

echo" <tr>
<td bgcolor='#CCCCCC'><font face='Verdana, Arial, Helvetica, sans-serif' size='2'><a href=\"?id=$rows[id]&DPN_row_num=$DPN_row_num\"><b>$rows[title]</b></a> - Posted : <b>".$rows[date]." ".$rows[time]." GMT</b> by <b><A HREF='mailto:".$rows[email]."'>".$rows[author]."</A></b></font></td>
</tr>
<tr>
<td bgcolor='#FFFFFF'><font face='Verdana, Arial, Helvetica, sans-serif' size='2'>".oxynews_bbcode($rows[description])."</td>
</tr>\n";
$oxynews_i++;
if ($oxynews_i < $oxynews_num_rows) {
echo" <tr>
<td> </td>
</tr>\n";
}
}

echo"</table><p>";
echo $DPN_Button;

} else {

echo "<font face='Verdana, Arial, Helvetica, sans-serif' size='2'>";
if ($oxynews_usermade) {
echo"No news made by you in the database";
} else {
echo"No news in database";
}
echo"</font>\n";

}

echo"</center>
</font>";

}
}

steadyguy

Since you're using OOP, anyway ... why not write a separate function to connect to the db? It'd make your code less cluttered, and you could pass it an argument with the query in it ... then you can set the query either in a class variable , and pass it that way, which would also probably make your life easier ...

dreams4000

Maybe I am misunderstanding, but the database query stuff, is already within a function in the above file. The database connect info is coming from the included config file. I have tried putting the query info in its own function seperate from the rest but that simply creates the same problem as it is already in a function which is within a class, that doesnt work correctly. Is there something wrong perhaps with the code syntax itself? I am not really looking for a "better" way of doing this, I am looking for the correct way of making this work. Thanks!🙂

dreams4000

Also, so you can see where this is coming from. That DPN function in the above file, is calling from the dpn's actual function define in the config file.. This is the function it is working from.. maybe between the two someone can see what the issue is. I dont know if there is special code or what not that has to be used when you start working from a class.

function DPN ($num_rows, $this_page, $table_name, $slq_more = "", $extra_url = "") {

Parameter 1: The number of rows that it will change for every time you press a next or prev button.
have been made it will output 0, just as it should.
Parameter 2: The path to the page where the script is used.
Parameter 3: The name of the table where the scripts counts rows in.
Parameter 4: If you need to add something like, "where id=something" to the query then do it there.
Parameter 5: If you need to add more to the links write it here. Remember the & at the start.

Remember that you must open a connection to the sever and also open a database before you use this function.
*/

global $DPN_row_num, $DPN_Button;

/ Design /
$super_prev = "Start";
$prev = "Prev";
$number_r = "[";
$number_l = "]";
$next = "Next";
$super_next = "End";
$non = "--";

$mysql_query = "SELECT COUNT(*) FROM $table_name";

if ($slq_more) {
$mysql_query .= " ".$slq_more;
}

$mysql_result = @($mysql_query);
$mysql_row = @mysql_fetch_row($mysql_result);

$total_rows = $mysql_row[0];

settype($DPN_row_num, "integer");
if (empty($DPN_row_num) OR $DPN_row_num < 0) {
$DPN_row_num = 0;
} elseif ($DPN_row_num > $total_rows) {
$DPN_row_num = floor($total_rows/$num_rows)$num_rows;
} elseif (!is_int($DPN_row_num/$num_rows)) {
$DPN_row_num = floor($DPN_row_num/$num_rows)$num_rows;
}

$button .= "<b>";
if ($total_rows > $num_rows) { // If the total amount of rows in the database is bigger then $num_rows

/ Looks for Prev Button /
if ($DPN_row_num >= $num_rows) {
$button .= "<a href='".$this_page."?DPN_row_num=0".$extra_url."'>$super_prev</a>";
$button .= " <a href='".$this_page."?DPN_row_num=".($DPN_row_num-$num_rows).$extra_url."'>$prev</a>";
} else {
$button .= "$super_prev";
$button .= " $prev";
}
/ Numbers in between next and prev button /
for ($i = 0; ($i$num_rows) < $total_rows; $i++) {
$button .= " ".$number_r;
if (($i$num_rows) != $DPN_row_num) {
$button .= "<a href='".$this_page."?DPN_row_num=".($i$num_rows).$extra_url."'>";
}
$button .= $i+1;
if (($i$num_rows) != $DPN_row_num) {
$button .= "</a>";
}
$button .= $number_l;
}
/ Looks for Next Button /
if (($DPN_row_num+$num_rows) < $total_rows) {
$button .= " <a href='".$this_page."?DPN_row_num=".($DPN_row_num+$num_rows).$extra_url."'>$next</a>";
$button .= " <a href='".$this_page."?DPN_row_num=".(floor($total_rows/$num_rows)*$num_rows).$extra_url."'>$super_next</a>";
} else {
$button .= " $next";
$button .= " $super_next";
}
$button .= "</b>";

} else {
$button .= $non;
}
$button .= "</b>";
$DPN_Button = $button;
}
/ /

/ This function turns < and > and " and ' into html tags /
function oxynews_remove_tags($txt) {
$oxynews_removetag['<'] = '<';
$oxynews_removetag['>'] = '>';
$oxynews_removetag['"'] = '"';
$oxynews_removetag["'"] = ''';
$txt = strtr($txt, $oxynews_removetag);
return $txt;
}

dreams4000

No one has any ideas?;\ I wouldn't think this would be a difficult fix for someone that knows php. It seems like it is just an issue with coding within a class. Any help on this is much appreciated.

steadyguy

It would help if the code was more readable (the PHP vB Code button is there for a reason) ... that's one of the reasons why I suggested putting things into separate functions. (Or that's what I meant, if I didn't make myself very clear.) As it is, it appears as though you only have one function in your class - which sort of defeats the purpose of OOP. And while it may sound like I was just recommending a 'better' way to OOP, I made those suggestions as a first step to finding out what your problem is. Because 'better' code is also easier to debug.

In any case ... it's a heck of a lot of code to go through, and most people aren't willing to go to that kind of effort in an exchange for only a 'Thanks so much!'

On to the problem at hand, however: do you get any error messages? Or does the code execute silently, but display nothing? Or worse, the wrong stuff?

Have you looked at the problem of scope? If it is causing problems, it can be circumvented by using class variables instead of private or global variables.

If you could quote the section where you instantiate the class and access its methods, that could be useful, too ...

By the way, there's a built in PHP function that will remove html tags for you, or if you just want to replace them, a preg_replace() or eregi_replace() would be easier to read.

dreams4000

hi, sorry for the long bit of code there. I guess what my concern is, is that what difference would it make if i put it in multiple functions vers. the one function? the same problem still exists as it is just in a differnt function now. The issue is that this code works fine without that Class and function wraping around it. Unfortunatly, that wrap has to be there to be able to integrate it into the frame of another program im putting it in.

I have done it this way with some other files for this program and it has worked fine, the only ones I have had issues with are the ones that connect to the database with this DPN function. If i leave everything how it is here, I just get a message that states there is no news found in the database ( even though there is news). If I take out:

$sql .= "order by id DESC LIMIT ".$DPN_row_num.",10";

That one line, it will show the news in a listing, but the point of the dpn function is create multiple pages so that all the news items arnt showing up on one single page, which it does, if it isnt in the class/function wrapper. Also the program this is going in, the function that runs this file has to be specified in the url itself.. /editnews_phpfile.somefunction in this manner.. to activate the code in the function. If I split it up into multiple functions it seems to get way out of wack.

So the whole issue is with that one bit of code there, I dont think putting it in another function will do any better than having it all in one. Yes it would be cleaner and all but on functionality I dont think its going to make any difference :\ I am just lost as to why this one line of code would make it so that it thinks there is no news in the database. Any ideas? Thanks again for your time with this, I am sorry for hte long bits of code.

steadyguy

It sounds like you have a scope problem: ie., variables that you assign inside a function aren't available outside of it. If you assign your variables as class variables (using the $this->variable_name format), you can use them both inside the function and outside, as well as use them from other classes...

Another possibility might be the use of the ?> ... <?php to print a whole bunch of HTML in the middle of the class. Intuitively, it doesn't seem like it should cause a problem, but it might be. One solution might be to put the file into an include, which has the added advantage of making the code shorter and more readable.

Actually, putting little functions that get repeated over and over into distinct functions (viz., modularity) is one of the main advantages of OOP. And it definitely would help - it would isolate any bugs so that fixing them is also easier, in addition to making your code more easily portable to another application. Of course, it's a lot of work to do it that way, especially if you've got a bunch of code like yours. But in the end, it's easier to find and fix problems, and if you do it right, you can use the code almost 'as-is' in other applications, in the future.