Help with Insert Code

artisticre

My code is placing two entries in the database when I only submit once. Help???

<input type="text" name="shirtname" size="20">Shirtname:<br>
<input type="file" name="imagefile" size="20">Image:<br>
<input type="text" name="category" size="20">Category:<br>
<input type="text" name="shirtavail" size="20">T-Shirt Availability:<br>
<input type="text" name="mediumshirt" size="20">T-Shirt Medium:<br>
<input type="text" name="largeshirt" size="20">T-Shirt Large:<br>
<input type="text" name="XLshirt" size="20">T-Shirt XL:<br>
<input type="text" name="XXLshirt" size="20">T-Shirt 2XL:<br>
<input type="text" name="XXXLshirt" size="20">T-Shirt 3XL:<br>
<br><br>
<input type="text" name="smallsweat" size="20">Sweatshirt Small:<br>
<input type="text" name="mediumsweat" size="20">Sweatshirt Medium:<br>
<input type="text" name="largesweat" size="20">Sweatshirt Large:<br>
<input type="text" name="XLsweat" size="20">Sweatshirt XL:<br>
<input type="text" name="XXLsweat" size="20">Sweatshirt 2L:<br>
<input type="text" name="XXXLsweat" size="20">Sweatshirt 3L:<br>
<input type="text" name="XXXXLsweat" size="20">Sweatshirt 4L:<br>

<?
$connection=mysql_connect("","","") or die("Could not connect to the database server");
$db= mysql_select_db("",$connection) or die ("Unable to select database.");
if(isset( $Submit ))
{

if ($_FILES['imagefile']['type'] == "image/gif"){

copy ($_FILES['imagefile']['tmp_name'],  "../TShirts/".$_FILES['imagefile']['name'])
or die ("Could not copy"); 


    echo "<br>"; 
    echo "Name: ".$_FILES['imagefile']['name']."<br>"; 
    echo "Size: ".$_FILES['imagefile']['size']."<br>"; 
    echo "Type: ".$_FILES['imagefile']['type']."<br>"; 
    echo "Copy Done...."; 
    $tempfilename = $_FILES['imagefile']['name']; 
    $SQL = "INSERT INTO shirttest (shirtname, image, category, shirtavail, mediumshirt, largeshirt, XLshirt, XXLshirt, XXXLshirt,smallsweat, mediumsweat, largesweat,  XLsweat,XXLsweat, XXXLsweat, XXXXLsweat) VALUES ('$shirtname','$tempfilename','$category','$shirtavail','$mediumshirt','$largeshirt', '$XLshirt', '$XXLshirt','$XXXLshirt',  '$smallsweat', '$mediumsweat' ,'$largesweat','$XLsweat','$XXLsweat','$XXXLsweat','$XXXXLsweat')"; 
    $Result = mysql_query($SQL) or die(mysql_error()); 
    echo "Test: ".$tempfilename."";
           } 

    else { 
        echo ""; 
        echo "Could Not Copy, Wrong Filetype (".$_FILES['imagefile']['name'].")"; 
    }

}

?> </form>
</body>
</html>

pnoeric

Though the error doesn't jump right out, I have to ask: is that two separate scripts? is the form action supposed to set to the same file? if so, it might be doing one insert the first time through, then a second insert after you submit the form.

Here's what you should do next: SIMPLIFY your script by removing everything that is extraneous, and comment out the real SQL call and put in this instead: "echo $SQL" (just so you don't have to deal with cleaning up the db while you're debugging).

Then you'll see every time the "insert" is happening. Once you fix that... put back all the stuff you removed (all those input fields, etc) and then see if the bug is still gone.

Check out my "cardinal rules" in my signature, below!

best
Eric