display content issue

mrbraq

require("abstract_page.php"); 
import_request_variables('GP'); 
define('IN_PHPBB', true);

class MaintainUsersPage extends Page {}
$maintainusers = new MaintainUsersPage();
$maintainusers -> SetPageTitle ("Maintain Users");
$maintainusers -> SetContentFile ("maintain_users_body.tpl");

// Alternative to calling from query: getAllUsers();

function getAllUsers(){ 

global $maintainusers;
$maintainusers -> SetUserMessage ("try this message!", "alerts"); 	

/* Get all users and display in a table */
// open connection to database
require (PRIVATE_PATH . "db_connect.php");
$result = mysql_query("SELECT * FROM USER",$db);

$html = "<table border=\"1\" cellpadding=\"5\" cellspacing=\"0\">\n";
$html .= "<tr><td>ID</td><td>Name</td><td>Username</td><td>Email</td></tr>\n";

while ($myrow = mysql_fetch_row($result)) {
	if ($myrow[2] != null) {
		$html .= "<tr><td>$myrow[0]</td><td>$myrow[3] $myrow[4]</td><td>$myrow[1]</td><td>$myrow[2]</td></tr>\n";
	}
}

$html .= "</table><br />\n";

$maintainusers -> SetContent ($html);
$maintainusers -> Display(); 

exit;

mysql_close($db);
}

$maintainusers -> Display();
?>

If the above is NOT included in a function on a child page without reinstantiating $maintainusers = new Page();, my table will display on the page.

If I put this all in a function, as shown above, and call the function via a query, the HTML will not display.

Suggestions??

steadyguy

It looks like you've made $html a private variable, so it is unavailble to anything outside the function - including the rest of the class. Try replacing it with $this->html, making it a class variable. Then you can use it from anywhere you like. Note that while you can use it in the format $this->html from inside the class, you'll need to use $maintainusers->html outside the class.

mrbraq

I've edited my code but am still having issues.

No, the html variable seems to work fine. Here are some of my recent findings:

If I call the function directly from the page, my content will display.
If I call the function via the query string, it WILL make it inside the function, because I can perform a redirect, however...
My page shows up as blank and no content will be displayed when the function is called from the query string.

steadyguy

I assumed that the function getAllUsers() is inside a class ... is it? Or if it is outside, from where do you call it?

I also assume it was on purpose that your MaintainUsersPage class is empty, and that there is actually a bunch of code inside those braces, that you deleted for the sake of brevity. However, one gotcha of PHP class inheritance is that instantiating a child class doesn't run the constructor of the parent automatically, it must be explicit:

class Kid extends Goat {
    function Kid() {
        parent::Goat();
        //other stuff
    }
}

Also, I assume that the function getAllUsers() is inside another class.

On a tangent: as long as there is an instance of MaintainUsersPage, instead of using a global $maintainusers, statement, you can simply use the ClassName::variable_name notation. Additionally, having an expression or statment immediately after an exit statement isn't very useful unless it's in an if/else clause.

mrbraq

Thank you for spending time on this. I've shortened my code just to get the basic functionality down.

My main goal is to call setTitleInChildClass (in this example) by handling a query value that calls the method. For example, "www.domain.com?callFunction=setTitleInChildClass"

If no method is called from the query, then the title would be set by $childpage -> SetPageTitle ("Maintain Users"); below the ChildPage class.

<?php 
require("abstract_page.php");   

class ChildPage extends Page {  

    function setTitleInChildClass(){  

        parent :: SetPageTitle ("Title From Function");   

        parent :: Display();       

    }  

}  

$childpage = new ChildPage ();  

$childpage -> SetPageTitle ("Maintain Users");  

$childpage -> Display();  

?>

(Now you know why I posted this in the Newbie area. Please excuse my ignorance. I'm still getting used to the differences between Java and PHP)

steadyguy

PHP doesn't have automatic Set/Get functions in classes ... you need to write them explicitly. So it would be easier to do use the constructors to do it for you when a class is instantiated:

class Groove {
    var  $pageTitle;
    function Groove($title) {
        //in case they forgot to supply an argument, we ignore it:
        if ($title)
            $this->pageTitle = $title;
    }
    function display() {
        print 'Play that funky music, white boy!';
    }
}

class Disco extends Groove {
    function Disco($title) {
        parent::Groove($title); // makes $this->pageTitle whatever you pass to parent::Groove
    }
    function display() {
        //now we overload the parent function
        parent::display();
        print "\r\nStayin' alive, baby!";
    }
}

$mainTitle = "Funky Groovin'";
$subTitle = "Stayin' Alive";
$groove = new Groove($myTitle);
$disco = new Disco($subTitle);
//you still haven't displayed anything though ... so:
$disco->display();

The result of the above code is:
Play that funky music, white boy!
Stayin' alive, baby!

Does this help?

Edit:

I forgot something: GET, POST, COOKIE and other such variables are not automatically available to the script, unless you have register_globals on (not a very good idea). So you'll need to write some logic to instantiate the appropriate class. (After validating them, anyway.)

mrbraq

I understand your example, but if I try to ignore the parts that aren't applicable to what I'm doing, I don't see how it's different than what I've already done. Would you be willing to modify the code which I provided where you think it's wrong?

In my example, my Abstract page classes do not have default values set and I do not overload any methods on the child page. I only want to use functions on my child page to compute data to send back to the existing functions on my parent page, not overload them.

EDIT: I think I got it. Let me know if there's something wrong with doing it this way...

require("abstract_page.php");  

define('IN_PHPBB', true); 

class MaintainUsersPage extends Page { 
   function getAllUsers(){ 
      parent :: SetPageTitle ("Title From Function");     

        parent :: Display();  

   } 
} 

$maintainusers = new MaintainUsersPage(); 

if ($_REQUEST['cmd'] != null) { 
   $maintainusers -> $_REQUEST['cmd'](); 
} 
else { 
   $maintainusers -> SetPageTitle ("Maintain Users"); 
   $maintainusers -> Display(); 
}

steadyguy

That looks like it should work ...