Is this legal Syntax

dniezby

$error_message="?>
<html>

Error! 

A required field was not completed or is in error. Please return and re-submit
the form.
<input type="button" onclick"javascript:history.back(1);" name="Go Back">

</html>"
<?php

if (!$agree){
echo $error_message
}

austinderrick2

I belive it should be more like this:

$error_message = "
<html> 
<font face=Arial size=4> 
Error!</font><BR> 
<font size=3> 
A required field was not completed or is in error. Please return and re-submit 
the form. 
<input type=\"button\" onclick\"javascript:history.back(1);\" name=\"Go Back\"> 
</font> 
</html>";

if (!$agree){ 
echo $error_message 
}

dniezby

I've never used those \ 's
What are those there for?

austinderrick2

They tell php not to stop the quotes for the quote that directly follows the \ That makes it where you can put html into echo tags,ect. 😉

stolzyboy

it is called escaping characters, so you can have your html attributes double quoted inside double quoted strings in php

similar to what [man]addslashes[/man] does when inserting into mysql db and such

dniezby

It's not showing the button?
It's showing an empty box.

dniezby

Nevermind...I fixed it.

stolzyboy

twas supposed to be a value=something in there huh

dniezby

Yup.

But now i'm having another problem.
Now, the script processes the form data, but doesn't post anything to screen.

Could you look at this and see if I missed something? I've looked at it a hundred times and I must be blind.

$error_message="<html>
                <font face=Arial size=4>
                Error!</font><BR>
                <font face=Arial size=3>
                A required field was not completed or is in error. <BR>
                Please return and re-submit the form. <BR>
                <input type=\"button\" onclick=\"javascript:history.back(1);\" value=\"Go Back\">
                </font>
                </html>
                ";


// CHECK THE VALIDITY OF EMAIL ADDRESS

// If eMail is not a valid address
if ($email){
    $sender=trim($email);   // Remove white space from email field

   //Check if email DOES NOT contain a valid form
   if (!eregi("^[_\.0-9a-z-]+@([0-9a-z][0-9a-z-]+\.)+[a-z]{2,3}$",$email)){
   echo $error_message;
   }

}elseif(!$email){     // If eMail is blank
      echo $error_message;

}elseif(!$agree){   // If agreement is blank
      echo $error_message;

}else          //If email valid and agreement is valid
    switch ($script_choice) {

   case 1:
   		?><html>
         <FONT FACE="Arial" SIZE="4" COLOR="#000000">
         <B>Your submission was successful!</B><BR></font>
         <font size=3>
         You may now download the script you selected<BR>
         You are ready to download: <a HREF="http://www.nsfilms.com/files/mortician.pdf">The Mortician's Tales (Wrap Script)</a>
	       <P><I>NOTE: It is recommended that you change your Acrobat Reader Settings by unchecking it's option, "Open in Browser".<BR>
	       Otherwise, the document will download and open automaticly.</I>
	       </FONT>
         </html>
         <?php
         break;

   case 2:
        ?>
        <html>
        <FONT FACE="Arial" SIZE="4" COLOR="#000000">
        <B>Your submission was successful!</B><BR></font>
        <font size=3>
	      You may now download the script you selected<BR>
	      You are ready to download: <a HREF="http://www.nsfilms.com/files/prem.pdf">Premonitions</a></FONT>
	      <P><I>NOTE: It is recommended that you change your Acrobat Reader Settings by unchecking it's option, "Open in Browser".<BR>
	      Otherwise, the document will download and open automaticly.</I>
	      </font>
	      </html>
        <?php
        break;

   case 3:
        ?>
        <html>
        <FONT FACE="Arial" SIZE="4" COLOR="#000000">
        <B>Your submission was successful!</B><BR></font>
        <font size=3>
	      You may now download the script you selected<BR>
	      You are now ready to download: <a HREF="http://www.nsfilms.com/files/jghost.pdf">Johnson's Ghost</a>
	      <P><I>NOTE: It is recommended that you change your Acrobat Reader Settings by unchecking it's option, "Open in Browser".<BR>
	      Otherwise, the document will download and open automaticly.</I>
        </FONT>
	      </html>
	      <?php
	      break;

    case 4:
        ?>
        <html>
        <FONT FACE="Arial" SIZE="4" COLOR="#000000">
        <B>Your submission was successful!</B><BR></font>
        <font size=3>
	      You may now download the script you selected<BR>
	      <P>You are now ready to download: <a HREF="http://www.nsfilms.com/files/weasle_full.pdf">Goes the Weasle</a></FONT>
	      <P><I>NOTE: It is recommended that you change your Acrobat Reader Settings by unchecking it's option, "Open in Browser".<BR>
	      Otherwise, the document will download and open automaticly.</I>
	      </font>
        </html>
	      <?php
	      break;
      }
// All good, send eMail to Nightshade Films

$recipient="dniezby@nsfilms.com";

mail($recipient,"Script Download","
First Name: $first
Last Name: $last
Address: $address
City: $city
State: $state
Zip: $zip
Phone: $phone
email: $email
Script: $script_choice
","FROM:$email");
?>

tbach2

It might help if you change your logic flow: do all your actions, then the last thing is to show output. I usually put the form and response in the same script, with the form being the default thing displayed if no action is taken, ie:

psuedocode:

// check/define variables

// if(this a submission?)

//  if(valid email && valid agree)

    //  mail()
    //  switch output
    //  die;

// else 
    $error = 'error...';
//  endif
//  endif

// display form with values filled in as available.

To answer your question:

}else //If email valid and agreement is valid

is based on a false assumption; this only happens if

if ($email){

is false! 😉