Why...WHY!!!!

[VooDooRT]

This is just about on my last nerve, I don't know why, but whenever the script below executes functions autodemote, it ends up displaying the information on the page TWICE! Once for each rank the member is/was.

I'm not sure where to go with this, but it's highly irritating...

 for($i=15; $i >= 10; $i--) {

$result88 = @mysql_query("SELECT * FROM members WHERE disable != 1 and rank = $i");
while($row1 = mysql_fetch_array($result88)) {
	  extract($row1);
	$days = calcDSL($row1['username']);
  $aim1 = $row1['aim'];
  $msnm1 = $row1['MSNM'];
  $yim1 = $row1['YIM'];
  $icq1 = $row1['icq'];
   $rank_img = getrankimg($row1["rank"]);
  $username1 = $row1['username'];
  $lastdemo = $row1['lastdemo'];
  $result = @mysql_query("SELECT * FROM site_prefs");
  $dsl_ = mysql_fetch_array($result);
  $off_dsl = $dsl_['off_dsl'];
  $dis_dsl = $dsl_['dis_dsl'];
  if ($site_prefs['dsl'] == 1) {
    $days = calcDSL($row1['username']);
       if($days >= $off_dsl and $lastdemo != $today1) {
       if($days >= $dis_dsl) {
        autodisable($row1['username'], "severe inactivity", "WEBSITE");
        }
      else {
       autodemote($row1['username'], "inactivity", "WEBSITE");
      }
     }
  }
       echo("
        <tr><td><center><img src=images/$rank_img></center></td>
        <td><center>$fontString<a href=profile.php?user=$username1>$username1</a></td>");


    if ($site_prefs['MSNM'] == 1) {
    echo("<td><center>$fontString$msnm1</td>");
    }

    if ($site_prefs['YIM'] == 1) {
    echo("<td><center>$fontString$yim1</td>");
    }

    if ($site_prefs['ICQ'] == 1) {
    echo("<td><center>$fontString$icq1</td>");
    }

    if ($site_prefs['AIM'] == 1) {
    $aim = ereg_replace (" ", "+", $aim1);
    echo("<td><center>$fontString<a href=aim:goim?screenname=$aim&message=Hi.+Are+you+there? >$aim1</a></td>");
    }        
if ($site_prefs['dsl'] == 1)
echo ("<td><center>$fontString$days</td>");

      $tester = 
      mysql_query("select * from online_user where USERid = '$username1'");
    if (mysql_num_rows($tester) > 0)
    $online = "Yes";
    else
    $online = "No";

    echo "<td><center>$fontString$online</td></TR>";

    $num_mems++;
    $officers++;
  }

  }

[coreyp_1]

Check your flow:

=================

Start at rank 15 & go down:

For each person on this rank:

assign variables, etc.

If they need to be demoted, demote them.

Print out this person's stuff.

Go to next person.

=================

Assume I am rank 10, but need to be demoted.

When your script processes everyone for rank 10, i will be demoted, but my information will still be printed.

The script then processes everyone for rank 9. I will show up with them, b/c I was just demoted.

In short, you need to structure your code so that, if an individual is demoted, than his information will not be printed out yet. You can hack this using logical (true/false) flags, or you can figure out a way to do it using a logical flow.

Either way, good luck, and I hope this was helpful.

[VooDooRT]

I've tried to rearrange the flow, but I've had little to no luck with it. I'm really LOST!

[coreyp_1]

I've moved a block of text (that prints the user information) into an ELSE... statement. The comments should tell you what Í've done:

<?php
for($i=15; $i >= 10; $i--) { 
    $result88 = @mysql_query("SELECT * FROM members WHERE disable != 1 and rank = $i"); 
    while($row1 = mysql_fetch_array($result88)) { 
        extract($row1); 
        $days = calcDSL($row1['username']); 
        $aim1 = $row1['aim']; 
        $msnm1 = $row1['MSNM']; 
        $yim1 = $row1['YIM']; 
        $icq1 = $row1['icq']; 
        $rank_img = getrankimg($row1["rank"]); 
        $username1 = $row1['username']; 
        $lastdemo = $row1['lastdemo']; 
        $result = @mysql_query("SELECT * FROM site_prefs"); 
        $dsl_ = mysql_fetch_array($result); 
        $off_dsl = $dsl_['off_dsl']; 
        $dis_dsl = $dsl_['dis_dsl']; 
        if ($site_prefs['dsl'] == 1) { 
            $days = calcDSL($row1['username']); 

// If the membership info needs to be changed, then either
// disable or demote them, and continue on to the next user

        if($days >= $off_dsl and $lastdemo != $today1) { 
            if($days >= $dis_dsl)
                autodisable($row1['username'], "severe inactivity", "WEBSITE"); 
            else
                autodemote($row1['username'], "inactivity", "WEBSITE"); 
            } 
        else {

// If the membership information DID NOT need to be changed,
// then print the appropriate information, then continue on
// to the next user.

            echo(" 
                <tr><td><center><img src=images/$rank_img></center></td> 
                <td><center>$fontString<a href=profile.php?user=$username1>$username1</a></td>"); 
            if ($site_prefs['MSNM'] == 1)
                echo("<td><center>$fontString$msnm1</td>"); 
            if ($site_prefs['YIM'] == 1)
                echo("<td><center>$fontString$yim1</td>"); 
            if ($site_prefs['ICQ'] == 1)
                echo("<td><center>$fontString$icq1</td>"); 
            if ($site_prefs['AIM'] == 1) { 
                $aim = ereg_replace (" ", "+", $aim1); 
                echo("<td><center>$fontString<a href=aim:goim?screenname=$aim&message=Hi.+Are+you+there? >$aim1</a></td>"); 
                }
            if ($site_prefs['dsl'] == 1) 
                echo ("<td><center>$fontString$days</td>"); 

            $tester = mysql_query("select * from online_user where USERid = '$username1'"); 
            if (mysql_num_rows($tester) > 0) 
                $online = "Yes"; 
            else 
                $online = "No"; 
            echo "<td><center>$fontString$online</td></TR>"; 
            $num_mems++; 
            $officers++; 
            }
        } 
    } // proceed to the next person

} // start processing the next level
?>

One final question: Why are you using extract($row1);? You are not using the variables that are extracted, but keep referring to them in the $row1 array.

HTH

[VooDooRT]

That sounds great, but I still want the person who gets demoted to show up, only at the new rank.

[VooDooRT]

Actually, that worked perfectly, thanks!!!