Simple Problem with dir list + while loop

Discord

Hey guys i'm trying to display the contents of a dirrectory that contains all images in a sort of gallery. Here is the current code i'm using. But for some reason if i have 3 images in the dirrectory i get them listed 2 times or more and i'll have a huge list of repeats. What am i doing wrong?

	<?php


$dir_name ="accounts/" . $memname . "/" ;
$dir = opendir($dir_name);
$file_list = "";
while ($file_name = readdir($dir)) {
	if (($file_name != ".") && ($file_name != "..")) {
		$file_list .= "<IMG SRC='accounts/" .$memname . "/" . $file_name . "' BORDER=0><BR><BR>";
		echo $file_list;
	}
}

closedir($dir);

?>

Discord

oh i'm so dumb... nm i need to move the echo outside the loop...

duhhh
smacks self with php manual

tekky

could be this...
[from php.net]

/ This is the correct way to loop over the directory. /
while (false !== ($file = readdir($handle))) {
echo "$file\n";
}

and I would suggest if you set vars to use them to keep things simple....

$dir_name ="accounts/" . $memname . "/" ;
.....
file_list .= "<IMG SRC='$dir_name.$file_name'............

instead of the long version you did...

hehe and yah your 2nd post is right too 😉