global isn't working

[Cagez]

Ok, staring at this screen for the past 24 hours must have made me gone crazy, 'cuz I seriously can't see what the problem is lol

icons.php

$icons = array(array('src' => 'images/folder1.gif', 'days' => 0, 'alt' => 'Today'),
               array('src' => 'images/folder2.gif', 'days' => 3, 'alt' => '1-3 Days'),
               array('src' => 'images/folder3.gif', 'days' => 6, 'alt' => '4-6 Days'),
               array('src' => 'images/folder4.gif', 'days' => 7, 'alt' => '7+ Days'));

function getIcon($info)
{
    global $icons;

$date_diff;

if(is_array($info))
{
    $date_diff = $info;
}

else
    $date_diff = dateDiff($info);

foreach($icons as $icon)
{
    if($date_diff['days'] <= $icon['days'])
    {
        return '<img src="'.ROOT_DIR.$icon['src'].'" width="36" height="37" alt="'.$icon['alt'].'" />';
    }
}
}

Warning: Invalid argument supplied for foreach() in ......../includes/functions/icons.php on line 23

23 is the foreach. 😕

[tekky]

I pasted your code into my site... and it worked fine... I just removed the img tag since I dont have the images.....

<?
$icons = array(array('src' => 'images/folder1.gif', 'days' => 0, 'alt' => 'Today'), 
array('src' => 'images/folder2.gif', 'days' => 3, 'alt' => '1-3 Days'), 
array('src' => 'images/folder3.gif', 'days' => 6, 'alt' => '4-6 Days'), 
array('src' => 'images/folder4.gif', 'days' => 7, 'alt' => '7+ Days')); 

function getIcon($info) 
{ 
	global $icons; 
	$date_diff; 
	if(is_array($info)) 
	{ 
		$date_diff = $info; 
	} 
	else $date_diff = dateDiff($info); 
	foreach($icons as $icon) 
	{ 
		if($date_diff['days'] <= $icon['days']) 
		{ 
			return 'img src="'.ROOT_DIR.$icon['src'].'" width="36" height="37" alt="'.$icon['alt'].''; 
		} 
	} 
}
echo getIcon($icons);
?>

seen at: http://tekky.xnet.org/icon.php

[Cagez]

Thats really weird, I've got it set up so I have the function and the icons array in one file. When I need them, I include the icons.php. I did this and it throughs errors, if I put the array into my main global file, it works flawlessly.

[tekky]

Originally posted by Cagez
Thats really weird, I've got it set up so I have the function and the icons array in one file. When I need them, I include the icons.php. I did this and it throughs errors, if I put the array into my main global file, it works flawlessly.

how are you including it? ie: what location in the file...

[Cagez]

I have several other function files, so I have a special function that I pass the name, lets say "icons" to and it includes the icons.php file. Ah, so the array is becoming scoped to my special include function?

[tekky]

I was thinking you were including it after the call to the array maybe... if the file is included into the other file it become part of it along with its variables... either you are setting something up inside a function w/o making it global, or you got a problem with something else in the code....

[Cagez]

I've got, lets say, index.php. Index.php includes global.php which initiates certain stuff and holds my special include function:

function incFunc($names)
{
    $incfunc = array('ICONS' => 'functions/icons.php',
                     'DATES'  => 'functions/dates.php',
                     'GENERAL' => 'functions/general.php',
                    );

if(is_array($names))
{
    foreach($names as $name)
    {
        $name = strtoupper($name);
        foreach($incfunc as $incname => $incfile)
        {
            if($name == $incname)
            {
                include($incfile);
                unset($incfunc[$incname]);
                break;
            }
        }
    }
}

else
{
    $names = strtoupper($names);
    foreach($incfunc as $incname => $incfile)
    {
        if($names == $incname)
        {
            include($incfile);
            unset($incfunc[$incname]);
            break;
        }
    }
}
}

Then if I need some icon and date functions, I call up the my include function and pass it what I need:

incFunc(array("dates","icons"));

So is the array from icons.php getting scoped to just incFunc()?

[tekky]

I think so with that method of doing things...

return the filename with incFunc() that way you can do

include(incFunc(array("date","icons")));

or

$file = incFunc(array("date","icons"));
include($file);

reason being, you are reading the text into the function.... atleast that is how I would assume PHP is "handling" it

[HalfaBee]

I use require() instead of include(), it at least throws and error message if it can't find the file and makes the error more obvious.

HalfaBee

[Cagez]

HalfaBee, can't use require because require includes the code regardless of the if evaluation.

tekky, doing that would basically destroy the use of the function though I understand what you mean.

I fixed the problem by putting "global $icons" at the top of icons.php. Works like a charm.

[tekky]

glad it works by would would returning the filename render the function useless?

[Cagez]

Returning the file name and manually typing "include" and not being able to process arrays would kill the whole point I made the function.

Thanks for all your help btw 🙂

[tekky]

no prob, although I would dissagree with having to type 1 line of code to make something work 😉

[Cagez]

Its not just that though, I wouldn't be able to process an array either.