OUr favorite error "Cannot modify header information - headers already sent by "

ldd76

Hi all,

I am using PHP Version 4.3.1 on IIS5.1

I am trying to do a search on a database for a string of text.
If the string of text is found, a php script is called like this
header("Location: printUserTable.php");

however if the string of text is found, I get this error:

Warning: Cannot modify header information - headers already sent by (output started at d:\inetpub\wwwroot\EDetails.php:23) in d:\inetpub\wwwroot\EDetails.php on line 207

I did a search for this error and found out that I cannot have any space or line feed on the <?php ?> which I don't have.

Can any one advise?

Here is a segment of my code>>
<?php
session_start();
$my_session_variable = "hello";
session_register("my_session_variable");
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

.....
........
.......

print("Format of IC number is incorrect. Please check again");
else{
$result = searchByIC($ic_search);
if($result)
//print("Found!");
//include("printUserTable.php");
header("Location: printUserTable.php");
else
print("Not Found!");
}

Thanks

paulnaj

Try not putting in the ...

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

or at least leaving it 'til you're sure you're not going to re-direct.

stolzyboy

our favorite, can't put html, comments, anything outputted to browser, etc... before a header() call, problem

superwormy

YOU CANNOT HAVE ANY HTML OR BLANK SPACES OR OUTPUT BY PHP BEFORE CALLING header()!!!

All of this is output BEFORE your call to header(). Get rid of this stuff, you can't put this before you call header().

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

.....
........
.......

print("Format of IC number is incorrect. Please check again");

ldd76

Still the same... I removed all HTML comments and the DOCTYPE line...here is my code segment which I think is alright.
<?php
session_start();
$my_session_variable = "hello";
session_register("my_session_variable");
?>
<html>
<head>
<title>Capture Employee detail</title>
</head>
<body>
<?php
$IC = $POST['txtICNumber'];
$emp_name = $POST['txtName'];
$emp_address = $POST['txtAddress'];
$date_join = $POST['txtDjoin'];
$job_title = $POST['txtJobTitle'];
$dept = $POST['txtDept'];
$sex = $_POST['rdoSex'];

$add = $POST['Insert'];
$ic_find = $POST['ICSearch'];

if(isset ($add) ){

$correct_IC = chkICNo($IC);

if(!$correct_IC)
print("Format of IC number is incorrect. Please check again");

$correct_empName = chkEmpName($emp_name);

if(!$correct_empName)
print("Format of Employee name is incorrect. Please check again");

if(!$emp_address)
print("Employee Address cannot be empty. Please check again");

$correct_dateJoin = chkDateJoin($date_join);

if(!$correct_dateJoin)
print("Format of date is incorrect. Please check again");

$correct_jobTitle = chkJobTitle($job_title);

if(!$correct_jobTitle)
print("Format of Job Title is incorrect. Please check again");

$correct_Dept = chkDept($dept);

if(!$dept)
print("Format of Department is incorrect. Please check again");

if(!$sex)
print("You must specify male or female.");

if($correct_IC && $correct_empName && $emp_address && $correct_dateJoin && $correct_jobTitle && $correct_Dept && $sex){

if(findDuplicate($IC))
print("Duplicate found! Please check your entry");
else
insertRec($IC,$emp_name,$emp_address,$date_join,$job_title,$dept,$sex);

}

function chkICNo($IC){

if($IC && preg_match("/ ^[FS] \d{7} [A-Z]$ /x",$IC,$array))
return true;
else
return false;

}

function chkEmpName($emp_name){

if($emp_name && preg_match("/ ^[a-zA-Z ]+$ /x",$emp_name,$array))
return true;
else
return false;
}

function chkDateJoin($date_join){

if($date_join && preg_match("/ ^{[0-9]{4}-[0-9]{2}-[0-9]{2}} /x",$date_join,$array))
return true;
else
return false;

}

function chkJobTitle($correct_jobTitle){

if($correct_jobTitle && preg_match("/ ^[a-zA-Z ]+$ /x",$correct_jobTitle,$array))
return true;
else
return false;

}

function chkDept($dept){

if($dept && preg_match("/ ^[a-zA-Z ]+$ /x",$dept,$array))
return true;
else
return false;

}

function insertRec($IC,$emp_name,$emp_address,$date_join,$job_title,$dept,$sex){

$IC = addslashes($IC);
$emp_name = addslashes($emp_name);
$emp_address = addslashes($emp_address);
$date_join = addslashes($date_join);
$job_title = addslashes($job_title);
$dept = addslashes($dept);
$sex = addslashes($sex);

$db = mysql_connect("localhost","root","root");

if(!$db){
print("Could not connect to database. Please try again later.");
exit;
}

mysql_select_db("lms");
$query = "INSERT into emp values ('".$IC."', '".$emp_name."', '".$emp_address."', '".$job_title."', '".$date_join."', '".$dept."', '".
$sex."')";
$result = mysql_query($query);

if($result)
echo mysql_affected_rows()." records inserted into database.";

mysql_close($db);
}

function findDuplicate($IC){

$rvalue = false;

$db = mysql_connect("localhost","root","root");

if(!$db){
print("Could not connect to database. Please try again later.");
exit;
}

mysql_select_db("lms");

$result = mysql_query("SELECT icnum from emp");

while ($a_row = mysql_fetch_row($result)){
	foreach ($a_row as $field){
		if((strcmp("$field","$IC")==0)){
		$rvalue = true;
		break;
		}
	}

}

mysql_close($db);

return $rvalue;

}

if(isset($ic_find)){

$ic_search=$_POST['txtICSearch'];

$correct_IC = chkICNo($ic_search);

if(!$correct_IC)
print("Format of IC number is incorrect. Please check again");
else{
$result = searchByIC($ic_search);
if($result)
//print("Found!");
//include("printUserTable.php");
header("Location: printUserTable.php");
else
print("Not Found!");
}

SpanKie

think this is part of the problem..

<html>
<head>
<title>Capture Employee detail</title>
</head>
<body>

superwormy

You are outputting the following before calling header():

Output 1:

<html>
<head>
<title>Capture Employee detail</title>
</head>
<body>

Also, depending on how your error checking comes out... you're outputting all these too:

print("Format of IC number is incorrect. Please check again");

print("Format of Employee name is incorrect. Please check again");

etc., etc.

YOU CANNOT HAVE ANY OUTPUT, NO WHITESPACE, HTML, print() STATEMETNS, echo() statements, ETC. BEFORE A CALL TO header()

benkillin

ok, its said before, but Ill give an explination for it, you cant send and of the file output to the browser before the header command, the header function sends HTTP headers to the browser and can not be re-sent after output is sent, you can avoid this by using output buffering.

superwormy

To expand on that...

The way HTTP works is that it FIRST sends the HTTP headers:
HTTP/1.0 200 OK
Connection: Keep-Alive
Date: Tue, 12 Aug 2003 12:42:07 GMT
Set-Cookie: PREF=ID=386aa34e31953dd3:TM=1060692127:LM=1060692127:S=axJjj4pM2NtR8RpB; expires=Sun, 17-Jan-2038 19:14:07 GMT; path=/; domain=.google.com
Cache-control: private
Content-Type: text/html
Server: GWS/2.1
Content-length: 2690

Then it sends two carriage returns.
( a blank line )

Then it sends the data:
<html>
<head>
etc.
</head>
<body>
etc.
</body>

All a call to header() does is either adds or replaces a line in that first set of text, the HTTP headers. But if you send output first, you'd get something like this:

Set-Cookie: PREF=ID=386aa34e31953dd3:TM=1060692127:LM=1060692127:S=axJjj4pM2NtR8RpB; expires=Sun, 17-Jan-2038 19:14:07 GMT; path=/; domain=.google.com
Cache-control: private
Content-Type: text/html
Server: GWS/2.1
Content-length: 2690

<html>
<head>
etc.
</head>
<body>
Location: http://www.domain.com/page/to/redirect/to.php
etc.
</body>
</html>

Which, OBVIOUSLY, is not what you're trying to do. You NEED to call header() before you do any output so it gets stuck up top with the rest of the HTTP headers.

ldd76

Well still dun work..now my code looks like this...
session variable "ic_search" supposed to have a value I tried to print in printUserTable.php, but nothing is output when that page is called. ic_search is not remembering the variable..

<?php
session_start();
session_register("ic_search");
if(isset($ic_find)){
$ic_search=$_POST['txtICSearch'];
$correct_IC = chkICNo($ic_search);
if(!$correct_IC)
print("Format of IC number is incorrect. Please check again");
else{
//$result = searchByIC($ic_search);
//if($result)
//print("Found!");
//include("printUserTable.php");
header("Location: printUserTable.php");
//else
//print("Not Found!");
}

drawmack

are you still getting the same error? If so then my guess would be that your problems lies in chkICNo();

superwormy

Check and make sure you don't have any whitespace / HTML before that inital <?php tag too. Post an attatchment and we can take a look...

Weedpacket

Originally posted by ldd76
Well still dun work..now my code looks like this...
session variable "ic_search" supposed to have a value I tried to print in printUserTable.php, but nothing is output when that page is called. ic_search is not remembering the variable..

See your other post on this problem.

ldd76

<?php
session_start();
session_register("ic_search");
session_register("ename_search");
?>
<?php
$IC = $POST['txtICNumber'];
$emp_name = $POST['txtName'];
$emp_address = $POST['txtAddress'];
$date_join = $POST['txtDjoin'];
$job_title = $POST['txtJobTitle'];
$dept = $POST['txtDept'];
$sex = $_POST['rdoSex'];

$add = $POST['Insert'];
$ic_find = $POST['ICSearch'];
$ename_find = $_POST['EmpSearch'];

if(isset ($add) ){

$correct_IC = chkICNo($IC);

if(!$correct_IC)
print("Format of IC number is incorrect. Please check again");

$correct_empName = chkEmpName($emp_name);

if(!$correct_empName)
print("Format of Employee name is incorrect. Please check again");

if(!$emp_address)
print("Employee Address cannot be empty. Please check again");

$correct_dateJoin = chkDateJoin($date_join);

if(!$correct_dateJoin)
print("Format of date is incorrect. Please check again");

$correct_jobTitle = chkJobTitle($job_title);

if(!$correct_jobTitle)
print("Format of Job Title is incorrect. Please check again");

$correct_Dept = chkDept($dept);

if(!$dept)
print("Format of Department is incorrect. Please check again");

if(!$sex)
print("You must specify male or female.");

if($correct_IC && $correct_empName && $emp_address && $correct_dateJoin && $correct_jobTitle && $correct_Dept && $sex){

  if(findDuplicate($IC))
  print("Duplicate found! Please check your entry</br>");
  else
  insertRec($IC,$emp_name,$emp_address,$date_join,$job_title,$dept,$sex);

}

}

function chkICNo($IC){

if($IC && preg_match("/ ^[FS] \d{7} [A-Z]$ /x",$IC,$array))
return true;
else
return false;

}

function chkEmpName($emp_name){

if($emp_name && preg_match("/ ^[a-zA-Z ]+$ /x",$emp_name,$array))
return true;
else
return false;
}

function chkDateJoin($date_join){

if($date_join && preg_match("/ ^{[0-9]{4}-[0-9]{2}-[0-9]{2}} /x",$date_join,$array))
return true;
else
return false;

}

function chkJobTitle($correct_jobTitle){

if($correct_jobTitle && preg_match("/ ^[a-zA-Z ]+$ /x",$correct_jobTitle,$array))
return true;
else
return false;

}

function chkDept($dept){

if($dept && preg_match("/ ^[a-zA-Z ]+$ /x",$dept,$array))
return true;
else
return false;

}

function insertRec($IC,$emp_name,$emp_address,$date_join,$job_title,$dept,$sex){

$db = mysql_connect("localhost","root","root");

if(!$db){
print("Could not connect to database. Please try again later.");
exit;
}

if($result)
echo mysql_affected_rows()." records inserted into database.";

mysql_close($db);
}

function findDuplicate($IC){

$rvalue = false;

$db = mysql_connect("localhost","root","root");

if(!$db){
print("Could not connect to database. Please try again later.");
exit;
}

mysql_select_db("lms");

$result = mysql_query("SELECT icnum from emp");

while ($a_row = mysql_fetch_row($result)){
	foreach ($a_row as $field){
		if((strcmp("$field","$IC")==0)){
		$rvalue = true;
		break;
		}
	}

}

mysql_close($db);

return $rvalue;

}

if(isset($ic_find)){

$ic_search=$_POST['txtICSearch'];

$correct_IC = chkICNo($ic_search);

if(!$correct_IC)
print("Format of IC number is incorrect. Please check again</br>");
else{
include("prtUserTableByIC.php");
//header("Location: prtUserTableByIC.php");
}

}

if(isset($ename_find)){

$ename_search=$_POST['txtNameSearch'];

print("$ename_search");

$correct_name = chkEmpName($ename_search);

if(!$correct_name)
print("Format of Employee Name number is incorrect. Please check again</br>");
else{
include("prtUserTableByName.php");
//header("Location: printUserTable.php");
}

}

?>
<html>
<head>
<title>Capture Employee detail</title>
</head>
<body>
</body>
</html>

As can be seen, I commented out the 2 headers line. If I used those 2 lines, the session variables will not retain its values in other pages.

Weedpacket

Try this instead.

stolzyboy

Originally posted by Weedpacket
Try this instead.

He doesn't get it, does he? 🙂