navigation bar

[ravingcommie]

I'm currently trying to make my navigation bar easier and more inline with the functions im attempting to build into my site

My old nave bar consisted of nasty dreamweaver script:

mysql_select_db($database, $bostasp_com);
$querynav = "SELECT * FROM `nav_cat`";
$nav = mysql_query($querynav, $bostasp_com) or die('We currently have some problems with our databases, try back later. <br />Thanks<br />Bostasp Administration'.mysql_error());
$row_nav = mysql_fetch_assoc($nav);
$full_row_nav = mysql_num_rows($nav);

and in the body:

<?php do { ?>
 <a href="<?php echo $row_nav['url']; ?>"><?php echo $row_nav['name']; ?></a><br />    

<?php } while ($row_nav = mysql_fetch_assoc($nav)); ?>
<br />

Currently im trying to shove that in a function, I have the made other functions to get this far, im just a bit stuck on how to make it turn out:

function mainnav() {
    $query = db_query("SELECT * FROM `nav_cat`");
    $nav = mysql_query($query) or die('We currently have some problems with our databases, try back later. <br />Thanks<br />Bostasp Administration<br />'.mysql_error());
    $row_nav = mysql_fetch_assoc($nav);
    $full_row_nav = mysql_num_rows($nav);


##Navigation here 

}

To see what I would like this too look like go to http://www.bostasp.net/new/ for the nav bar there.

Thank you, any help would be greatly appricated.

ravingcommie

[slick]

In your function, loop through the results, and each time you fetch a row, print the link, e.g.:

function mainnav() { 
    $query = db_query("SELECT * FROM `nav_cat`"); 
    $nav = mysql_query($query) or die('We currently have some problems with our databases, try back later. <br />Thanks<br />Bostasp Administration<br />'.mysql_error()); 
    //$row_nav = mysql_fetch_assoc($nav); 
    //$full_row_nav = mysql_num_rows($nav); 


##Navigation here 
while($row=mysql_fetch_array($nav)){
    $linkURL = $row['url'];
    $linkName = $row['name'];
    echo("<a href='$linkURL'>$linkName</a><br>"); 
} 
}

[ravingcommie]

I have tried that, and although it looks as though it should work, when tried in my page it get the following thrown at me:

You have an error in your SQL syntax near 'Resource id #3' at line 1

If i try it on its own, with a few required objects:

You have an error in your SQL syntax near 'Resource id #2' at line 1

I'm stumped 😕

[slick]

The name of your table should not be enclosed in quotes in the query, that is:
$query = db_query("SELECT * FROM nav_cat");

not

$query = db_query("SELECT * FROM nav_cat");

Other than that, I can't see what else could be wrong. Do you have terminal access to the mysql database? Or even phpMyAdmin? I find that using these tools can often clear up or eliminate dodgy queries.

Slick

[ravingcommie]

i get the same error after getting rid of the quotes in the query.

the thing is i don't have anything called resource id #2 or #3 in any of the scripts, not even anything called resource, nor in the database...

utterly confused, but thanks all the same

ravingcommie

[ravingcommie]

Ok, I fixed it, and now have this

db_connect();

function mainnav() {
$query = "SELECT * FROM nav_cat";
$nav = mysql_query($query) or die('We currently have some problems with our databases, try back later. <br />Thanks<br />Bostasp Administration<br />'.mysql_error());
//$row_nav = mysql_fetch_assoc($nav); 
//$full_row_nav = mysql_num_rows($nav); 
while($row=mysql_fetch_array($nav)){ 
    $linkURL = $row['url']; 
    $linkName = $row['name']; 
    echo("<a href='$linkURL'>$linkName</a><br />");  
	}  
}

I just removed the db_query function which was the problem from the script, althought i would have like to use it:

function:

## start query 
function db_query($query) {
	$recordset = mysql_query($query) or die("Sorry, but there is a problem with our database. Please try again later<br />Bostasp Administration Team<br /><br />".mysql_error()."");

return $recordset;
}

does anyone have any ideas how to improve that?

thanks alot

ravingcommie

[slick]

Is there a particular reason why you have wrapped the mysql database query into another database query function? Is it for later database abstraction?

[ravingcommie]

not really, maybe i should just stick to basics... stop making hard for myself...

thanks all the same

[ravingcommie]

How would I go about putting the following:

<?php do { ?>
 <table width"100%" border="0" cellpadding="3" cellspacing="0">
 <tr>
 <td width="570" class="news-title"><?php echo $row_nav_news['title']; ?></td>
 </tr><tr>
 <td class="news-date"><?php echo $row_nav_news['author'];?> - <?php echo $row_nav_news['date']; ?> - <?php echo $row_nav_news['time']; ?></td>
 </tr><tr>
 <td class="news-body"><?php echo $row_nav_news['body']; ?></td>
 </tr></table>
 <?php } while ($row_nav_news = mysql_fetch_assoc($nav_news)); ?>

Into this function:

function mainnews() {
	$news = "SELECT * FROM bosnews ORDER BY bosnews.id DESC";
    $nav_news = mysql_query($qunews) or die('We currently have some problems with our databases, try back later. <br />Thanks<br />Bostasp Administration <br >'.mysql_error());
	$row_nav_news = mysql_fetch_assoc($nav_news);
    $full_row_nav_news = mysql_num_rows($nav_news);
	}

so I could just call up the function and the news is displayed

[slick]

Basically, in the while loop for going through the result set, echo the table rows (the <tr>s and <td>s). In your main script, write the <table>, then call the function and then close </table>

For example:

function mainnews() { 
    $news = "SELECT * FROM bosnews ORDER BY bosnews.id DESC"; 
    $nav_news = mysql_query($qunews) or die('We currently have some problems with our databases, try back later. <br />Thanks<br />Bostasp Administration <br >'.mysql_error()); 
    //$row_nav_news = mysql_fetch_assoc($nav_news); 
    //$full_row_nav_news = mysql_num_rows($nav_news); 
    while($row=mysql_fetch_array($nav_news)){
       $author = $row['author'];
       $body = $row['body'];
       $title = $row['title'];
       $date = $row['date'];
       $time = $row['time'];

   echo("<tr><td width=\"570\" class=\"news-title\">$title</td></tr>");
   echo("<tr><td class=\"news-date\">$author - $date - $time</td></tr>");
   echo("<tr><td class=\"news-body\">$body</td></tr>");
}
}

echo("<table width\"100%\" border=\"0\" cellpadding=\"3\" cellspacing=\"0\"> ");
mainnews();
echo("</table>");

[ravingcommie]

working perfectly... thanks alot.

just need to sort out the backend admin and users now...

thanks

ravingcommie