Showing Pictures

linusx007

Hello,

I have a website running 4.3.0 with MySQL 3.23.52. This website allows the administrator to upload images to the database then they get displayed from another page.

This was working up until a couple of days ago. I don't know what went wrong. I upgraded PHP to 4.3.0 but I think I did this before this happen. The Page is not displaying any errors, its just not showing the picture.

Below is the code I use to fetch the data and display it.

<?
include_once("main.class.php");
$m = new MAIN;

if($id)
{
$query = "select bin_data_front, filetype_front from wa_pictures where id=$id";
$result = $m->query($query);

    $data   = @mysql_result($result,0,"bin_data_front");
    $type   = @mysql_result($result,0,"filetype_front");

    Header( "Content-type: text/html");
    print $data;

}
?>

This was working. So I don't know what would have gone wrong. If you would like to see the site, its here: http://www.wrapartbymichele.com and go into Samples and look around. None of the images get shown.

Thanks for all the help ( if anyone can answer this ).
Bill Van Pelt.

drawmack

Originally posted by linusx007
$type = @mysql_result($result,0,"filetype_front");

Header( "Content-type: text/html");

trye this instead
Header("Content-type:" . $type);

stolzyboy

most likely a register_globals = Off problem, either change your code to use $POST[''] for forms posted, or $GET[''] for forms using get and when passing thru the query string, like you are

use those methods instead of stuff like

if ($id)

use something like

if ($_GET['id'])

linusx007

Hello,

The id is showing up: http://www.wrapartbymichele.com/front_image.php?id=117 and I tried to change the "Content-type: " . $type also with no luck.

Thanks.

stolzyboy

what does your code look like to display the image, ie your <img> tag

linusx007

linusx007

http://www.wrapartbymichele.com/pictures/index.php?cat=15#

retro_a

If you access any one of the images directly (such as by going to http://www.wrapartbymichele.com/front_image.php?id=137), you'll find your error.

Instead of outputting an image (as would be expected), you get your PHP error:

Warning: Cannot modify header information - headers already sent by (output started at /usr/home/sites/www.wrapartbymichele.com/htdocs/front_image.php:7) in /usr/home/sites/www.wrapartbymichele.com/htdocs/front_image.php on line 14

followed by the random text jibberish that is your image. The browser is trying to render the image, but since your PHP error message is embeded within the image encoding, it can't do it.

Fix this problem by making sure you are not sending any output before you use the header() fuction in your front_image.php script.

linusx007

Hello,

I am. The reason there is text coming before the headers is because I want to show the previous poster that the $id was being sent to the script.

Thanks.

stolzyboy

you could always put

<?
ob_start();
?>

at the top of the script also, that will suppress the header errors

Weedpacket

If you send text or HTML you'll need a Content-Type header that says so; if you sent an image you'll need a Content-Type header that says that.

And you can't go mixing them. You either send one or the other. Not both. If you send a text or HTML Content-Type header you'll get the ID number and a pile of gibberish which is your image data; and if you send an image Content-Type you'll get a corrupted image because of that stray ID number there.