Ereg search for '?'...

[Yari]

I am trying to setup a simple search on each of my pages to stop any search engines from reading pages with a '?' in the url...

I have the code right, as I checked it for another search term such as 'does this string contain "index.php"' etc. But the search doesn't work with the question mark '?'.

Is this is because its a variable/symbol that php uses, so you can't use it in a search term?

I tried adding slashes etc to the '?', but no luck.

Please help!

bye

[ctimmer]

Can you show us some of your code?

[Hawk2005]

Check this out.

$url = "http://www.checkthisout.search/index.php?name=john&pass=idontknow";

if (preg_match ("/\?/", $url))
	echo "? found.<br>";
else
	echo "? not found.<br>";

if (ereg ("\?", $url))
	echo "? found.<br>";
else
	echo "? not found.<br>";

Think that'll help. ereg() is said to be faster ?!?

[Yari]

Hmm, thanks guys, but its still not working...

here's some code:

$tmp_url="$REQUEST_URI";
if (preg_match("/?/",$tmp_url)) echo "meta name=\"robots\" content=\"noindex,nofollow\">\n"; else echo "meta name=\"robots\" content=\"index,follow\">\n";

OR

$tmp_url="$REQUEST_URI";
if (ereg("?",$tmp_url)) echo "meta name=\"robots\" content=\"noindex,nofollow\">\n"; else echo "meta name=\"robots\" content=\"index,follow\">\n";

Both don't work.... I think its the damn '?' mark that's having an issue with PHP.

Thanks for you help so far...

[HalfaBee]

This worked fine for me

<?
$tmp_url="$REQUEST_URI";
if (ereg("\\?",$tmp_url))
    echo "meta name=\"robots\" content=\"noindex,nofollow\">\n";
else
    echo "meta name=\"robots\" content=\"index,follow\">\n";
?>

[Hawk2005]

???? The Forum kicked the backslahes out ????

Here it is:

$url = "http://www.checkthisout.search/index.php?name=john&pass=idontknow"; 

if (preg_match ("/\\?/", $url)) 
    echo "? found.<br>"; 
else 
    echo "? not found.<br>"; 

if (ereg ("\\?", $url)) 
    echo "? found.<br>"; 
else 
    echo "? not found.<br>";

Another Question: $_SERVER['REQUEST_URI'];$REQUEST_URI and getenv() won't work with me:

I'm using PHP Version 4.3.2. Did they drop this var ?

[Hawk2005]

Now this works for me:

if ($_SERVER['QUERY_STRING']) 
	echo "meta name=\"robots\" content=\"noindex,nofollow\">\n"; 
else 
	echo "meta name=\"robots\" content=\"index,follow\">\n";

[Yari]

Thanks alot, thats a wonderful bit of lateral thinking, and it works!

Cheers,

[Weedpacket]

For what it's worth, using preg_match (or the slower ereg) to find a single literal character is serious overkill. The strstr or strpos functions would have been better choices.

[Hawk2005]

Because strstr() returns a string which uses more memory and the if-statement is slower with strings than with bool.

Just joking....

I don't think using these for a single character would be overkill.

Either of these 4 func would do.