[Resolved] Case statement

jakeone

I'm trying to use the following:

switch($new_t1)
case "D","W":
if ($new_p1<1 OR $new_p1>30) {
$t1_errMsg = "The number of billing cycle days/weeks must be between 1 and 30";
}
break;

but received an error stating, "unexpected T_CASE, expecting ':' or '{' "

I assume case "D","W": is what's causing the problem. Do I have to treat these as separate case statements? If so, it seems rather inefficient.

cassius

What is your purpose? ...maybe there's a better way to solve your problem.

Why do you want to cases to do the same work???

Try including a default-case as well(default🙂 if you haven't done it allready, and encapsulate your switch-case in bracelets {}

cassius

switch(@$new_t1) {

case "D":
		if ($new_p1<1 OR $new_p1>30) { 
			$t1_errMsg = "The number of billing cycle days/weeks must be between 1 and 30"; 
			} 
		break; 

case "W": 	if ($new_p1<1 OR $new_p1>30) { 
			$t1_errMsg = "The number of billing cycle days/weeks must be between 1 and 30"; 
			} 
		break; 

 default:                                                 

        	include("something.php");

}

Norman_Graham

Originally posted by jakeone
but received an error stating, "unexpected T_CASE, expecting ':' or '{' "

I assume case "D","W": is what's causing the problem.

Error messages containing the phrase 'unexpected thingummybob on line n' always means the same thing - a syntax error, i.e. you forgot something on the previous line. In this case a curly bracket.

HTH

Norman

yelvington

You're missing the obvious answer.

Read the manual page for switch().

It says: "The statement list for a case can also be empty, which simply passes control into the statement list for the next case."

The correct construction is

switch($new_t1)
   case "D":
   case "W":
      if ($new_p1<1 OR $new_p1>30) {
          $t1_errMsg = "The number of billing cycle days/weeks must be between 1 and 30";
          }
      break;

jakeone

Thanks for the replies, especially Norman and Yelvington - I implemented both your suggestions and the code works now. Cheers.