str_replace won't work

Smiler

I've been puzzuling over this for hours now. I've written the following code.

      $smiliefile = fopen('smilies.csv', 'r');
        while ($smilies = fgetcsv($smiliefile, 30)) {
            $str1 = $smilies['1'];
            $str2 = $smilies['0'];
            $comment = str_replace($str1, "<img src=\"http://messenger.msn.co.uk/Resource/emoticons/{$str2}\" alt=\"{$str1}\">", $comment);
        }

As far as I can tell this should work perfectly! This isn't the first time I've had a problem with str_replace. I can't seem to get it to work with a variable string. In other words I have to type a variable in quotes to get it to work. Eg:

str_replace("this string","that string","this is that string");

I'm running on a server with PHP 4.0.0.

superwormy

Try contatinating strings instead of embedding them:

"<img src="/blab/{" . $str1 . "}"

Smiler

I've tried that now, but it's still not working. I don't think it's a problem with the replace string, but a problem with the search string. There are several occurences of the search strings in what is being parsed, but they just stay the same. Even if the replace string were wrong, I'd just end up with each search string replaced with rubbish (which is better than nothing!)
Here's to code as it stands now:

      $smiliefile = fopen('smilies.csv', 'r');
        while ($smilies = fgetcsv($smiliefile, 30)) {
            $str1 = $smilies['1'];
            $str2 = $smilies['0'];
            $comment = str_replace($str1, '<img src="http://messenger.msn.co.uk/Resource/emoticons/' . $str2 . '" alt="' . $str1 . '">', $comment);
        }

Weedpacket

Here's a question: are you sure $smilies[0] (or, rather, $smilies['0'] as you seem to have decided to call it) and $smilies[1] have the values you think they do?

Smiler

They certainly are. I've modified the code to display the contents of $str1 and $str2 when it reads them. It's deisplaying exactly what I expected it to.

Weedpacket

I'm left shrugging and guessing that maybe $comment is the wrong variable to be replacing in. Or it's the right one and the wrong one is being displayed.