Undefined variable error

TweetyPie

im getting the following notice error in the browser:

Notice: Undefined variable: username in C:\Inetpub\wwwroot\disso\index2.php on line 35

Im using PWS, this is the PHP code:

<?
include 'db_param.php';
include 'common.php';
include 'header.inc.php';

error_reporting(E_ALL);

?>

<html>
<head>
<basefont face="Verdana" size="2">
</head>

<body bgcolor=white>

<br>
<p>To enter you must have <b><font color=red>correct</font></b> login details!</p>

<form method=post action="<? echo $_SERVER['PHP_SELF']; ?>">
<table align=center cellpadding=2 cellspacing=0 border=0>
      <td>User name:</td>
      <td><input type="text" name="username" size=10></td><tr>
<td>Password:</td><td><input type="password" name="password" size=10></td><tr>
<td>&nbsp;</td><td><input type="submit" name="submit" value="Log In"></td>
</table></form>


<?

if (isset($_POST['submit'])){
$link = mysql_connect($db_h, $db_u, $db_p) or exit ("Could not connect !");
mysql_select_db($db) or exit ("Could not connect to database");

$sql="select * from users where name= '$username'";          [THIS IS LINE 35]
$query=mysql_query($sql) or die ("Unable to execute query!");

while ($row=mysql_fetch_array($query)) {
if ($row["password"]==$password) {
 echo "Successfully Logged In! <a href=admin.php>Click Here</a>";
}
}
}
  ?>

Can someone plz point out where the problem is? what do i need to change or add? ive looked at register globals and i dont understand it.

stolzyboy

change this

$sql="select * from users where name= '$username'";

to this

$sql = "select * from users where name = '" . $_POST['username'] . "';";

TweetyPie

Thanks! that seemed to make that work, but now i have the same problem with the password

Notice: Undefined variable: password in C:\Inetpub\wwwroot\disso\index2.php on line 39

line 39 is this:

if ($row["password"]==$password) {

SP8600

You have register globals swiched on, therefor you must have it like this:

If info is posted = $POST['YOUR_VAR']
If info is in the address bar = $GET['YOUR_VAR']

There are more of them but you can find them at php.net

stolzyboy

Originally posted by SP8600
You have register globals swiched on, therefor you must have it like this:

If info is posted = $POST['YOUR_VAR']
If info is in the address bar = $GET['YOUR_VAR']

There are more of them but you can find them at php.net

actually if you have register_globals = Off is when you need to use $_POST['var_from_form']

if it is On, you can then use the $variablename

so change

if ($row["password"]==$password) {

if ($row["password"] == $_POST['password']) {

TweetyPie

THANKS SO MUCH!

it now works! im so greatfull for your help! thanks

TweetyPie

I have query about this file, it executes to the error.php file, from line 8. does this mean that the variable is retuning a false? from line 5? therfore the file dosent upload and executes to the error.php file? I have this same problem with a few others, what do i need to change?


<?
include 'db_param.php';
include 'common.php';

if (!isset($jnum) || $jnum == "")              [THIS IS LINE 5]
{
header("Location:error.php");
exit;                        [THIS IS LINE 8]
}


// open link
$link = mysql_connect($db_h, $db_u, $db_p) or exit ("Unable to connect!");
mysql_select_db($db) or exit ("Could not connect to database");

$sql = "SELECT job.j_title, job.j_num, depart.dep, location.location, salary.salary, job.j_resp, job.j_req, job.j_cont, job.cont_mail, job.posted from job, depart, location, salary WHERE depart.d_id = job.depart AND location.l_id = job.location AND salary.s_id = job.salary AND job.j_num = '$jnum'";
$query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());


if (mysql_num_rows($query) <= 0)
{
header("Location:error.php");
exit;
}
else
{

list($jtitle, $jnum, $department, $location, $salary, $jresp, $jreq, $jcont, $contmail, $posted) = mysql_fetch_row($query);

// close link
mysql_close($link);
?>

<? include 'header.inc.php'; ?>
 <br>
<!-- print job details -->
<b>Job Title:</b> <? echo $jtitle; ?>
<p>
<b>Job number:</b> <? echo $jnum; ?>
<p>
<b>Department:</b> <? echo $department; ?>
<p>
<b>Location:</b> <? echo $location; ?>
<p>
<b>Salary:</b> <? echo $salary; ?>
<p>
<b>Responsibilities:</b> <? echo $jresp; ?>
<p>
<b>Qualifications:</b> <? echo $jreq; ?>
<p>
<b>Contact:</b> <a href=mailto: <? echo $contmail; ?> <? echo $jcont; ?></a>
<p>
<b>Posted on:</b> <? echo form_d($posted); ?>
<p>

[/SIZE]

stolzyboy

probably same thing, take my advice, when you are getting information from a form, use the

$_POST['variablename'] way instead of $variablename

TweetyPie

ok, so will i change

if (!isset($jnum) || $jnum == "")

if (!isset($_POST[jnum]) || $_POST[jnum] == "")

Is that in the right place?

It gives me an error.

stolzyboy

i would make it this

if ($_POST['jnum'] == "")

and what is the error, where is jnum coming from

TweetyPie

that doesnt work, The error is the following displayed in the browser:

Notice: Use of undefined constant jnum - assumed 'jnum' in C:\Inetpub\wwwroot\disso\jobs2.php on line 6

Warning: Cannot modify header information - headers already sent by (output started at C:\Inetpub\wwwroot\disso\jobs2.php:6) in C:\Inetpub\wwwroot\disso\jobs2.php on line 8

stolzyboy

check my post again i edited it

and where is the jnum coming from, a form, query string, etc...

and the header error is caused cuz you can't have anything output to the screen before calling the header function, ie html, php outputting html, comments, etc...

TweetyPie


<?
include 'db_param.php';
include 'common.php';

if (!isset($_jnum) || $jnum == "")
{
header("Location:error.php");
exit;
}
[THIS EMPTY LINE IS LINE 10]

// open link
$link = mysql_connect($db_h, $db_u, $db_p) or exit ("Unable to connect!");
mysql_select_db($db) or exit ("Could not connect to database");

$sql = "SELECT job.j_title, job.j_num, depart.dep, location.location, salary.salary, job.j_resp, job.j_req, job.j_cont, job.cont_mail, job.posted from job, depart, location, salary WHERE depart.d_id = job.depart AND location.l_id = job.location AND salary.s_id = job.salary AND job.j_num = '$jnum'";     [THIS IS LINE 16]
$query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());


if (mysql_num_rows($query) <= 0)
{
header("Location:error.php");
exit;
}
else
{

list($jtitle, $jnum, $department, $location, $salary, $jresp, $jreq, $jcont, $contmail, $posted) = mysql_fetch_row($query);

// close link
mysql_close($link);
?>

TweetyPie

jnum is from a form

I dont know why the header error is there? theres nothing before it.

stolzyboy

nothing is output in these two files

include 'db_param.php';
include 'common.php';

TweetyPie

the include 'db_param.php'; file has the connection details in it:

<?php

$db="db";
$db_h = "localhost";
$db_u = "username";
$db_p = "hello";
?>

and include 'common.php';

<?

function err()
{

global $errorList;


echo "<b>The following errors have ocurred: <b><br>";
echo "<ul>";
        for ($x=0; $x<count($errorList); $x++)
        {
        echo "<li>$errorList[$x]";
        }
echo "</ul>";

echo "Go <a href=javascript:history.back();>back</a> to correct them? ";
}


function mail_check($val)
{
        $pmat = "/^([a-zA-Z0-9])+([\.a-zA-Z0-9_-])*@([a-zA-Z0-9_-])+(\.[a-zA-Z0-9_-]+)+/";

            if(preg_match($pmat, $val))
            {
            return 0;
            }
            else
            {
            return 1;
            }
}

?>

stolzyboy

try taking this line out

error_reporting(E_ALL);

TweetyPie

that line isnt in this file.

stolzyboy

aarrrgghhh, t'was looking at the other file you were working with

take out the comment line

// open link

or whatever it says, and cinch up the line breaks and try and
get rid of all whitespace

TweetyPie

there are no white spaces, and i did as you said, it now executes to the error.php file like it did before. This then displays:

Unfortunately an error has occured! Please follow the link back to the main page to try again

which is an error msg from the error.php file.

<?
include 'db_param.php';
include 'common.php';
if (!isset($_jnum) || $jnum == "")
{
header("Location:error.php");
exit;
}
$link = mysql_connect($db_h, $db_u, $db_p) or exit ("Unable to connect!");
mysql_select_db($db) or exit ("Could not connect to database");
$sql = "SELECT job.j_title, job.j_num, depart.dep, location.location, salary.salary, job.j_resp, job.j_req, job.j_cont, job.cont_mail, job.posted from job, depart, location, salary WHERE depart.d_id = job.depart AND location.l_id = job.location AND salary.s_id = job.salary AND job.j_num = '$jnum'";
$query = mysql_query($sql) or exit ("Error in query: $sql. " . mysql_error());
if (mysql_num_rows($query) <= 0)
{
header("Location:error.php");
exit;
}
else
{
list($jtitle, $jnum, $department, $location, $salary, $jresp, $jreq, $jcont, $contmail, $posted) = mysql_fetch_row($query);
mysql_close($link);
?>
<? include 'header.inc.php'; ?>
 <br>
<!-- print job details -->
<b>Job Title:</b> <? echo $jtitle; ?>
<p>
<b>Job number:</b> <? echo $jnum; ?>
<p>
<b>Department:</b> <? echo $department; ?>
<p>
<b>Location:</b> <? echo $location; ?>
<p>
<b>Salary:</b> <? echo $salary; ?>
<p>
<b>Responsibilities:</b> <? echo $jresp; ?>
<p>
<b>Qualifications:</b> <? echo $jreq; ?>
<p>
<b>Contact:</b> <a href=mailto: <? echo $contmail; ?> <? echo $jcont; ?></a>
<p>
<b>Posted on:</b> <? echo form_d($posted); ?>
<p>