INSERT INTO registration script problem

[notaloser]

I have this registration script:

<?PHP

if($HTTP_POST_VARS['submit']) {

mysql_connect("localhost","root","pass")
or die ("<div align=center><span class=text>Unable to connect to the database. Try again later.</span></div>");

mysql_query("INSERT INTO users ( user_name, user_pass, user_email, user_aimaol, user_msn, user_icq ) VALUES (  '$username',  '$userpass',  '$useremail',  '$useraimaol',  '$usermsn',  '$usericq' ) ")   

or die ("<div align=center><span class=text>Unable to create user.  Try again later.</span></div>");


if (!$username || !$userpass || !$confirmp || !$useremail || !$useraimaol || !$usermsn || !$usericq)

{

echo '<div align=center><span class=text>You have not entered all the fields. Please go back and fix the missing fields.</span></div>';

exit;

}

Else if ($userpass != $confirmp)

{

echo '<div align=center><span class=text>Your passwords do not match</span></div>';

exit;

}
} //end if
?>

Except, I always get the "Unable to create player" die error message.

Why am i getting this message? If i run that query directly on my database it works with the variable names (like under the user_name column is $username which is the name of the username input)

Anyone?

[barand]

Try echoing your query string to see if it looks right. You could have blank variables, maybe.

echo "INSERT INTO users ( user_name, user_pass, user_email, user_aimaol, user_msn, user_icq ) 
VALUES (  '$username',  '$userpass',  '$useremail',  '$useraimaol',  '$usermsn',  '$usericq' ) ";

And instead of your message if it fails, use

die(mysql_error());   

to see what it doesn't like.

[steadyguy]

Your problem is that mysql_query() only returns TRUE or FALSE for SELECT, SHOW, EXPLAIN, and DESCRIBE queries. Your query is an INSERT query, so it won't return anything ... resulting in the failure message every time.

[notaloser]

therefore i should do what?

the echo didnt display an error message but then again didnt save to my database

[steadyguy]

Just run the query. If you need to be sure that everything is inserted properly, your best bet is to run a SELECT query to check for the results you just entered. If THAT returns FALSE ... then you know it wasn't successful. The SELECT query would also allow you to ouput the results to the user on a confirmation screen or in an email.

[notaloser]

yeah, i plan to do it in an email, but the thing is, i use phpmyadmin and after i submit it, i go into my db with phpmyadmin and there is no new rows or anything different... therefore implying that something is wrong

[steadyguy]

The query is syntactically correct. Is the connection -- Oh ... I don't know why I didn't see it before. You need to select a database:

mysql_select_db('dbName');

[notaloser]

i dont get it, nothing is working:

<?PHP

if($HTTP_POST_VARS['submit']) {

mysql_connect("localhost","root","pass")
or die ("<div align=center><span class=text>Unable to connect to the database. Try again later.</span></div>");

mysql_select_db('root'); 

echo "INSERT INTO users ( user_name, user_pass, user_email, user_aimaol, user_msn, user_icq ) VALUES ( '$username', '$userpass', '$useremail', '$useraimaol', '$usermsn', '$usericq' ) "
or die ("<div align=center><span class=text>Unable to create user.  Try again later.</span></div>");



if (!$username || !$userpass || !$confirmp || !$useremail || !$useraimaol || !$usermsn || !$usericq)

{

echo '<div align=center><span class=text>You have not entered all the fields. Please go back and fix the missing fields.</span></div>';

exit;

}

Else if ($userpass != $confirmp)

{

echo '<div align=center><span class=text>Your passwords do not match</span></div>';

exit;

}
} //end if
?>

nothing is creating that one little row.

not only is nothing working, but i dont get a die error message or anything, along with a random 1 popping up in front of my username input

[notaloser]

anyone?

[steadyguy]

You need to use mysql_select_db() , but must still run the query with mysql_query()

if (mysql_connect("localhost","root","pass")) {
    mysql_select_db('root'); 
    mysql_query($queryString);
}
else 
    print "Couldn't connect!";

[examancer]

shouldn't you be checking the variable contents BEFORE you run the query?

it should be in this order:

if($HTTP_POST_VARS['submit']) {

mysql_connect("localhost","root","pass")
or die ("<div align=center><span class=text>Unable to connect to the database. Try again later.</span></div>");

mysql_select_db('root'); 

if (!$username || !$userpass || !$confirmp || !$useremail || !$useraimaol || !$usermsn || !$usericq)

{

echo '<div align=center><span class=text>You have not entered all the fields. Please go back and fix the missing fields.</span></div>';

exit;

}

Else if ($userpass != $confirmp)

{

echo '<div align=center><span class=text>Your passwords do not match</span></div>';

exit;

}

echo "INSERT INTO users ( user_name, user_pass, user_email, user_aimaol, user_msn, user_icq ) VALUES ( '$username', '$userpass', '$useremail', '$useraimaol', '$usermsn', '$usericq' ) "
or die ("<div align=center><span class=text>Unable to create user.  Try again later.</span></div>");

} //end if 

[notaloser]

thanks so much i got it working