login script error

notaloser

I have:

<?
session_start();

$db_name = "root";
$table_name = "users";

mysql_connect("localhost", "root", "pass") 
or die("Couldn't connect to the database.  Try again later.");

mysql_select_db($root)
or die("Couldn't select database.  Try again later.");

$sql = "SELECT * FROM $users
    WHERE user_name = \"$username\" AND password = user_pass(\"$userpass\")
    "; 

$result = mysql_query($sql) 
        or die ("Can't execute query."); 

$num = mysql_numrows($result); 

if ($num != 0) { 

session_register('userok');

$userok = "yes";

$msg = "<div align=center><span class=text>Thanks for logging in.  Please wait...</span></div>";

header("Location: [url]http://my[/url] url");
exit;

} else { 

echo '<div align=center><span class=text>Username/Password Problem.  Please try again.</div></span>'
}

?>

I get an error saying

Parse error: parse error, expecting ','' or';'' in my directories/login.php on line 84

line 84 is:


} else {   //81
 //82
echo '<div align=center><span class=text>Username/Password Problem.  Please try again.</div></span>' //83
} //84

paulsbooker

first mistake looks to be this line

mysql_select_db($root)

what is $root ? should that be $db_name ??

similarly for $users ???

kind regards
paul

paulsbooker

because you don't connect to the database you will ultimately hit the else statement at the end of your script which is missing an end of statement character ; resulting in your present error

kind regards
paul

notaloser

I have modified it to be correct but now i get 2 session errors:

<?

session_name(login);
session_start();

$db_name = "root";
$table_name = "users";

mysql_connect("localhost", "root", "pass") 
or die("Couldn't connect to the database.  Try again later.");

mysql_select_db($db_name)
or die("Couldn't select database.  Try again later.");

$sql = "SELECT * FROM $users
    WHERE user_name = \"$username\" AND password = user_pass(\"$userpass\")
    "; 

if ($HTTP_POST_VARS['submit']) {

$result = mysql_query($sql) 
        or die ("<span class=text><div align=center>Can't execute query.</div></span>"); 

$num = mysql_numrows($result); 

if ($num != 0) { 

session_register('userok');

$userok = "yes";

$msg = "<div align=center><span class=text>Thanks for logging in.  Please wait...</span></div>";

header("Location: [url]http://mydomain/index.php[/url]");
exit;

} else { 

echo "<div align=center><span class=text>Username/Password Problem.  Please try again.</div></span>";
}
}
?>

Warning: session_start(): Cannot send session cookie - headers already sent by (output started at directories/login.php:19) in directories/login.php on line 52

Warning: session_start(): Cannot send session cache limiter - headers already sent (output started at directories//login.php:19) in directories/login.php on line 52

like 52 is my session_start()

stolzyboy

take out this line

session_name(login);

cuz session_start(); has to be the first line in the script

stolzyboy

also check your (PM) private message

notaloser

ok i did what you asked, but now i need some help... i still am getting the same error message

stolzyboy

make sure there is NO whitespace, etc... before the session start, any line breaks, etc...

notaloser

i figured that out, and along with an error in the mysql_query which got a bit messy but now its clean. what i need now is to know now is how to make it go to a new page after logging in, this page will be userhome.php and i want each user to have a different home, so basically i think i want it to be userhome.php?id=username.

i got my code:

<?

$db_name = "root";
$table_name = "users";

mysql_connect("localhost", "root", "pass") 
or die("Couldn't connect to the database.  Try again later.");

mysql_select_db($db_name)
or die("Couldn't select database.  Try again later.");

 $sql .= 'SELECT * FROM users WHERE user_name = "notaloser" AND user_pass = "march"';

if ($HTTP_POST_VARS['submit']) {

$result = mysql_query($sql) 
        or die ("<span class=text><div align=center>Can't execute query.</div></span>"); 

$num = mysql_numrows($result); 

if ($num != 0) { 

session_register('userok');

$userok = "yes";


}
}
?>

ive tried header location but i dont think im doing it right.

if someone could give me the header code and tell me where to put it, taht would be great, and give me some tips and ideas on how to make each users userhome.php page origional to them

stolzyboy

header("Location: pagetogo.php?id=$variableofidifyouwant");

notaloser

great another error

Warning: Cannot modify header information - headers already sent by (output started at directories/login.php:22) in directories/login.php on line 79

79 is the header, now whats wrong!

stolzyboy

well then you have whitespace, html output, etc... before your header call, you can't have any of that before the header call

or you can put

ob_start();

right after the session_start();

notaloser

Thanks, i got it working!

notaloser

now the only problem is, if you enter a username and password that doesnt exist, it still brings you to the page it does when you log in correctly, instead of displaying the wrong username/password error...

<?

$db_name = "root";
$table_name = "users";

mysql_connect("localhost", "root", "pass") 
or die("Couldn't connect to the database.  Try again later.");

mysql_select_db($db_name)
or die("Couldn't select database.  Try again later.");

 $sql .= 'SELECT * FROM users WHERE user_name = "$user_name" AND user_pass = "$user_pass"';

if ($HTTP_POST_VARS['submit']) {

$result = mysql_query($sql) 
        or die ("<span class=text><div align=center>Can't execute query.</div></span>"); 

$num = mysql_numrows($result); 

if ($num != 0) { 

header("Location: index.php");

session_register('userok');

$userok = "yes";

}
}
?>

the session_start() and ob_start() are at the top of the page

stolzyboy

you'll have to do some if checking with that like you are, and also, move the code lines after the header() to before them, otherwise, those lines most likely won't get hit