Silly unlink question

[Tj_C]

I am tyring to delete a pdf with unlink and can't do it. In fact even is_file() doesn't see any of my pdf's. Any ideas? Could this be a setting problem? is_file() will recognize .txt files

Thanks in advance for your help

Tj

[Tj_C]

I should have put this up before.

Code I am using. This gets run when the user clicks a link. Code should-
1. open a flat db read in the contents,
2. erase the contents of the db
3. go thru the contents to find the information to remove
4. delete the file associated with that information
5. re-write the contents of the db back to the db
6. call a function that writes the contents of the db to a table in the browser.

all works just as needed except unlink().

Thanks Tj

function delinf($f,$it,$rootPath,$addr) {

if (is_writable($f)) {

    $fArray = file($f);

    if (!$handle = fopen($f, 'w+')) {
         print "Cannot open file ($f) for writing";
         exit;
    }
    reset($fArray);
    while (list($key,$item) = each($fArray)) {

	if ($key == $it) {

		$hol = strtok($item,"|");
		$hol = strtok("|");
		$remove = $rootPath.$addr.$hol;
		unlink($remove);


		unset($fArray[$key]);
		reset($fArray);

	while (list($key,$item) = each($fArray)) {
			$des = strtok($item,"|");
			$fl = strtok("|");

                                       if (!fwrite($handle,$des."|".$fl)) {
     		print "Cannot write to file ($f)";
        			   exit;
   			}
		}

	}

    }

   fclose($handle);
   rfile($f);
} else {
    print "The file $g is not writable";
}

}
//end delete function

[HalfaBee]

There will be a newline at the end of each $item. You probably need to use trim() to strip it off.

HalfaBee

[Tj_C]

Thanks Half,

I can't belive I didn't see that...

tried it and it still didn't work. So here is the new code

function delinf($f,$it,$rootPath,$addr) {

if (is_writable($f)) {

    $fArray = file($f);

    if (!$handle = fopen($f, 'w+')) {
         print "Cannot open file ($f) for writing";
         exit;
    }
    reset($fArray);
    while (list($key,$item) = each($fArray)) {

	if ($key == $it) {

		$hol = strtok($item,"|");
		$hol = strtok("|");
		trim($hol);
		$remove = $rootPath.$addr.$hol;
		unlink($remove);


		unset($fArray[$key]);
		reset($fArray);

		while (list($key,$item) = each($fArray)) {
			$des = strtok($item,"|");
			$fl = strtok("|");

			if (!fwrite($handle,$des."|".$fl)) {
     				   print "Cannot write to file ($f)";
        			   exit;
   			}
		}

	}

    }

   fclose($handle);
   rfile($f);
} else {
    print "The file $g is not writable";
}

}
//end delete function

This is so frustrating, I am sure it is something simple I am missing.

Tj

[HalfaBee]

It is best to post your code inbetween [ PHP] [/ PHP] tags without spaces to make it a bit more readable.

What format is your data in ( an example would be nice )
and what does $it refrer to?

HalfaBee

[Tj_C]

Half,

Sorry about the messy code, first time posting. I have been a loaner until now.

Hmmm... not sure what data your referring to. The file I want to delete? If so it is a pdf. $it is just a number submitted from the html page when the user clicks on the delete button. Let's the script know what file to match to the db.

I did some more paying around, and I think you're right about the prob being the newline character. I just can't remove it. trim() or chop() only seem to hanlde white space.

any suggestions?

Thanks.

Code re-post so it is more readable

function delinf($f,$it,$rootPath,$addr) {

if (is_writable($f)) {

    $fArray = file($f);

    if (!$handle = fopen($f, 'w+')) {
         print "Cannot open file ($f) for writing";
         exit;
    }
    reset($fArray);
    while (list($key,$item) = each($fArray)) {

	if ($key == $it) {

		$hol = strtok($item,"|");
		$hol = strtok("|");

		str_replace("\n","",$hol);  		//tried this instead of trim...didn't seem to work

		$remove = $rootPath.$addr.$hol;
		unlink($remove);


		unset($fArray[$key]);
		reset($fArray);

		while (list($key,$item) = each($fArray)) {
			$des = strtok($item,"|");
			$fl = strtok("|");

	if (!fwrite($handle,$des."|".$fl.$remove)) {
     				   print "Cannot write to file ($f)";
        			   exit;
   			}
		}

	}

    }

   fclose($handle);
   rfile($f);
} else {
    print "The file $g is not writable";
}
}
//end delete function

[Tj_C]

Thanks for all your help Half I got it.

Just needed to do the str_replace() into a var I left it hanging before.

Thanks again for putting me on the right track

Tj

[HalfaBee]

You need

$hol = str_replace("\n","",$hol);

Put in some debug echo "$hol"; and echo "$remove"; to see whats happening.

why are you reseting the array pointer in the middle of the loop?

HalfaBee

[Tj_C]

$hol = str_replace("\n","",$hol);

Is exactly what I did and it fixed it.

I am reseting the pointer so that when I go into loop that writes the new array back to the db, it starts writing at the top of the array.

Is that not necessary? I do want to keep the db in the same order.

Thanks

Tj

[HalfaBee]

It won't make any difference it just looked odd.

Glad you got it going.

HalfaBee