trying to use $foo++ from mysql result

pezkingrich

I'm trying to add one to the 'comment count' when someone submits a comment! The sql error i get is:
You have an error in your SQL syntax near 'INSET INTO users (comments) VALUES ('7') WHERE username='Rich'' at line 1

Code:
$get_comment = mysql_query("SELECT comments FROM users WHERE username='$username'") or die(mysql_error());
$new_comment = $get_comment++;

mysql_query("INSET INTO users (comments) VALUES ('".$new_comment."') WHERE username='$username'") or die(mysql_error());
echo "Comment entered. Thanks!<BR>\n";

The comment value is stored in the databse as an INTEGER. I tried echoing the values, for $new_comment i get '7' and for $get_comment i get 'Resource id #6' . Ahh wht am i doing wrong?! (i manually entered the value 5 for comments).

Sxooter

I think you're confusing insert with update. Since insert creates a NEW row, it doesn't need a where clause, whereas update updates all rows unless there is a where clause.

Assuming the row you want to update already exists, you want:

update users set comments = comments+1 where username='Rich';

pezkingrich

aha i see, you can't use a WHERE clause with INSERT, i meant to use UPDATE. Thanks for the mysql comment+1 , still cant get it to work by adding one in php, but thanks for solving the problem!

tekky

if its a numerical value, try NOT single quoting it... its always errored on me for that... never understood why.... 😕

tomhath

Or you could try spelling INSERT correctly :rolleyes:

mysql_query("INSET INTO users ...

tekky

Originally posted by tomhath
Or you could try spelling INSERT correctly :rolleyes:

LMAO, cant believe I didnt notice that :o

ahundiak

This is why you could not increment in code:
$get_comment = mysql_query("SELECT comments FROM ... blah ...);;
$new_comment = $get_comment++;

You need to fetch a row from the result set then pull the comment counter out of it then increment.

Also, because the ++ is at the end of the variable, $new_comment would have been set to the original value of $get_comment, then $get_comment would have received the new value.