[Resolved] is_file, is_dir problems

[helz]

i want my navigation include to be almost fully automatic, at the moment it opens the already specified dirs and runs out a list of the files within that are put into a link for the user to click on to navigate the site...

but what i want to do now is add the option to check if there is a dir and then if there is to display the files within the new dir...
i know the code i need to use except the is_dir seems to ignore the dirs and if i use is_file it doesnt show anything including the files...

this code tests for all files in the dir: (commented out the is_file if statement)

$dir = "admin/";
echo "<br><br>Files:<br>";
if (is_dir($dir)) {
    if ($dh = opendir($dir)) {
        while (($file = readdir($dh)) !== false) {
			if ( $file != "." && $file  != ".." ){
			//   if (is_file($file)) {
			  echo "<li>Filename:  ".$file."</li>";
			 //  }
			}
        }
    closedir($dh);
    }
}

and here is the code for the dir test (commented out is the is_dir):

$dir = "admin/";
echo "<br><br>Dirs:<br>";
if (is_dir($dir)) {
    if ($dh2 = opendir($dir)) {
        while (($file2 = readdir($dh2)) !== false) {
			if ( $file2 != "." && $file2  != ".." ){
#-------------------------------------------------------------------------
				if (is_dir($file2)) {
					if ($newdir = opendir($file2)) {

					while (($newdir2 = readdir($newdir)) !== false) {
					if ( $newdir2 != "." && $newdir2  != ".." ){
						//if (is_dir{$newdir2}} {
					echo "<li>Dir Name:  ".$newdir2."</li>";
						//}
					}}
				closedir($file2);
				}
			}
#--------------------------------------------------------------------------		
			}
        }
    closedir($dh2);
    }
}

now with the is_file and is_dir commented out, the files part shows this:

Files:

Filename: Edit_Member.php
Filename: News

and the dirs part shows this: (again without the is_file and is_dir)

Dirs:

right so if i enable the is_file and is_dir this is what shows:

Files:


Dirs:

any ideas?

[bad76]

Hi,
i think your problem is the path in new subdir.
When you go in subdir you have to put before the path...
You can try something like this:

$dir = "admin/"; 
echo "<br><br>Dirs:<br>"; 
if (is_dir($dir)) { 
    if ($dh2 = opendir($dir)) { 
        while (($file2 = readdir($dh2)) !== false) { 
            if ( $file2 != "." && $file2  != ".." ){ 
                if (is_dir($file2)) { 
                    if ($newdir = opendir($dir.$file2)) {    // add "admin/" 
                        while (($newdir2 = readdir($newdir)) !== false) { 
                        if ( $newdir2 != "." && $newdir2  != ".." ){ 
                            //if (is_dir{$newdir2}} { 
                        echo "<li>Dir Name:  ".$newdir2."</li>"; 
                            //} 
                        }} 
                    closedir($file2); 
                    } 
                } else echo "<li>File Name:  ".$file2."</li>";  

            } 
        } 
    closedir($dh2); 
    } 
}

see you

[helz]

hmm yea, that would be helpful is the is_dir actually works, its still thinking that the directory News is a file when it isn't

check it out yourself at:
http://bowling.hellrazer.net/test.php

the problem still remains which is the fact that if i use:
is_dir
or
is_file

it doesnt display anything which to me means that the php thinks that both files and directories within the /admin/ folder are counted as non-dirs and non-files.

on the page the dir part is using the addon part from the post above

[bad76]

hmm... any other error, is the first closedir, is not $file2 to close, but $newdir.

However, try this as test:

$dir = "admin/";  

echo "<br><br>Dirs:<br>";  

if ($dh2 = opendir($dir)) {  
    while (($file2 = readdir($dh2)) !== false) {  
        if ( $file2 != "." && $file2  != ".." ){  
            if (is_dir($file2))  
                   echo "<li>Dir Name:  ".$file2."</li>";  
            if (is_file($file2)) 
                   echo "<li>File Name:  ".$file2."</li>";   
        }  
    }  
closedir($dh2);  
}  

If work fine put in a function and call it recursively if is a dir:

$dir = "admin/";  

echo "<br><br>Dirs:<br>";  

function getlistdir($dir)
{
    if ($dh2 = opendir($dir)) {  

        while (($file2 = readdir($dh2)) !== false) {  

            if ( $file2 != "." && $file2  != ".." ){  

                if (is_dir($dir.$file2)) 
                { 
                       echo "<li>Dir Name:  ".$file2."</li>";  

                       getlistdir($dir.$file2."/");
                }
                if (is_file($dir.$file2)) 
                       echo "<li>File Name:  ".$file2."</li>";   

            }  

        }  

    closedir($dh2);  

    }  

}

getlistdir($dir);

May be all this work...

[tekky]

here's a working example....
you can view it -> here

<?
$path = getcwd();
$dir = opendir($path);
while (false !== ($file = readdir($dir)))
{
	if (!is_dir("$path/$file"))
	{
		echo "[file] $path/$file<br>\n";
	}
	else
	{

	echo "[dir] $file<br>\n";
	if ($file == '..' || $file == '.') { continue; }
	$dir2 = opendir("$path/$file");
	while (false !== ($file2 = readdir($dir2)))
	{
		if (!is_dir("$path/$file2"))
		{
			echo "--[file] $path/$file2<br>\n";
		}
		else
		{
			echo "--[dir] $file2<br>\n";
		}
	}
}
}
closedir($dir);
?>

note: the filepaths were clipped in my working example, to protect my servers dir structure, however the difference doesnt affect operation

also note taht this is only designed to go 1 dir deep, I just wanted to test is_dir() more than with 1 dir and it worked great

[helz]

thanks alot for that, in the test page i got it all working like how i wanted it, except in the main site where the exact same code is used it displays the file and the dir as links, exactly not what its meant to do.. 🙁
heres the code in the test.php page

$path = "admin";
echo "<table width=100% border='1' align='center' cellpadding='1' cellspacing='0' bgcolor='#FFFFFF'>
	  <tr><td bordercolor='#000000'><div align='center'><font color='#000000'><b>Navigation</b></font></div></td></tr>";
echo "<tr><td><font color='#000000'><strong>--Admin Menu--</strong></font></td></tr>";
$dir = opendir($path); 
while (false !== ($file = readdir($dir)))
if ( $file != "." && $file  != ".." ){// get rid of . and .. 
{ 
    if (!is_dir("$path/$file")) { 
			  $file4 = basename($file,".php");// get rid of extension for display in menu
			  $filetitle = ereg_replace('_',' ',$file4);// replace underscore with a space
			  echo "<tr><td><font color='#000000'><li><a href='../index.php?incadmin=".$file4."'>".$filetitle."</a></li></font></td></tr>";
    } 
    else 
    { 
     // echo "[dir] $file<br>\n"; //display sub-menu
		echo "<tr><td><font color='#000000'>-------".$file."</font></td></tr>";// output dir as new submenu
//        if ($file == '..' || $file == '.') { continue; } 
        $dir2 = opendir("$path/$file"); 
        while (false !== ($file2 = readdir($dir2))) 
        { 
            if (!is_dir("$path/$file2")) 
            { 
			  $file2 = basename($file2,".php");// get rid of extension for display in menu
			  $filetitle = ereg_replace('_',' ',$file2);// replace underscore with a space

      //    echo "--[file] $path/$file/$file2<br>\n"; //display files within sub-menu 
			echo "<tr><td><font color='#000000'><li><a href='../index.php?incadmin=".$file."/".$file2."'>".$filetitle."</a></li></font></td></tr>";
		/*
        } 
        else 
        { 
            echo "--[dir] $file2<br>\n"; //display folders with sub-menu    NOT NEEDED
		*/
        } 
    } 
}
}
} 
closedir($dir);
echo "</table>";

the main site is at http://bowling.hellrazer.net/
to view the admin menu just login as tester//tester

[helz]

for pete's sake teh var $file is used in all the other sections of the navigation but as of yet has not caused a problem, ill update this post to see if changing the $file to $admin_file solves the problem of conflicting with the other $files, which is unlikly...

simply changing the $file in the admin part to $admin_file, screwed it all up once more, it seems to have changed all files in the admin folder into the dir header and the files in the folder are somthing wierd...
here is what it is shown as:

--Admin Menu--
----Edit_Member.php--
.autofsck

quota.user

.bash history

aquota.user

----News--
.autofsck

quota.user

.bash history

aquota.user

this is what should be seen, just like in the test.php

--Admin Menu--
Edit Member
------News
Add News
Edit News

[helz]

well what ive decided to do is:

1. change the other parts of the nav.php so that they are completely uniquie so theres no conflicts

2. copied the script exactly as it is in the test.php which works perfectly. (not tried it with multiple dirs) and it still doesnt work, it seems to think that everything is not a dir and post a link to it (exactly what the problem was before)
   [/list=a]

   to clarify matters heres the code:
   please ignore the code before the admin part as this works fine and i dont want to change it.

   <?
   // session_start();
   require ("".$DOCUMENT_ROOT."/cgi-bin/connect.php");
   require ("".$DOCUMENT_ROOT."/include/isadmin.php");
   require ("".$DOCUMENT_ROOT."/include/ismember.php");
   $username = $_SESSION['user_name'];
   // dir
   $dir = "./modules/";
   $admindir = "./admin/";
   $memberdir = "./member/";
   //------------------------- MODULE MENU
   echo "<table width=100% border='1' align='center' cellpadding='1' cellspacing='0' bgcolor='#FFFFFF'>
   	  <tr><td bordercolor='#000000'><div align='center'><font color='#000000'><b>Navigation</b></font></div></td></tr>
   	  <tr><td><font color='#000000'><strong>--Modules--</strong></font></td></tr>
   	  <tr><td><font color='#000000'><li><a href='http://bowling.hellrazer.net/'>Home</a></li></font></td></tr>";
   if (is_dir($dir)) {
       if ($dh = opendir($dir)) {
           while (($module_file = readdir($dh)) !== false) {
   			if ( $module_file != "." && $module_file  != ".." ){
   			  $module_file = basename ($module_file,".php");
   			$module_filetitle = ereg_replace('_',' ',$module_file);
   			  echo "<tr><td><font color='#000000'><li><a href='../index.php?module=".$module_file."'>".$module_filetitle."</a></li></font></td></tr>";
   				}
           }
       closedir($dh);
       }
   }
   //------------------------- MEMBER MENU
   if ($flag==1) {
   echo "<tr><td><font color='#000000'><strong>--Member Menu--</strong></font></td></tr>";
   if (is_dir($memberdir)) {
       if ($dh = opendir($memberdir)) {
           while (($member_file = readdir($dh)) !== false) {
   			if ( $member_file != "." && $member_file  != ".." ){
   			  $member_file = basename ($member_file,".php");
   			$member_filetitle = ereg_replace('_',' ',$member_file);
   			  echo "<tr><td><font color='#000000'><li><a href='../index.php?member=".$member_file."'>".$member_filetitle."</a></li></font></td></tr>";
   				}
           }
       closedir($dh);
       }
   }
   }
   //------------------------- ADMIN MENU
   if($admin==1) {
   
   echo "<tr><td><font color='#000000'><strong>--Admin Menu--</strong></font></td></tr>";
   
   $dir = opendir($admindir); 
   while (false !== ($file = readdir($dir)))
   if ( $file != "." && $file  != ".." ){// get rid of . and .. 
   { 
       if (!is_dir("$path/$file")) { 
   			  $file4 = basename($file,".php");// get rid of extension for display in menu
   			  $filetitle = ereg_replace('_',' ',$file4);// replace underscore with a space
   			  echo "<tr><td><font color='#000000'><li><a href='../index.php?incadmin=".$file4."'>".$filetitle."</a></li></font></td></tr>";
       } 
       else 
       { 
        // echo "[dir] $file<br>\n"; //display sub-menu
   		echo "<tr><td><font color='#000000'>-------".$file."</font></td></tr>";// output dir as new submenu
   //        if ($file == '..' || $file == '.') { continue; } 
           $dir2 = opendir("$path/$file"); 
           while (false !== ($file2 = readdir($dir2))) 
           { 
               if (!is_dir("$path/$file2")) 
               { 
   			  $file2 = basename($file2,".php");// get rid of extension for display in menu
   			  $filetitle = ereg_replace('_',' ',$file2);// replace underscore with a space
   
         //    echo "--[file] $path/$file/$file2<br>\n"; //display files within sub-menu 
   			echo "<tr><td><font color='#000000'><li><a href='../index.php?incadmin=".$file."/".$file2."'>".$filetitle."</a></li></font></td></tr>";
   
           } 
       } 
   }
   }
   } 
   closedir($dir);
   
   
   }//end admin if
   
   
   //-------------------------
   echo "</table>";
   ?>
   

[bad76]

You are missing any assignement to $path.

Put $path=$admindir and write is_dir($path.$file) instead of is_dir("$path/$file")

[tekky]

Originally posted by bad76
You are missing any assignement to $path.

Put $path=$admindir and write is_dir($path.$file) instead of is_dir("$path/$file")

only reason he's using $path/$file was because the example used getcwd() which doesnt return the / at the end 😉

[helz]

something like that tekky 🙂 seen ya photos on yer site, lol,

okies, so the admin menu uses completely diff vars from the other parts, (apart from changing _ to a space) and i used the code exactly as the test file which works perfectly i think,

btw does the one you give display the new dir then the files in the new dir or all the new dirs and then the files in the newdirs? cos i need the newfiles to be displayed with their dir, not seperate....

so the code works perfectly in the test, i copy the code exactly but it doesnt work? as you can see if you logged in to my site, thats what shows up... any ideas?

[tekky]

it would display

file
file
dir
--file
--file
--dir
file
file

I'll play with a more dynamic setup

and hope you didnt laugh too hard at the pics 😛 (most are old now (1-1.5years now) anyways) 😃

[helz]

well if you succeed then i will welcome the new code, except i still have no clue to as why the code does not work in the navigation page but does in the test page....
any clues?

btw the nav.php file is loaded into the index.php by the simple include ("include/nav.php");

==edit==
also would the code, be able to display multiple folders
eg:

file
file
dir
-file
-file
file
dir
-file
-file
file

the loop does it in alphabetical order by default yeh? (alph order is not required)

is it does display as the example above then woohoo

[tekky]

currently it prints in order of creation I believe....
not alpha, but the new one will (once I figure out the recursion)

[helz]

right thanks again,
ill be waiting in hope for teh new script!! 😃

[tekky]

oke change of plan... it does do alpha sort.... still playing with another way to do this, but I did find a recursive function on php.net that worked sorta, and modified it to work how it needs to for this....

<?
$prefix = '&nbsp&nbsp';
$path = getcwd().'/';
function recursive_ls($directory, $count, $depth) 
{ 
	global $path, $prefix;
	$dummy = $count; 
	if ($handle = opendir($directory))
	{ 
		while ($file = readdir($handle))
		{ 
			if ($file=='.' || $file=='..') continue; 
			else if ($h = @opendir($directory.$file."/"))
			{ 
				$depth++;
				closedir($h); 
				$count = -1; 
				echo str_repeat($prefix, $depth-1). '[' .$file. ']<br>';
				recursive_ls($directory.$file."/", $count + 1, $depth);
				$depth--;
			} 
			else
			{
				echo str_repeat($prefix, $depth).$file."<br>"; 
				$dummy = $dummy + 1;
			} 
		}
	} 
	closedir($handle); 
	return; 
} 
recursive_ls($path, 0, 0); 
?>

(this originally stored it in an array but it wouldnt read back out right for some reason, still playing with arrays so you can sort and such)

[helz]

hmm nice!

i converted it to show what i want, but, how do i make it so the link of the file in the dirs that are in the main dir, have the dirname in thier link like so:
<a href='index.php?incadmin=".$dirname."/".$fileindir."'>$fileindirtitle</a>

i tried one method but it added the extra / to all the files not just the ones inside the newdir..

heres the extra i did:

$prefix = '&nbsp&nbsp'; 
//$path = getcwd().'/'; 
$path = "./admin/";
function recursive_ls($directory, $count, $depth)  

{  

    global $path, $prefix; 
    $dummy = $count;  

    if ($handle = opendir($directory)) 
    {  

        while ($file = readdir($handle)) 
        {  

            if ($file=='.' || $file=='..') continue;  

            else if ($h = @opendir($directory.$file."/")) 
            {  

                $depth++; 
                closedir($h);  

                $count = -1;  

                echo str_repeat($prefix, $depth-1). "<tr><td><font color='#000000'>-------".$file."</font></td></tr>";
                recursive_ls($directory.$file."/", $count + 1, $depth); 
                $depth--; 
            }  

            else 
            {
				$file = basename($file,".php");
				$filetitle = ereg_replace('_',' ',$file);
                echo str_repeat($prefix, $depth). "<tr><td><font color='#000000'><li><a href='../index.php?incadmin=".$file."'>".$filetitle."</a></li></font></td></tr>";  

                $dummy = $dummy + 1; 
            }  

        } 
    }  

    closedir($handle);  

    return;  

}  

recursive_ls($path, 0, 0);

[tekky]

use an if check...

if ($depth > 0)
{
     //add dirname
}

[tekky]

$prefix = '&nbsp&nbsp'; 
//$path = getcwd().'/'; 
$path = "./admin/";
function recursive_ls($directory, $depth)  

{  

    global $path, $prefix; 
    if ($handle = opendir($directory)) 
    {  

        while ($file = readdir($handle)) 
        {  

            if ($file=='.' || $file=='..') continue;  

            else if ($h = @opendir($directory.$file."/")) 
            {  

                $depth++; 
                closedir($h);  

                echo str_repeat($prefix, $depth-1). "<tr><td><font color='#000000'>-------".$file."</font></td></tr>";
                recursive_ls($directory.$file.'/', $depth); 
                $depth--; 
            }  

            else 
            {
				if ($depth > 0)
				{
					//add dir name here
				}
				$file = basename($file,".php");
				$filetitle = ereg_replace('_',' ',$file);
                echo str_repeat($prefix, $depth). "<tr><td><font color='#000000'><li><a href='../index.php?incadmin=".$file."'>".$filetitle."</a></li></font></td></tr>";  

            }  

        } 
    }  

    closedir($handle);  

    return;  

}  

recursive_ls($path, 0);

I would use this....
I cleaned up some extra stuff I missed earlier, and added the if check, you just need to code in the what to do with the name 😉

[helz]

so in that if statement i could have:

$newdir = "".$file."/";

well to be honest i havn't got a clue, i only want the files inside the newdir to have the incadmin=$newdir/$file thing, how do i seperate them from the files inside ./admin/ and not ./admin/news ??