[Resolved] Can't insert form values!!

Med

For some reason I cannot insert form values into mysql. Same query however goes through from the command line. Below is the php code that I'm using:

[PHP
<HTML>
<?php

if ($submit) {
$db = mysql_connect("localhost", "root","");
mysql_select_db("staffdb",$db);
$sql = "INSERT INTO personnel (firstname, lastname, nick, email, salary) VALUES ('$first','$last','$nickname','$email','$salary')";
$result = mysql_query($sql);
echo "Thank you! Information entered.\n";
}
else{
if (mysql_errno() >= 0)
mysql_error();
?>
<form method="post" action="datain.php">
First name:<input type="Text" name="first"><br>
Last name:<input type="Text" name="last"><br>
Nick Name:<input type="Text" name="nickname"><br>
E-mail:<input type="Text" name="email"><br>
Salary:<input type="Text" name="salary"><br>
<input type="Submit" name="submit" value="Enter information"></form>
<?
}
?>
</HTML>
[/PHP

I get no error but noting takes place in the db table.

Any suggestions appreciated.

trooper

Have you checked you register_globals ?

If they are set to "off" (default recommended) then your variables will be in the $_POST array

So for your script simply put

extract $_POST after the if($submit)

That will then make the variables accessable to you

HTH

cgraz

This is also covered in the Dateabase Forum FAQ sticky.

Print out the variable that holds your query string and use mysql_error() should solve the majority MySQL/PHP problems you'll run into.

Cgraz

Med

I used the $POST variable, and followed the advice from Dateabase Forum FAQ regarding the elements in the REQUEST array. Unfortunately, nothing has changed; No data insertion, neither error.

Looks like I'm in for a much deeper problem than I thought.

tekky

change all your mysql_query()'s to be like this

mysql_query("your queries stay the same") or die("Error - " .mysql_error());

cgraz

Yes, and also print out the variable that holds the string you want to execute. Copy and paste what this prints

$sql = "INSERT INTO personnel (firstname, lastname, nick, email, salary) VALUES ('$first','$last','$nickname','$email','$salary')"; 
print "Query Looks like: " . $sql . "<br>";
$result = mysql_query($sql) or die(mysql_error());

Cgraz

Med

I've tried all the suggestions mentioned here. Still no output. With the SELECT I see the statement being written to the screen, but with INSERT nothing comes up and the page keeps looping back to the input form. !!

This is the updated snippet:

<HTML>
<?php

if ($submit) {
	include "open_persondb.inc";

$list =  array( '_REQUEST', '_COOKIE', '_ENV', '_FILES', '_POST' );
foreach($list as $element) {
  if( !empty($$element) && is_array($$element) ) {
      extract($$element);
   }
}


$sql_insert = "INSERT INTO personnel (firstname, lastname, nick, email, salary) VALUES 
	('$first','$last','$nickname','$email','$salary')";

print $sql_insert;

$result = mysql_query($sql_insert, $db) or die(mysql_error());
echo "Information Was Submitted.\n";
}
else{
	if (mysql_errno() >= 0)
		mysql_error();
?>
<form method="post" action="datain.php">
First name:<input type="Text" name="first"><br>
Last name:<input type="Text" name="last"><br>
Nick Name:<input type="Text" name="nickname"><br>
E-mail:<input type="Text" name="email"><br>
Salary:<input type="Text" name="salary"><br>
<input type="Submit" name="submit" value="Enter information"></form>
<?
}
?>
</HTML>

and nothing strange in the open_persondb.inc

<?php
$db = mysql_connect("localhost", "root", "");
mysql_select_db("test", $db) or die(mysql_errno() . ": " . mysql_error() . "<br>");
?>

maybe I should just mind my Java business and stay out of PHP 🙂

cgraz

How do you know that if statement is returning true? The if($submit) one? If it is returning false, you're not going to get any output. How about this

if(isset($_POST['submit'])) {
  // your code here
} else {
  echo "If Statement returned false";
}

Cgraz

Med

The answer to your question, cgraz, is that I don't know.

THANK YOU!

Apparently what I know about forms and REQUEST RESPONSE objects in the context of servlet is totally irrelative here.
My guess is that isset() checks for the status of the POST method.

Once again, thanks a zillion.

superwormy

isset() checks whether or not a variable has been set or not... it has nothing at all to do with the POST method... or any other method for that matter...

Go read the manual: www.php.net/isset

$submit is probably not set because you have register_globals = OFF... use $POST['submit'] or $REQUEST['submit'] instead...