using the empy function

mahugl

Hi,

I have been working on php for a little while and am having a little trouble. I have a working form and the fields get inserted into my mysql table correctly but the receipt page says that I did not enter anything into the firstname field or email field the two that I require people to enter information. Here is the code. Also if you go to the Website you can see what I mean. Thanks for your help.

<?php
include 'error.php';
include 'db.php';

$errorString = "";

foreach($HTTP_POST_VARS as $varname => $value)
$formVars[$varname] = trim(clean($value));

if(empty($formVars["firstname"]))

$errorString .="The first name field cannot be blank.";

if(empty($formVars["email"]))
$errorString .="You must supply an email address.";

if(!empty($errorString))
{
?>

<html>
<head>
<title>Guestbook Details Error</title>
</head>
<body bgcolor = "#FFFFFF">
<h1>Guestbook Errors</h1>
<?=$errorString?>
<br>
<a href="form.html">Return to the sign on for guestbook</a>
</body>
</html>

<?php

}

if(!($connection = @mysql_pconnect($hostname,$username,$password)))
die("Could not connect to database");

if(!mysql_select_db($databaseName, $connection))
showerror();

$query = "INSERT INTO guestbook (visitor_id, firstname, email, comments) values
('NULL','$firstname','$email','$comments')";

if(!(@($query,$connection)))
showerror();

$firstname = mysql_insert_id();

header("Location: thankyou.php?firstname=$firstname");

HalfaBee

Do a print_r( $formVars ) after the foreach loop to see what is being set.

HalfaBee

rrijnders

Your logic will try to add a record to the DB regardless if $errorString is empty or not. To fix this, put the INSERT logic inside an ELSE { } construct after the error display block.

I am guessing that your PHP installation has REGISTER_GLOBALS on. This means that $PHP_POST_VARS is empty, causing your error string to get populated by the error checks. But your INSERT logic uses the global variables $firstname, $email, and $comments which actually have values because of REGISTER_GLOBALS being on.

The end result of these conditions is just what you see: you get error messages for the fields being empty and you get the actual data entered into the database.

-- Rich

Moonglobe

just a side note but what is that clean function? it's not in the manual....