file upload problem

shaolinstyl

I'm trying to upload a file:
This is my form code:

<html>

<body>

<form method="post" enctype="multipart/form-data" action="work2.php">

Upload image file: <input name="userfile" type="file">

</form>

</body>

</html>

This is my upload code:

<html>

<body>

<?php

// echo $userfile_size;

print_r ($_FILES);

	if ($userfile=="none")
	{echo "Problem: no file uploaded";
	$error = "1";
	exit;
	}
	if ($userfile_size==0)  
	{
	echo "Problem: uploaded file is zero length";
	$error = '1';
	exit;
	}
	if ($userfile_type != "image/gif")  
	{
	echo "Problem: file is not an image";
	$error = "1";
	exit;
	}  
	if (!is_uploaded_file($userfile))
	{
	echo "Problem: possible file upload attack";
	$error = "1";
	exit;
	}

	$upfile = " /home/whyknotbeads/www/" . $userfile_name;

	if ( !copy($userfile, $upfile))  
	  {
	  echo "Problem: Could not move file into directory";
	  exit;
	  }

	if ($error)
	  {
	  echo "Error";
	  }
	  else
	  {
	  echo "Thank you! Information has been updated.\n";
	  echo "<script language=javascript>window.location.replace(\"http://www.whyknotbeads.com/admin/test.php?note='Thank you! Information has been updated.'\")</script>";   
	  }

</body>

And this is the error I'm getting:

Array ( [userfile] => Array ( [name] => spiderman.gif [type] => image/gif [tmp_name] => /tmp/phpY3pym5 [error] => 0 [size] => 108923 ) )
Warning: copy( /home/whyknotbeads/www/spiderman.gif): failed to open stream: No such file or directory in /home/whyknotbeads/www/admin/work2.php on line 37
Problem: Could not move file into directory

IDEAS? THANKS!

scottrad

Looks like the code from PHP and MySQL Web Development book Second Edition. Seems that your prob is:
Warning: copy( /home/whyknotbeads/www/spiderman.gif): failed to open stream: No such file or directory in /home/whyknotbeads/www/admin/work2.php on line 37
Problem: Could not move file into directory

Is the file in the right place and are you positive you created the dir for the file to go into?

Also please add line #s when posting the error.

hardanro

Use the $FILES array properly. So instead of using $userfile_size, $userfile_type etc use $FILES['userfile']['type'].... Maybe is working with the notation $userfiles_size but it's better using the array.
Anyway, the error that you recieved is because you try to copy $userfile (which is an array, as it is shown in the result) to /home/whyknotbeads/www/spiderman.gif. Use this for the copy:
copy($_FILES['userfile']['tmp_name'],$upfile) or to keep the same notation as the code:
copy($userfile[tmp_name],$upfile)

shaolinstyl

Hi:
Thanks, I still can't seem to get it to work. I checked, the directory does exist.
Do you mean that I should just add

copy($userfile[tmp_name],$upfile)

Or do you mean that I should replace:

$upfile = "/home/whyknotbeads/www/" . $userfile[tmp_name];

with

copy($userfile[tmp_name],$upfile)

This is the error I got:

Array ( [userfile] => Array ( [name] => spiderman.gif [type] => image/gif [tmp_name] => /tmp/phpLGDTtE [error] => 0 [size] => 108923 ) )
Warning: copy(/home/whyknotbeads/www//): failed to open stream: Is a directory in /home/whyknotbeads/www/admin/work2.php on line 39
Problem: Could not move file into directory

Thanks!

-t

<html>

<body>

<?php

print_r ($_FILES);

	if ($userfile=="none")
	{echo "Problem: no file uploaded";
	$error = "1";
	exit;
	}
	if ($_FILES['userfile']['size']==0)  
	{
	echo "Problem: uploaded file is zero length";
	$error = '1';
	exit;
	}
	if ($_FILES['userfile']['type'] != "image/gif")  
	{
	echo "Problem: file is not an image";
	$error = "1";
	exit;
	}  
	if (!is_uploaded_file($userfile))
	{
	echo "Problem: possible file upload attack";
	$error = "1";
	exit;
	}

	$upfile = "/home/whyknotbeads/www/" . $userfile[tmp_name];

// I also replaced the previous line with this, but got the same error: copy($userfile[tmp_name],$upfile);

	if ( !copy($userfile[tmp_name], $upfile))  
	  {
	  echo "Problem: Could not move file into directory";
	  exit;
	  }

	if ($error)
	  {
	  echo "Error";
	  }
	  else
	  {
	  echo "Thank you! Information has been updated.\n";
	  echo "<script language=javascript>window.location.replace(\"http://www.whyknotbeads.com/admin/test.php?note='Thank you! Information has been updated.'\")</script>";   
	  }