spaces in fields screw up email processing

[phpdeano]

I am sure this is an embarrasing newbie question.

I have an email script which works fine if the data in the fields passed to it do not contain spaces.

I therefore urlencoded the data, but that sends all messages with a "+" symbol between all of the words.

What am I missing here? Please help.

<?php
if($sendemail)
{

$email=trim($frmail);
$sub=trim($subj);
$comments = urlencode($sub);
$sendername = urlencode($sender);
$phonenumber = urlencode($phone);
$header = "MIME-Version: 1.0\r\n";
$header.= "Content-type: text/html; charset=iso-8859-1\r\n";

$header.="From: ".$_POST['frmail']."\r\n";

if (!ereg("^{[a-zA-Z0-9_]+@[a-zA-Z0-9-]+.[a-zA-Z0-9-.]+$",} $email))
{
echo "That is not a valid email address. Please return to the"
." previous page and try again.";
exit;
}

$toaddress = "webcontact@***********"; // the default value
$allinfo = $comments.$sendername.$phonenumber;
$mailcontent = "From: ".$frmail."\r\n"."To: ".$toaddress."\r\n"."Subject: ".$comments."\r\n"
."User email: ".$email."\r\n"."other stuff".$allinfo;

$sendmessage = mail($toaddress, $comments, $mailcontent, $header, $allinfo);
}
?>

[erikwebb]

You shouldn't have to use urlencode() if you are simply sending an email.

[phpdeano]

I agree, however if i do not use urlencode the form does not process.

Any ideas why?

[erikwebb]

That is extremely odd. Let me see the form code.

[erikwebb]

That is extremely odd. Let me see the form code.

[TheIceman5]

Originally posted by erikwebb
That is extremely odd. Let me see the form code.

u only have to ask once i think.

[phpdeano]

Thanks for sticking with me on this one.

The form is shown below:

    <form action=index.php method=post>
      <tr class=contact>
        <td colspan="2" contact><b>Contact us by Email:</b></td>
      </tr>
      <tr class=contact>
        <td contact>Your Name:</td>
        <td contact><input type=text name=sender size=20></td>
      </tr>
      <tr class=contact>
        <td contact>Your Email:</td>
        <td contact><input type=text name=frmail size=20></td>
      </tr>
      <tr class=contact>
        <td contact>Your Contact Number:</td>
        <td contact><input type=text name=phone size=20></td>
      </tr>
      <tr class=contact>
        <td contact valign=top>Details of Request:</td>
        <td contact><textarea name=subj cols=30 rows=5></textarea></td>
      </tr>
      <tr>
        <td contact valign=top>Click to send:</td>
        <td contact><input type=submit name=subemail value="Send Email"></td>
    </form>

This calls the same page (index.php), with the script shown below.

    if($sendemail)
    {

    $email=trim($frmail); 
    $sub=trim($subj);
    $comments = urlencode($sub);
    $sendername = urlencode($sender);
    $phonenumber = urlencode($phone);
    $header = "MIME-Version: 1.0\r\n"; 
    $header.= "Content-type: text/html; charset=iso-8859-1\r\n"; 

    $header.="From: ".$_POST['frmail']."\r\n"; 


    if (!ereg("^[a-zA-Z0-9_]+@[a-zA-Z0-9\-]+\.[a-zA-Z0-9\-\.]+$", $email)) 
    { 
    echo "That is not a valid email address. Please return to the" 
    ." previous page and try again."; 
    exit; 
    } 

    $toaddress = "webcontact@**********"; // the default value 
    $allinfo = $comments.$sendername.$phonenumber;
    $mailcontent = "From: ".$frmail."\r\n"."To: ".$toaddress."\r\n"."Subject: ".$comments."\r\n" 
    ."User email: ".$email."\r\n"."other stuff".$allinfo; 


    $sendmessage = mail($toaddress, $comments, $mailcontent, $header, $allinfo); 

    if ($sendmessage)
    {
    $pageid=9;
    }

    }

Regards