Need Help With Loops

dbaz

I'm trying to create a loop that places the thumbnails of images from a database into a table that has four columns.

For some reason, the way I've written this script, it works OK if the number of images is divisible by four. But, if it's not, it doesn't display correctly. Here's what I have. any help you can give on fixing this is appreciated.

$num_rows = mysql_num_rows($query);
$i=0;
$ii=1;
$small="small";

while ($i < $num_rows) {

$id=mysql_result($query,$i,"id");
$small2 = mysql_result($query,$i,"small");
IF ($ii <= "3") {
echo "<td><a href=\"abstract.php?id=$id\"><img src=\"../abstract/images/$category$id$small.jpg\"></a></td>";
} ELSE {
$ii=-1;
echo "<tr>";

}
++$ii;
++$i;
}

BuzzLY

I don't have a result set to test, so this code is untested. Try this:

$query = "(your SQL query)";
$result = mysql_query($query);
$i=0;
$cols = 4;

echo "<table>\n";
echo "<tr>\n";
while ($row = mysql_fetch_array($result)) {
  $i++;
  if ($i%$cols == 0) echo "</tr><tr>\n";
  echo "<td>\n";
  echo "<a href=\"abstract.php?id=" . 
       $row['id'] . "\"><img src=\"../abstract/images/" . 
       $row['category'] . $row['id'] . 
       $row['small'] . ".jpg\">\n";
  echo "</td>\n";
}
while ($i%$cols != 0) {
  $i++;
  echo "<td>&nbsp;</td>\n";
}
echo "</tr></table>";

To change the number of columns, just edit the $cols variable.

HTH!

dbaz

Warning: Supplied argument is not a valid MySQL result resource

i believe it's this line.
while ($row = mysql_fetch_array($result)) {

dbaz

Disregard the last email. I figured it out.

But, once again, on the first row... it only shows the first three thumbnails... then on the rest of the rows it displays 4 in a row except for the last row that has three. For some reason, it places nothing in the fourth cell on the first row. why?

any help is appreciated.

dbaz

THANKS SO MUCH... Figured it out.

I set $i = -1

thanks.

BuzzLY

whoops. Change $i back to 0, and modify your while statement as follows:

while ($row = mysql_fetch_array($result)) { 
  if ($i%$cols == 0) echo "</tr><tr>\n"; 
  echo "<td>\n"; 
  echo "<a href=\"abstract.php?id=" .  

       $row['id'] . "\"><img src=\"../abstract/images/" .  

       $row['category'] . $row['id'] .  

       $row['small'] . ".jpg\"></a>\n"; 
  echo "</td>\n"; 
  $i++; 
}

If you want to see why, set your border=1 in the table, and you'll see an extra cell at the end of your table. Yuck. the fix above will take care of that. I also added the </a> to the end of your URL, as you may have already noticed was missing.

Incidentally, you can edit your posts, and delete them as well. That way you don't have redundant posts, and you don't have to to say "ignore my last post." 🙂