Lost again givin me same answer

DisOrDeR1337

Ok, I've found a more efficient way to do this, but it just keeps spitting out the same person over and over, even though there are 40 people in the db

Heres the code I came up with

$j = 1; 		

	$result = mysql_query("SELECT * FROM newsletter ", $db);
	$row = mysql_fetch_array($result);
	{
	echo"<tr>\n";
if ($row = mysql_fetch_array($result)) {
	do {
			printf("<td class=\"tx\"> $j</td>\n");
			printf("<td class=\"tx\"> %s</td>\n", $row["fname"]);
			printf("<td class=\"tx\"> %s</td>\n", $row["name"]);
			printf("<td class=\"tx\"> %s</td>\n", $row["location"]);
			printf("<td class=\"tx\"> %s</td>\n", $row["Date"]);
			printf("<td class=\"tx\"> %s</td>\n", $row["email"]);
			printf("<td class=\"tx\"> <input type=\"checkbox\" name=\"delbox[]\" value=\"%s\"></td>\n", $row["uid"]);
	$j++;
			echo"</tr>\n";
		} while ($myrow = mysql_fetch_array($result));

}
}

Any ideas why its just giving me this

http://www.clanknm.com/compren/admin1

Thanks,
Aaron

maybl8r03

$dbexec = mysql_query("SELECT * FROM newsletter ", $db);
$strResult = "<table>"; 
while ($arRecord = mysql_fetch_array($dbexec, MYSQL_ASSOC))
{
   $strResult .= "<tr>";
   $strResult .= "<td>{$arRecord['fname']}</td>";
   $strResult .= "<td>{$arRecord['name']}</td>";
   // ...
   $strResult .= "</tr>";
}
$strResult.="</table>";

You only need one instance of mysql_fetch_array to accomplish this and if you look at it the logic is straightforward (keep in mind that it increments the pointer to the next row after each call).

DisOrDeR1337

confused...
why does this one loop all the way though each entry

if ($myrow = mysql_fetch_array($result)) {

  // display list if there are records to display

  do {

    printf("<a href=\"%s?id=%s\">%s</a><br>\n", $PHP_SELF, $myrow[0], $myrow[1]);

  } while ($myrow = mysql_fetch_array($result));

} else {

  // no records to display

  echo "Sorry, no records were found!";	

}

maybl8r03

It is the difference between while (condition) loop and do {} while (condition) loop.

In the while loop, the condition is checked first before entering the loop. The Do/While loop on the other hand executes once before checking for a condition.

HalfaBee

The reason your original code didn't work is that you used $row of the first fetch and $myrow on the while loop.

I prefer the way maybl8r03 did it.

HalfaBee

DisOrDeR1337

Originally posted by maybl8r03
$dbexec = mysql_query("SELECT * FROM newsletter ", $db);
$strResult = "<table>"; 
while ($arRecord = mysql_fetch_array($dbexec, MYSQL_ASSOC))
{
   $strResult .= "<tr>";
   $strResult .= "<td>{$arRecord['fname']}</td>";
   $strResult .= "<td>{$arRecord['name']}</td>";
   // ...
   $strResult .= "</tr>";
}
$strResult.="</table>";
You only need one instance of mysql_fetch_array to accomplish this and if you look at it the logic is straightforward (keep in mind that it increments the pointer to the next row after each call). [/B]

Im so lost in how this is is going to echo what it pulls from the database, or how it works, and whats the .= mean compared to just =? sorry im so n00b🙂

DisOrDeR1337

haha, awesome I figured it out! thanks for all the help guys!

haha, sorry i catch on slow

-aaron