mail with multiple attachments

[snoopy13]

hy everyone

I have a problem with sending an email via php with several attachments. I use the script from http://www.sitepoint.com/article/679/5 and it works fine with one attachment. but now I tried to add a second one but it doesn't seem to work. I only get the firs attached file.
can anyone help me?

[lobster]

OK. Below is the code I am trying with no success. It is for brokers to send multiple pictures in an email.

mail.php

<?php
// Read POST request params into global vars
$to      = "[e-mail]";
$from    = "[e-mail]";
$subject = "$broker $boatlength $boatmanufacturer - $sellername Listing";
$message = "<b>Here are the pictures for $broker $boatlength $boatmanufacturer - $sellername Listing</b><br>";

// Obtain file upload vars
for($p = 0; $p<11; $p++)
{
$s = $p + 1;
$fileatt[$s] = $_FILES['fileatt[$s]']['tmp_name'];
$fileatt[$s]_type = $_FILES['fileatt[$s]']['type'];
$fileatt[$s]_name = $_FILES['fileatt[$s]']['name'];
}
$headers = "From: [email][e-mail][/email]";
  for($f = 0; $f<11; $f++)
  {
	if (is_uploaded_file($fileatt[($f + 1)])) {
  	// Read the file to be attached ('rb' = read binary)
  		$file[($f + 1)] = fopen($fileatt[($f + 1)],'rb');
  		$data[($f + 1)] = fread($file[($f + 1)],filesize($fileatt[($f + 1)]));
  		fclose($file[($f + 1)]);
  	}
  }

  // Generate a boundary string
  $semi_rand = md5(time());
  $mime_boundary = "==Multipart_Boundary_x{$semi_rand}x";

  // Add the headers for a file attachment
  $headers .= "\nMIME-Version: 1.0\n" .
              "Content-Type: multipart/mixed;\n" .
              " boundary=\"{$mime_boundary}\"";

  // Add a multipart boundary above the plain message
  $message = "This is a multi-part message in MIME format.\n\n" .
             "--{$mime_boundary}\n" .
             "Content-Type: text/plain; charset=\"iso-8859-1\"\n" .
             "Content-Transfer-Encoding: 7bit\n\n" .
             $message . "\n\n";

  // Base64 encode the file data
  $data = chunk_split(base64_encode($data));

  // Add file attachment to the message
  for($m = 0; $m<11; $m++)
  {
  $message .= "--{$mime_boundary}\n" .
              "Content-Type: {$fileatt_type};\n" .
              " name=\"{$fileatt_name[".($m + 1)."]}\"\n" .
              //"Content-Disposition: attachment;\n" .
              //" filename=\"{$fileatt_name}\"\n" .
              "Content-Transfer-Encoding: base64\n\n" .
              $data[($m + 1)] . "\n\n" .
              "--{$mime_boundary}--\n";
   }
}

// Send the message
$ok = @mail($to, $subject, $message, $headers);
if ($ok) {
  echo "<p>Mail sent!!</p>";
} else {
  echo "<p>Mail could not be sent. Sorry!</p>";
}
?>

which is being called from:
listing.php

<form enctype="multipart/form-data" action="mail.php" method="post">
<?
$max_images = 10;
for($i = 0; $i<10; $i++)
 {
  echo "<input name='userfile[".($i+1)."]' size=40 type='file'><br>";
 }
?>
<input type="hidden" name="max_images" value=<? echo "$max_images" ?>>
<input type="hidden" name="broker" value="<? echo "$broker" ?>">
<input type="hidden" name="boatlength" value="<? echo "$boatlength" ?>">
<input type="hidden" name="boatmanufacturer" value="<? echo "$boatmanufacturer" ?>">
<input type="hidden" name="sellername" value="<? echo "$sellername" ?>">
<input type="submit" value="upload"><br>
		</form>		

any ideas? I get a T-Variables error near this line

{
$s = $p + 1;
$fileatt[$s] = $FILES['fileatt[$s]']['tmp_name'];
$fileatt[$s]type = $FILES['fileatt[$s]']['type'];
$fileatt[$s]name = $_FILES['fileatt[$s]']['name'];
}

Any help would be appreciated.

Laura

[stevesweetland]

how did you get on; trying to do this myself now!

[bobthedog]

Hmmmm - there are quite a few major problems with this code, as well as a few minor ones. The minor ones are pretty easy to sort - your "T-Variables error" is because the way you are referencing an array makes no sense: -

$fileatt[$s]_type

doesn't mean anything, it isn't valid php afaik. In fact, I don't see much point in the first loop: -

for($p = 0; $p<11; $p++) 
{ 
$s = $p + 1; 
$fileatt[$s] = $_FILES['fileatt[$s]']['tmp_name']; 
$fileatt[$s]_type = $_FILES['fileatt[$s]']['type']; 
$fileatt[$s]_name = $_FILES['fileatt[$s]']['name']; 
} 

which is just copying from one array to another (actually - it doesn't look like it would even work doing that tbh). At the end of the day, you could just use the $_FILES array throughout your code instead.

Next, we get to the attachment of file data: -

// Base64 encode the file data 
$data = chunk_split(base64_encode($data)); 

// Add file attachment to the message 
for($m = 0; $m<11; $m++) 
{ 
  $message .= "--{$mime_boundary}\n" . 
              "Content-Type: {$fileatt_type};\n" . 
              " name=\"{$fileatt_name[".($m + 1)."]}\"\n" . 
              //"Content-Disposition: attachment;\n" . 
              //" filename=\"{$fileatt_name}\"\n" . 
              "Content-Transfer-Encoding: base64\n\n" . 
              $data[($m + 1)] . "\n\n" . 
              "--{$mime_boundary}--\n"; 
}

which I'm not sure i understand whatyou are doing. You have read all the files into an array $data. Then you base64 enocde the whole $data array (which I dont know what would happen on an array). So - ALL the files are ending up as one base64 encoded string which of course is never going to work, and no one would know what to do with.

What you need to do is move the encoding into the loop below it and only encode one file at a time: -

// Add file attachment to the message 
for($m = 0; $m<11; $m++) 
{ 
  // Base64 encode the file data 
  $file_data = chunk_split(base64_encode($data[($m+1)])); 

  $message .= "--{$mime_boundary}\n" . 
              "Content-Type: {$fileatt_type};\n" . 
              " name=\"{$fileatt_name[".($m + 1)."]}\"\n" . 
              //"Content-Disposition: attachment;\n" . 
              //" filename=\"{$fileatt_name}\"\n" . 
              "Content-Transfer-Encoding: base64\n\n" . 
              $file_data . "\n\n" . 
              "--{$mime_boundary}--\n"; 
}

and finally (just a stoopid point), when calling the [man]mail/man function, drop the $message parameter and call it with an empty string, since in this case the headers we are using ARE the message body: -

mail($to, $subject, '', $headers); 

Hopefully this will help you in the right direction.... i haven't tested anything i've changed above so apologies if i've got anything wrong.

🙂

[stevesweetland]

even better, go here. just got this same problem working using code mentioned on the post linked below.

http://www.phpbuilder.com/board/showthread.php?threadid=10255505