[Resolved] PHP web DB Insert Update Delet Interface

jamesflynn

I really like this script

http://hotwired.lycos.com/webmonkey/99/21/index3a_page6.html?tw=programming

It seemed to include everything I would need to do. Show records, select from queried records and then edit upon selectiom or add and delete new records.

So obviously I'm trying to make an interface where someone has the ability to add update or delete records. Doesn't have to be very complicated just get has those key parts.

I tried to modify and test the script above to use and it would display records and they were highlighted as links but when I click on the link it passes the id number through the url correctly but it does not populate the for that i echoed from the ?id info in the url.

Thanks for any help,
James Flynn

stolzyboy

post some of your code where you check for the id on the page that it (?id=) is passed to

jamesflynn

Ok heres the bulk of the code. Its pretty slim.

if ($submit) {

// here if no ID then adding else we're editing

if ($id) {

$sql = "UPDATE tablename SET product='$product',product_id='$product_id',features='$features',specs='$specs' WHERE id=$id";

} else {

$sql = "INSERT INTO tablename (product,product_id,features,specs) VALUES ('$product','$product_id','$features','$specs')";

}

// run SQL against the DB

$result = mysql_query($sql);

echo "Record updated/edited!<p>";

} elseif ($delete) {

// delete a record

$sql = "DELETE FROM tablename WHERE id=$id";	

$result = mysql_query($sql);

echo "$sql Record deleted!<p>";

} else {

// this part happens if we don't press submit

if (!$id) {

// print the list if there is not editing

$result = mysql_query("SELECT * FROM tablename",$db);

while ($myrow = mysql_fetch_array($result)) {

  printf("<a href=\"%s?id=%s\">%s %s</a> \n", $PHP_SELF, $myrow["id"], $myrow["product"], $myrow["product_id"]);

  printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

}

}

<P>

<a href="<?php echo $PHP_SELF?>">ADD A RECORD</a>

<P>

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM tablename WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$product = $myrow["product"];

$product_id = $myrow["product_id"];

$features = $myrow["features"];

$specs = $myrow["specs"];

// print the id for editing



?>

<input type=hidden name="id" value="<?php echo $id ?>">

<?php

}

product name:<input type="Text" name="product" value="<?php echo $product ?>"><br>

product_id name:<input type="Text" name="product_id" value="<?php echo $product_id ?>"><br>
Features <textarea cols="10" rows="5" name="features" id="features"><?php echo $features ?></textarea>
Specs <textarea cols="10" rows="5" name="features" id="features"><?php echo $specs ?></textarea>

</form>

stolzyboy

do you have ANY idea where it isn't working, can you even do this

echo $_GET['id']; //or echo $id;

to see if that echo's anything

jamesflynn

I tried both of those and the first worked but the second didn't so its obviously not reading that DB query at the bottom for some reason. Its querying it correctly at the top so I know the id field is working and the record in the database is setup ok. Just gotta figure out why its not querying on the bottom.

Thanks for any help,
James Flynn

stolzyboy

put this line at the top before you try and execute any on $id

$id = $_GET['id'];

and see if that helps

jamesflynn

Sweet that worked, you the man.

Thanks alot,
James Flynn

jamesflynn

Ok well now it feeds the info into the forms correctly but when I update the info in the forms and click submit it doesn't do anything. The $PHP_SELF tag wasn't working properly for some reason so i declared the $PHP_SELF at the top similar to how we just did $PHP_SELF=phppage.php and then it passes to that file but none of the new variables aren't beeing processed

I sent it as a get also to just test just to make sure the updated variables were beeing sent and they are but there just not beeing processed in the if statement. I read that in older versions of php 3.0 (im on 4.2) and older php_self works differently than new versions on the newer versions it will pass it through the same file but I tried $_SERVER['PHP_SELF'] and that seemed to send it back to the right page but form fields still are not processed. So it must be something within this block

if ($submit) {

// here if no ID then adding else we're editing

if ($id) {

$sql = "UPDATE enoch SET product='$product',product_id='$product_id',features='$features',specs='$specs',cat='$cat' WHERE id=$id";

} else {

$sql = "INSERT INTO enoch (product,product_id,features,specs,cat) VALUES ('$product','$product_id','$features','$specs','$cat')";

}

// run SQL against the DB

$result = mysql_query($sql);

echo "Record updated/edited!<p>";

Thanks ahead for any help,
James

stolzyboy

you are having a register_globals = Off problem

with the newer version of php it is left off, so you need to access variables from posted forms with $POST['variablename'] instead of the old $variablename way, similarly like you have seen already, you need to use $GET['varname'] from the querystring instead of $varname, there are others as well, here is a list of them:

$_SERVER

$_GET

$_POST

$_COOKIE

$_FILES

$_ENV

$_REQUEST

$_SESSION

jamesflynn

I sending the form with $_POST['PHP_SELF'] but it still didn't work work me do I have to declare any of the other variables differently? Does each of the variables from the form have to be declared at the top?

$product = $_GET['product'];

etc.?

Thanks for your help,
James Flynn

stolzyboy

for server variables such as PHP_SELF, you need to use:

$_SERVER['PHP_SELF']

jamesflynn

Do I have to do anything with the individual variables or just the form POST?

Thanks alot,
James Flynn

stolzyboy

if the method of the form is POST, you need to access your variables with $_POST['varname'], so when checking to see if the submit was hit, do

<?
if ($_POST['submit'] == "Enter Information")
{
//submit was clicked
//access other variables with $_POST['varname'] also
}
else
{
//not clicked spit out form
}
?>

jamesflynn

I've tried alot of different combinations. But nothing really seems to be working for me. Its strange because it gets to the point where I get the echo saying that the record has been updated but the record doesn't actually change. This is what it look like now.

if ($_POST['submit']) {

// here if no ID then adding else we're editing

if ($_POST['id']) {

$_POST['sql'] = "UPDATE tablename SET product='$product',product_id='$product_id',features='$features',specs='$specs',cat='$cat' WHERE id=$id";

} else {

$_POST['sql'] = "INSERT INTO tablename (product,product_id,features,specs,cat) VALUES ('$product','$product_id','$features','$specs','$cat')";

}

// run SQL against the DB

$POST['result'] = mysql_query($POST['sql']);

echo "Record updated/edited!<p>";

} elseif ($_POST['delete']) {

// delete a record

$_POST['sql'] = "DELETE FROM tablename WHERE id=$id";	

$result = mysql_query($sql);

echo "$sql Record deleted!<p>";

} else {

// this part happens if we don't press submit

if (!$id) {

// print the list if there is not editing

$result = mysql_query("SELECT * FROM tablename",$db);

while ($myrow = mysql_fetch_array($result)) {

  printf("<a href=\"%s?id=%s\">%s %s</a> \n", $PHP_SELF, $myrow["id"], $myrow["id"], $myrow["product"], $myrow["product_id"]);

  printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

}

}

<P>

<a href="<?php echo $_SERVER['PHP_SELF']?>">ADD A RECORD</a>

<P>

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM tablename WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$product = $myrow["product"];

$product_id = $myrow["product_id"];

$features = $myrow["features"];

$specs = $myrow["specs"];

$cat = $myrow["cat"];	

// print the id for editing



?>

Thanks alot,
James Flynn

stolzyboy

you need to leave these

$_POST['sql']

like the normal

$sql

cuz that isn't coming from the posted form, regular variables are still used with the $variablename method, they only change when you are requesting data from a variable from a different page thru a form or via querystring

jamesflynn

Ok this is starting to get frustrating 🙂 Thanks alot for your time and help though i really appreaciate it. Ok well I goto edit the record and made some changes to it and click submit and it doesn't update that record but it makes a new blank record grr. So i mean at least its doing something but its obvously not reading that infio and im sure its because something wrong with the way those variables are beeing fed in. Heres what that thing looks like now.

if ($_POST['submit']) {

// here if no ID then adding else we're editing

if ($id) {

$sql = "UPDATE enoch SET product='$product',product_id='$product_id',features='$features',specs='$specs',cat='$cat' WHERE id=$id";

} else {

$sql = "INSERT INTO enoch (product,product_id,features,specs,cat) VALUES ('$product','$product_id','$features','$specs','$cat')";

}

// run SQL against the DB

$result = mysql_query($sql);

echo "Record updated/edited!<p>";

} elseif ($delete) {

// delete a record

$sql = "DELETE FROM enoch WHERE id=$id";	

$result = mysql_query($sql);

echo "$sql Record deleted!<p>";

} else {

// this part happens if we don't press submit

if (!$id) {

// print the list if there is not editing

$result = mysql_query("SELECT * FROM enoch",$db);

while ($myrow = mysql_fetch_array($result)) {

  printf("<a href=\"%s?id=%s\">%s %s</a> \n", $PHP_SELF, $myrow["id"], $myrow["id"], $myrow["product"], $myrow["product_id"]);

  printf("<a href=\"%s?id=%s&delete=yes\">(DELETE)</a><br>", $PHP_SELF, $myrow["id"]);

}

}

<P>

<a href="<?php echo $_SERVER['PHP_SELF']?>">ADD A RECORD</a>

<P>

<?php

if ($id) {

// editing so select a record

$sql = "SELECT * FROM enoch WHERE id=$id";

$result = mysql_query($sql);

$myrow = mysql_fetch_array($result);

$id = $myrow["id"];

$product = $myrow["product"];

$product_id = $myrow["product_id"];

$features = $myrow["features"];

$specs = $myrow["specs"];

$cat = $myrow["cat"];	

// print the id for editing



?>



<?php

}

  <input type=hidden name="id" value="<?php echo $id ?>">

Product name:<input type="Text" name="product" value="<?php echo $product ?>"><br>

Product_id name:<input type="Text" name="product_id" value="<?php echo $product_id ?>"><br>
Features <textarea cols="50" rows="5" name="features" id="features"><?php echo $features ?></textarea><p>
Specifications <textarea cols="50" rows="5" name="specs" id="features"><?php echo $specs ?></textarea><br>
Category:<input type="Text" name="cat" value="<?php echo $cat ?>"><br>

</form>

<?php

}

stolzyboy

that's because you are calling $id instead of $_GET['id']

before your if $id, put the

$id = $_GET['id'];

it obviously isn't getting in that loop, cuz it can't find it, also, in your input type=hidden, you need to make sure id is in there when passing the form, simply view source after you get the form, then look for the hidden field and make sure there is a value in the id's hidden tag

jamesflynn

I have the get id declared at the very top of the page. When I goto the form page to make the edits its in there liek this.

stolzyboy

change this line

$result = mysql_query($sql);

to these lines

echo $sql;
$result = mysql_query($sql) or die(mysql_error());

and see which statement is getting ran, then trouble shoot from there

jamesflynn

Dude I'm the man. I figured it out. No really your the man thnaks for all the help. Echoing the query like you recommended helped to troublshoot it. I found that the id for at the top was fine for a global to be read as GET but i had to define the id as $id = $_POST['id']; within that if for it to read it from the form then once I did that I defined each product variable within the if and same for the else.

I also got the delete part working. I had been looking at that thing too long yesterday and it got me frustrated. I came in today and it took me like 10mins to get it working.

Thanks alot for your time and wisdom
James Flynn