php in a function

[luckybob]

I am trying to make my entire site in php with functions and the like. I have run into a problem with some of the code. I am trying to do a while loop to access the content from a data base, but it is not working. I am kinda stumped as to what to do. Here is the code.

$db = connect();

$url = "index.php?body=editworkorder.php&page=Edit Work Order";

$info1=''.
'<center>'.
'<table width=97%>'.
'<tr bgcolor='#345487' align='center'><td width=20%><font color='white'>Apartment</font></td><td width=20%><font color='white'>Name</font></td><td width=20%><font color='white'>Phone</font></td><td width=20%><font color='white'>Assigned To</font></td><td width=20%><font color='white'>Status</font></td></tr>'.
'$result = mysql_query("SELECT * FROM workorder",$db);'.
''.
'while ($myrow = mysql_fetch_array($result)) {'.
''.
'printf("<tr bgcolor=#D2E5FF>");'.
'printf("<td><a href=\"%s&id=%s\">%s</a></td>", $url, $myrow["id"], $myrow["apt"]);'.
'printf("<td>%s</td>", $myrow["name"]);'.
'printf("<td>%s</td>", $myrow["phone"]);'.
'printf("<td>%s</td>", $myrow["assigned"]);'.
'if ($myrow["status"]=="Open")'.
'{'.
'printf("<td><font color=red>%s</font></td>", $myrow["status"]);'.
'}else{'.
'printf("<td>%s</td>", $myrow["status"]);'.
''.
'}'.
'printf("</tr>");'.
''.
'}'.
''.
'</table>'.
'</center>';

tab();
open_column();

news_block("View Contents",$info1);
close_column();
tab();

when I run this page it just gives me the code for the while loop. I understand why it does this, but I need a away to do this that works. Any help is appreciated.

Thanks,
Luckybob

[vallette]

I'd define your news_block function similar to this:

function news_block($title,$url) 
{

$result = mysql_query("SELECT * FROM workorder",$db);

echo "
<center> 
<table width=97%>
<tr bgcolor=#345487 align=center><td width=20%><font color=white>Apartment</font></td><td width=20%><font color=white>Name</font></td><td width=20%><font color=white>Phone</font></td><td width=20%><font color=white>Assigned To</font></td><td width=20%><font color=white>Status</font></td></tr>";

while ($myrow = mysql_fetch_array($result))
	{ 
	echo "
	<tr bgcolor=#D2E5FF>
		<td><a href=\"$url&id=".$myrow["id"]."\">".$myrow["apt"]."</a></td>
		<td>".$myrow["name"]."</td> 
		<td>".$myrow["phone"]."</td> 
		<td>".$myrow["assigned"]."</td>";
	if ($myrow["status"]=="Open"). 
		{ 
		echo "<td><font color=red>".$myrow["status"]."</font></td>"; 
		}
	else
		{
		echo "<td>".$myrow["status"]."</td>"; 
		}
	echo "</tr>";
	}
echo "
</table>
</center>"; 
}

the method you're trying to use would require the code in $info1 isn't really that practical

Dave

[JehovahsWord]

and luckybob, just in case you are new to php, just wanted to point out what you did in that code which showed the code instead of executed it.

you made it one big echo statement, and it was inside of apostraphies "'". Anything inside of these apostraphies don't execute, even variables inless you end the apostraphy and write the variable and go back into the echo. so you'd have to end the echo / print (whatever you use) statement and then go into your while loop and then it would work.

for example:

outputs: my name is Joe
$name = "joe";
echo "my name is $name";

outputs: my name is $name
$name = "joe";
echo 'my name is $name';

outputs: my name is Joe
$name = "joe";
echo 'my name is '.$name;

Brandon

[luckybob]

Yeah I know how to do the code regularly, I was trying to make it fit with the code I have. I was wondering if anyone had an idea of how to do this. As I got on with my day I relized that I would just need to write a seperate function to display the records. I do appreciate the time you guys spent though.

Luckybob

[sarahk]

have you read up on http://www.php.net/manual/en/function.eval.php

You might need to start a new thread and explain what you are trying to do with the existing code.

[luckybob]

Ok, what I was trying to acomplish is this:

This is the news function. I want to pass a variable to the function to create a basic table. This is of course simplified from the original, but maintains the concept.

function news_block($title, $info){
echo "<table>";
echo "<TR>";
echo "<TH>";
echo $title;
echo "</TH>;
echo "<TD>";
echo $info;
echo "</TD>";
echo "</TR>";
echo "</table>";
}

this code is kept on my script page, mainfile.php, for use on any other page I want. Now what I was trying to do is pass the while loop to this function by way of variable. I have come to the conclusion that this is not really fesable, so I am going to just write a new function that will output what I need to a variable, then I can pass it. I am sorry if I wasn't clear about what I was trying to do, as it gets a bit confusing when a lot of variables are passed around.

I do think making the seperate function to output the database info will work better for me in the long run.

Thanks for your time,
Luckybob