Problem with my code, need simple help...

Dje

Hi,
here is a simple php code that I am trying to get to work for a script of mine. Here is the code:

<html><body>
<?
$sales = Array('template1' => '4', 'template2' => '2');
$calls = Array('template2' => '56', 'template3' => '76');
if(is_array($sales) || is_array($calls)){
  $alltemplates = Array();
}
if(is_array($sales)){
  $temparray = array_keys($sales);
  array_push($alltemplates, $temparray);
}
if(is_array($calls)){
  $temparray = array_keys($calls);
  array_push($alltemplates, $temparray);
}
if(is_array($alltemplates)){
  $alltemplates = array_unique($alltemplates);
  while(list($key, $value) = each($alltemplates)){
?>
<? echo $value; ?>: <? echo $sales[$value]; ?>, <? echo $calls[$value]; ?><br>
<?
  }
}
?>
</body></html>

When I run that code, I get the following output:

Array: 
Warning: Illegal offset type in /www/website.com/test.php on line 20
, 
Warning: Illegal offset type in /www/website.com/test.php on line 20

I simply do not get why my array gets messed up and outputs "Array" as the first value in the $alltemplates array. Could someone help me figure out what could cause this?

What I want to do is pretty simple after all, I want to print every template name along with the number of calls and the number of sales associated with it. For this I want to get all the keys from my two arrays, and go through them and output the corresponding sales and calls (if any).

If someone could help me find what causes problems in my code, please let me know. It would be greatly appreciated!

Thanks!

Jerome

majiclab

The problem lies in here:

  while(list($key, $value) = each($alltemplates)){ 
?> 
<? echo $value; ?>: <? echo $sales[$value]; ?>, <? echo $calls[$value]; ?><br> 
<? 
  }

You are using $value as the index for the array instead of key.

It should look like this:

  while(list($key, $value) = each($alltemplates)){ 
?> 
<? echo $key; ?>: <? echo $sales[$key]; ?>, <? echo $calls[$key]; ?><br> 
<? 
  }

Hope that helps.

-Percy

Dje

hmm, I tried that, but it does not work either. the structure of $alltemplates should normally be the following before this line:
$alltemplates[0] = template1
$alltemplates[1] = template2
$alltemplates[2] = template3

This array contains the templates names in the values, and the keys are numerical. What I want to get out is the templates names, so the value is what I need. But my guess is that the $alltemplates array does not contain these values... so, in my opinion, the problem would reside in this part of the script:

if(is_array($sales)){ 
  $temparray = array_keys($sales); 
  array_push($alltemplates, $temparray); 
} 
if(is_array($calls)){ 
  $temparray = array_keys($calls); 
  array_push($alltemplates, $temparray); 
}

my guess is that it must reside in the array_keys function, but could not get any help from the php.net website regarding this. I am pretty sure I use the function correctly🙁

Dje

Thanks for the help, but I finally found out the problem was in the array_push function... seems you cannot pus an array into another array the way I was trying to... If anyone wants my workaround for this problem, here it is:

<html><body>
<?
$sales = Array('template1' => '4', 'template2' => '2');
$calls = Array('template2' => '56', 'template3' => '76');
if(is_array($sales)){
  $temparray1 = array_keys($sales);
}
else{
  $temparray1 = Array();
}
if(is_array($calls)){
  $temparray2 = array_keys($calls);
}
else{
  $temparray2 = Array();
}
$alltemplates = array_merge($temparray1, $temparray2);
if(is_array($alltemplates)){
  $alltemplates = array_unique($alltemplates);
  while(list($key, $value) = each($alltemplates)){
?>
<? echo $value; ?>: <? echo $sales[$value]; ?>, <? echo $calls[$value]; ?><br>
<?
  }
}
?>
</body></html>

majiclab

Sorry, I must admit that I didn't completely read your post... silly me.

Now that I actually understand what you are doing, I would try this:

<? 
$sales = Array('template1' => '4', 'template2' => '2'); 
$calls = Array('template2' => '56', 'template3' => '76'); 
$alltemplates = array();

if(is_array($sales)){ 
  $alltemplates = array_merge(array_keys($sales), $alltemplates);
} 

if(is_array($calls)){ 
  $alltemplates = array_merge(array_keys($calls), $alltemplates);
}
$alltemplates = array_unique($alltemplates);
if(count($alltemplates)){
  foreach ($alltemplates as $template) {
?> 
<?= $template ?>: <?= array_key_exists($template, $sales) ?$sales[$template] : 'None' ?>, <?= array_key_exists($template, $calls) ? $calls[ $template ] : 'None' ?><br> 
<? 
}
} 
?>

Hope that helps.

-Percy

Dje

thanks for that code, it's more concise and to the point than mine🙂